Component::primitive() - Code Metrics - Inspection of "Rearagned component structure." - mkungla/aframe-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (fb685e)

by Marko

created 2016-06-27 04:14 UTC

Component::primitive() A

↳ Parent: Component

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	1
crap	2

<?php
/** @formatter:off
 * ******************************************************************
 * Created by   Marko Kungla on Jun 25, 2016 - 7:51:42 PM
 * Contact      [email protected]
 * @copyright   2016 Marko Kungla - https://github.com/mkungla
 * @license     The MIT License (MIT)
 * 
 * @category       AframeVR
 * @package        aframe-php
 * 
 * Lang         PHP (php version >= 7)
 * Encoding     UTF-8
 * File         PositionComponent.php
 * Code format  PSR-2 and 12
 * @link        https://github.com/mkungla/aframe-php
 ^ @issues      https://github.com/mkungla/aframe-php/issues
 * ********************************************************************
 * Contributors:
 * @author Marko Kungla <[email protected]>
 * ********************************************************************
 * Comments:
 * @formatter:on */
namespace AframeVR\Core\Components\Geometry;

use \AframeVR\Core\Helpers\ComponentAbstract;
use \AframeVR\Interfaces\ComponentInterface;
use \AframeVR\Interfaces\Core\Components\Geometry\GeometryInterface;
use \AframeVR\Core\Exceptions\InvalidComponentArgumentException;

class Component extends ComponentAbstract implements ComponentInterface, GeometryInterface
{
    /**
     * Initialize Component
     *
     * {@inheritdoc}
     *
     * @return bool
     */
    public function initializeComponent() : bool
    {
        $this->setDomAttributeName('geometry');
        return true;
    }
    
    /**
     * Return DOM attribute contents
     *
     * @return string
     */
    public function getDomAttributeString() : string
    {
        $attrs = $this->getDOMAttributesArray();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        return '';
    }
    
    /**
     * Set geometry primitive
     * 
     * One of box, circle, cone, cylinder, plane, ring, sphere, torus, torusKnot.
     * 
     * @param string $primitive
     * @throws InvalidComponentArgumentException
     * @return void
     */
    public function primitive(string $primitive)
    {
        if (in_array($primitive, self::ALLOWED_PRIMITIVES)) {
            $this->dom_attributes = array();
            $method_provider = sprintf('%sMethods',ucfirst($primitive));
            $this->setMethodProvider($method_provider);
        } else {
            throw new InvalidComponentArgumentException((string) $primitive, 'Geometry::primitive');
        }
    }
    
    /**
     * translate
     *
     * {@inheritdoc}
     *
     * @param float|int $x
     * @param float|int $y
     * @param float|int $z
     * @return void
     */
    public function translate(float $x = 0, float $y = 0, float $z = 0)
    {
        $this->dom_attributes['translate'] = sprintf('%d %d %d', $x, $y, $z);
    }

    /**
     * Set Buffer
     *
     * {@inheritdoc}
     *
     * @param bool $buffer     
     * @return void       
     */
    public function buffer(bool $buffer = true)
    {
        $this->dom_attributes['buffer'] = $buffer ? 'true' : 'false';
    }
    
    /**
     * skipCache
     *
     * {@inheritdoc}
     *
     * @param bool $skipCache
     * @return void 
     */
    public function skipCache(bool $skipCache = false)
    {
        $this->dom_attributes['skipCache'] = $skipCache ? 'true' : 'false';
    }
}


1		<?php
2		/** @formatter:off
3		* ******************************************************************
4		* Created by Marko Kungla on Jun 25, 2016 - 7:51:42 PM
5		* Contact [email protected]
6		* @copyright 2016 Marko Kungla - https://github.com/mkungla
7		* @license The MIT License (MIT)
8		*
9		* @category AframeVR
10		* @package aframe-php
11		*
12		* Lang PHP (php version >= 7)
13		* Encoding UTF-8
14		* File PositionComponent.php
15		* Code format PSR-2 and 12
16		* @link https://github.com/mkungla/aframe-php
17		^ @issues https://github.com/mkungla/aframe-php/issues
18		* ********************************************************************
19		* Contributors:
20		* @author Marko Kungla <[email protected]>
21		* ********************************************************************
22		* Comments:
23		* @formatter:on */
24		namespace AframeVR\Core\Components\Geometry;
25
26		use \AframeVR\Core\Helpers\ComponentAbstract;
27		use \AframeVR\Interfaces\ComponentInterface;
28		use \AframeVR\Interfaces\Core\Components\Geometry\GeometryInterface;
29		use \AframeVR\Core\Exceptions\InvalidComponentArgumentException;
30
31		class Component extends ComponentAbstract implements ComponentInterface, GeometryInterface
32		{
33		/**
34		* Initialize Component
35		*
36		* {@inheritdoc}
37		*
38		* @return bool
39		*/
40	37	public function initializeComponent() : bool
41		{
42	37	$this->setDomAttributeName('geometry');
43	37	return true;
44		}
45
46		/**
47		* Return DOM attribute contents
48		*
49		* @return string
50		*/
51	1	public function getDomAttributeString() : string
52		{
53	1	$attrs = $this->getDOMAttributesArray();
		0 ignored issues – show Unused Code introduced 2016-06-27 04:07 UTC by Report Bug Copy Issue Report `$attrs` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
54	1	return '';
55		}
56
57		/**
58		* Set geometry primitive
59		*
60		* One of box, circle, cone, cylinder, plane, ring, sphere, torus, torusKnot.
61		*
62		* @param string $primitive
63		* @throws InvalidComponentArgumentException
64		* @return void
65		*/
66	35	public function primitive(string $primitive)
67		{
68	35	if (in_array($primitive, self::ALLOWED_PRIMITIVES)) {
69	34	$this->dom_attributes = array();
70	34	$method_provider = sprintf('%sMethods',ucfirst($primitive));
71	34	$this->setMethodProvider($method_provider);
72		} else {
73	2	throw new InvalidComponentArgumentException((string) $primitive, 'Geometry::primitive');
74		}
75	34	}
76
77		/**
78		* translate
79		*
80		* {@inheritdoc}
81		*
82		* @param float\|int $x
83		* @param float\|int $y
84		* @param float\|int $z
85		* @return void
86		*/
87	7	public function translate(float $x = 0, float $y = 0, float $z = 0)
88		{
89	7	$this->dom_attributes['translate'] = sprintf('%d %d %d', $x, $y, $z);
90	7	}
91
92		/**
93		* Set Buffer
94		*
95		* {@inheritdoc}
96		*
97		* @param bool $buffer
98		* @return void
99		*/
100	1	public function buffer(bool $buffer = true)
101		{
102	1	$this->dom_attributes['buffer'] = $buffer ? 'true' : 'false';
103	1	}
104
105		/**
106		* skipCache
107		*
108		* {@inheritdoc}
109		*
110		* @param bool $skipCache
111		* @return void
112		*/
113	1	public function skipCache(bool $skipCache = false)
114		{
115	1	$this->dom_attributes['skipCache'] = $skipCache ? 'true' : 'false';
116	1	}
117		}
118

mkungla / aframe-php

Branch — master (fb685e)

Component::primitive() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like