Sphere - Code Metrics - Inspection of "Minor code corrections." - mkungla/aframe-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ce557b...46a40a )

by Marko

created 2016-06-24 19:51 UTC

Sphere A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	2
dl	38
loc	38
ccs	19
cts	19
cp	1
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	8	8	1
A	radius()	5	5	1
A	segmentsHeight()	5	5	1
A	segmentsWidth()	5	5	1
A	defaults()	6	6	1

How to fix Duplicated Code

<?php
/** @formatter:off
 * ******************************************************************
 * Created by   Marko Kungla on Jun 20, 2016 - 10:28:02 PM
 * Contact      [email protected]
 * @copyright   2016 Marko Kungla - https://github.com/mkungla
 * @license     The MIT License (MIT)
 * 
 * @category       AframeVR
 * @package        aframe-php
 * 
 * Lang         PHP (php version >= 7)
 * Encoding     UTF-8
 * File         Primitive.php
 * Code format  PSR-2 and 12
 * @link        https://github.com/mkungla/aframe-php
 ^ @issues      https://github.com/mkungla/aframe-php/issues
 * ********************************************************************
 * Contributors:
 * @author Marko Kungla <[email protected]>
 * ********************************************************************
 * Comments:
 * @formatter:on */
namespace AframeVR\Extras\Primitives;

use \AframeVR\Core\Entity;
use \AframeVR\Core\Helpers\MeshAttributes;
use \AframeVR\Interfaces\PrimitiveInterface;

/**
 * <a-sphere>
 *
 * The sphere primitive creates a spherical or polyhedron shapes.
 * It wraps an entity that prescribes the geometry component with its geometric primitive set to sphere.
 */
class Sphere extends Entity implements PrimitiveInterface

{
    use MeshAttributes;

    public function init()
    {
        $this->component('Material');
        $this->component('Geometry')->primitive('sphere');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        
        /* Load defaults */
        $this->defaults();
    }

    public function radius(float $radius = 0.85): Entity
    {
        $this->component('Geometry')->radius($radius);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        return $this;
    }

    public function segmentsHeight($segmentsHeigh = 18)
    {
        $this->component('Geometry')->segmentsHeight($segmentsHeigh);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        return $this;
    }

    public function segmentsWidth($segmentsWidth = 36)
    {
        $this->component('Geometry')->segmentsWidth($segmentsWidth);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        return $this;
    }

    public function defaults()
    {
        $this->radius();
        $this->segmentsHeight();
        $this->segmentsWidth();
    }
}
 

Push — master ( ce557b...46a40a )

Sphere A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/** @formatter:off
3			* ******************************************************************
4			* Created by Marko Kungla on Jun 20, 2016 - 10:28:02 PM
5			* Contact [email protected]
6			* @copyright 2016 Marko Kungla - https://github.com/mkungla
7			* @license The MIT License (MIT)
8			*
9			* @category AframeVR
10			* @package aframe-php
11			*
12			* Lang PHP (php version >= 7)
13			* Encoding UTF-8
14			* File Primitive.php
15			* Code format PSR-2 and 12
16			* @link https://github.com/mkungla/aframe-php
17			^ @issues https://github.com/mkungla/aframe-php/issues
18			* ********************************************************************
19			* Contributors:
20			* @author Marko Kungla <[email protected]>
21			* ********************************************************************
22			* Comments:
23			* @formatter:on */
24			namespace AframeVR\Extras\Primitives;
25
26			use \AframeVR\Core\Entity;
27			use \AframeVR\Core\Helpers\MeshAttributes;
28			use \AframeVR\Interfaces\PrimitiveInterface;
29
30			/**
31			* <a-sphere>
32			*
33			* The sphere primitive creates a spherical or polyhedron shapes.
34			* It wraps an entity that prescribes the geometry component with its geometric primitive set to sphere.
35			*/
36		View Code Duplication	class Sphere extends Entity implements PrimitiveInterface
			0 ignored issues – show Duplication introduced 2016-06-24 12:48 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37			{
38			use MeshAttributes;
39
40	9		public function init()
41			{
42	9		$this->component('Material');
43	9		$this->component('Geometry')->primitive('sphere');
			0 ignored issues – show Bug introduced 2016-06-24 12:48 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `AframeVR\Interfaces\ComponentInterface` as the method `primitive()` does only exist in the following implementations of said interface: `AframeVR\Components\Geometry`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
44
45			/* Load defaults */
46	9		$this->defaults();
47	9		}
48
49	9		public function radius(float $radius = 0.85): Entity
50			{
51	9		$this->component('Geometry')->radius($radius);
			0 ignored issues – show Bug introduced 2016-06-24 12:48 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `AframeVR\Interfaces\ComponentInterface` as the method `radius()` does only exist in the following implementations of said interface: `AframeVR\Components\Geometry`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
52	9		return $this;
53			}
54
55	9		public function segmentsHeight($segmentsHeigh = 18)
56			{
57	9		$this->component('Geometry')->segmentsHeight($segmentsHeigh);
			0 ignored issues – show Bug introduced 2016-06-24 12:48 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `AframeVR\Interfaces\ComponentInterface` as the method `segmentsHeight()` does only exist in the following implementations of said interface: `AframeVR\Components\Geometry`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
58	9		return $this;
59			}
60
61	9		public function segmentsWidth($segmentsWidth = 36)
62			{
63	9		$this->component('Geometry')->segmentsWidth($segmentsWidth);
			0 ignored issues – show Bug introduced 2016-06-24 12:48 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `AframeVR\Interfaces\ComponentInterface` as the method `segmentsWidth()` does only exist in the following implementations of said interface: `AframeVR\Components\Geometry`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
64	9		return $this;
65			}
66
67	5		public function defaults()
68			{
69	5		$this->radius();
70	5		$this->segmentsHeight();
71	5		$this->segmentsWidth();
72	5		}
73			}
74

mkungla / aframe-php

Push — master ( ce557b...46a40a )

Sphere A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like