TK\API\ValueObject\Factory\GetTimetableParametersFactory::createFromArray()

Complexity

Conditions	5
Paths	8

Size

Total Lines	39
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function createFromArray(array $parameters) : GetTimetableParameters
    {
        $originDestinationInformation = $parameters['OTA_AirScheduleRQ']['OriginDestinationInformation'];
        $originLocation = new Location(
            $originDestinationInformation['OriginLocation']['LocationCode'],
            $originDestinationInformation['OriginLocation']['MultiAirportCityInd']
        );
        $destinationLocation = new Location(
            $originDestinationInformation['DestinationLocation']['LocationCode'],
            $originDestinationInformation['DestinationLocation']['MultiAirportCityInd']
        );
        $departureDateTime = new DepartureDateTime(
            DateTimeImmutable::createFromFormat('Y-m-d', $originDestinationInformation['DepartureDateTime']['Date']),

It seems like DateTimeImmutable::createFromFormat('Y-m-d', $originDestinationInformation['DepartureDateTime']['Date']) can also be of type false; however, parameter $date of TK\API\ValueObject\DepartureDateTime::__construct() does only seem to accept DateTimeImmutable, maybe add an additional type check?

            'P3D',
            'P3D'
        );
        $originDestinationInformationObject = new OriginDestinationInformation(
            $departureDateTime,
            $originLocation,
            $destinationLocation
        );
        $airScheduleRQ = new AirScheduleRQ($originDestinationInformationObject);
        if (array_key_exists('AirlineCode', $parameters['OTA_AirScheduleRQ'])) {
            $airScheduleRQ = $airScheduleRQ->withAirlineCode($parameters['OTA_AirScheduleRQ']['AirlineCode']);
        }
        if (array_key_exists('FlightTypePref', $parameters['OTA_AirScheduleRQ']) &&
            $parameters['OTA_AirScheduleRQ']['FlightTypePref']['DirectAndNonStopOnlyInd'] === true) {
            $airScheduleRQ = $airScheduleRQ->withDirectAndNonStopOnlyInd();
        }
        $getTimetableParameters = new GetTimetableParameters(
            $airScheduleRQ,
            $parameters['scheduleType'],
            $parameters['tripType']
        );
        if (array_key_exists('returnDate', $parameters)) {
            $returnDate = DateTimeImmutable::createFromFormat('Y-m-d', $parameters['returnDate']);
            $getTimetableParameters = $getTimetableParameters->withReturnDate($returnDate);

It seems like $returnDate can also be of type false; however, parameter $returnDate of TK\API\ValueObject\GetTimetableParameters::withReturnDate() does only seem to accept DateTimeImmutable|null, maybe add an additional type check?

        }
        return $getTimetableParameters;
    }