TK\API\ValueObject\Factory\CalculateFlightMilesParametersFactory

Complexity

Total Complexity

12

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	createFromArray()	0	33	10
A	createFromJson()	0	9	2

<?php
declare(strict_types=1);

namespace TK\API\ValueObject\Factory;

use DateTimeImmutable;
use TK\API\Exception\InvalidArgumentException;
use TK\API\ValueObject\CalculateFlightMilesParameters;

class CalculateFlightMilesParametersFactory implements ValueObjectFactoryInterface
{
    /**
     * @param array $parameters
     * @return CalculateFlightMilesParameters
     * @throws \Exception
     */
    public static function createFromArray(array $parameters) : CalculateFlightMilesParameters
    {
        $calculateFlightMilesParameters = new CalculateFlightMilesParameters(
            $parameters['origin'],
            $parameters['destination']
        );
        if (array_key_exists('cabin_code', $parameters) && $parameters['cabin_code'] === 'Y') {
            $calculateFlightMilesParameters = $calculateFlightMilesParameters->withCabinCode();
        }
        if (array_key_exists('class_code', $parameters) && $parameters['class_code'] === 'Y') {
            $calculateFlightMilesParameters = $calculateFlightMilesParameters->withClassCode();
        }
        if (array_key_exists('marketingClassCode', $parameters)) {
            $calculateFlightMilesParameters = $calculateFlightMilesParameters
                ->withMarketingClassCode($parameters['marketingClassCode']);
        }
        if (array_key_exists('card_type', $parameters)) {
            $calculateFlightMilesParameters = $calculateFlightMilesParameters
                ->withCardType($parameters['card_type']);
        }
        if (array_key_exists('flightDate', $parameters)) {
            $calculateFlightMilesParameters = $calculateFlightMilesParameters
                ->withFlightDate(DateTimeImmutable::createFromFormat('d.m.Y', $parameters['flightDate']));

It seems like DateTimeImmutable::createFromFormat('d.m.Y', $parameters['flightDate']) can also be of type false; however, parameter $flightDate of TK\API\ValueObject\CalculateFlightMilesParameters::withFlightDate() does only seem to accept DateTimeImmutable, maybe add an additional type check?

        }
        if (array_key_exists('operatingFlightNumber', $parameters)) {
            $calculateFlightMilesParameters = $calculateFlightMilesParameters
                ->withOperatingFlightNumber($parameters['operatingFlightNumber']);
        }
        if (array_key_exists('marketingFlightNumber', $parameters)) {
            $calculateFlightMilesParameters = $calculateFlightMilesParameters
                ->withMarketingFlightNumber($parameters['marketingFlightNumber']);
        }
        return $calculateFlightMilesParameters;
    }


    /**
     * @param string $json
     * @return CalculateFlightMilesParameters
     * @throws InvalidArgumentException
     * @throws \Exception
     */
    public static function createFromJson(string $json) : CalculateFlightMilesParameters
    {
        $parameters = json_decode($json, (bool) JSON_OBJECT_AS_ARRAY);
        if (json_last_error() !== JSON_ERROR_NONE) {
            throw new InvalidArgumentException(
                'CalculateFlightMilesParametersFactory Error: ' . json_last_error_msg()
            );
        }
        return self::createFromArray($parameters);
    }
}