TK\API\ValueObject\Factory\CalculateAwardMilesWithTaxParametersFactory

Complexity

Total Complexity

18

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
F	createFromArray()	0	53	16
A	createFromJson()	0	9	2

<?php
declare(strict_types=1);

namespace TK\API\ValueObject\Factory;

use DateTimeImmutable;
use TK\API\Exception\InvalidArgumentException;
use TK\API\ValueObject\CalculateAwardMilesWithTaxParameters;

class CalculateAwardMilesWithTaxParametersFactory implements ValueObjectFactoryInterface
{
    /**
     * @param array $parameters
     * @return CalculateAwardMilesWithTaxParameters
     * @throws \Exception
     */
    public static function createFromArray(array $parameters) : CalculateAwardMilesWithTaxParameters
    {
        $calculateAwardMilesWithTaxParameters = new CalculateAwardMilesWithTaxParameters(
            $parameters['awardType']
        );
        if (array_key_exists('wantMoreMiles', $parameters) && $parameters['wantMoreMiles'] === 'T') {
            $calculateAwardMilesWithTaxParameters = $calculateAwardMilesWithTaxParameters->withSeatGuaranteed();
        }
        if (array_key_exists('isOneWay', $parameters) && $parameters['isOneWay'] === 'T') {
            $calculateAwardMilesWithTaxParameters = $calculateAwardMilesWithTaxParameters->withOneWay();
        }
        if (array_key_exists('departureOrigin', $parameters)) {
            $calculateAwardMilesWithTaxParameters = $calculateAwardMilesWithTaxParameters
                ->withDepartureOrigin($parameters['departureOrigin']);
        }
        if (array_key_exists('departureDestination', $parameters)) {
            $calculateAwardMilesWithTaxParameters = $calculateAwardMilesWithTaxParameters
                ->withDepartureDestination($parameters['departureDestination']);
        }

        if (array_key_exists('departureDateDay', $parameters) &&
            array_key_exists('departureDateMonth', $parameters) &&
            array_key_exists('departureDateYear', $parameters)
        ) {
            $departureDate = $parameters['departureDateYear'] . '-' . $parameters['departureDateMonth'] .
                '-' . $parameters['departureDateDay'];
            $calculateAwardMilesWithTaxParameters = $calculateAwardMilesWithTaxParameters
                ->withDepartureDate(DateTimeImmutable::createFromFormat('Y-m-d', $departureDate));

It seems like DateTimeImmutable::createFromFormat('Y-m-d', $departureDate) can also be of type false; however, parameter $date of TK\API\ValueObject\CalculateAwardMilesWithTaxParameters::withDepartureDate() does only seem to accept DateTimeImmutable, maybe add an additional type check?

        }

        if (array_key_exists('arrivalOrigin', $parameters)) {
            $calculateAwardMilesWithTaxParameters = $calculateAwardMilesWithTaxParameters
                ->withArrivalOrigin($parameters['arrivalOrigin']);
        }
        if (array_key_exists('arrivalDestination', $parameters)) {
            $calculateAwardMilesWithTaxParameters = $calculateAwardMilesWithTaxParameters
                ->withArrivalDestination($parameters['arrivalDestination']);
        }

        if (array_key_exists('arrivalDateDay', $parameters) &&
            array_key_exists('arrivalDateMonth', $parameters) &&
            array_key_exists('arrivalDateYear', $parameters)
        ) {
            $arrivalDate = $parameters['arrivalDateYear'] . '-' . $parameters['arrivalDateMonth'] .
                '-' . $parameters['arrivalDateDay'];
            $calculateAwardMilesWithTaxParameters = $calculateAwardMilesWithTaxParameters
                ->withArrivalDate(DateTimeImmutable::createFromFormat('Y-m-d', $arrivalDate));

It seems like DateTimeImmutable::createFromFormat('Y-m-d', $arrivalDate) can also be of type false; however, parameter $date of TK\API\ValueObject\CalculateAwardMilesWithTaxParameters::withArrivalDate() does only seem to accept DateTimeImmutable, maybe add an additional type check?

        }
        if (array_key_exists('ptcType', $parameters)) {
            $calculateAwardMilesWithTaxParameters = $calculateAwardMilesWithTaxParameters
                ->withPassengerType($parameters['ptcType']);
        }
        return $calculateAwardMilesWithTaxParameters;
    }

    /**
     * @param string $json
     * @return CalculateAwardMilesWithTaxParameters
     * @throws InvalidArgumentException
     * @throws \Exception
     */
    public static function createFromJson(string $json) : CalculateAwardMilesWithTaxParameters
    {
        $parameters = json_decode($json, (bool) JSON_OBJECT_AS_ARRAY);
        if (json_last_error() !== JSON_ERROR_NONE) {
            throw new InvalidArgumentException(
                'CalculateAwardMilesWithTaxParametersFactory Error: ' . json_last_error_msg()
            );
        }
        return self::createFromArray($parameters);
    }
}