RedisGraph::commit()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 3
Code Lines 1

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 1
eloc 1
c 1
b 0
f 0
nc 1
nop 1
dl 0
loc 3
rs 10
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Redislabs\Module\RedisGraph;
6
7
use Redislabs\Interfaces\ModuleInterface;
8
use Redislabs\Module\ModuleTrait;
9
use Redislabs\Module\RedisGraph\Exception\InvalidQueryException;
10
use Redislabs\Module\RedisGraph\Interfaces\QueryInterface;
11
use Redislabs\Module\RedisGraph\Command\Query;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Redislabs\Module\RedisGraph\Query. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
12
use Redislabs\Module\RedisGraph\Command\Explain;
13
use Redislabs\Module\RedisGraph\Command\Delete;
14
15
class RedisGraph implements ModuleInterface
16
{
17
    use ModuleTrait;
18
19
    protected static string $moduleName = 'RedisGraph';
20
21
22
    public function rawQuery(QueryInterface $query)
23
    {
24
        return $this->runCommand(
25
            Query::createCommandWithArguments($query)
26
        );
27
    }
28
29
    public function query(QueryInterface $query): Result
30
    {
31
        $response = $this->rawQuery($query);
32
        if (is_string($response)) {
33
            throw new InvalidQueryException($response);
34
        }
35
        return Result::createFromResponse($response);
36
    }
37
38
    public function delete(string $name): ?string
39
    {
40
        return $this->runCommand(
41
            Delete::createCommandWithArguments($name)
42
        );
43
    }
44
45
    public function explain(QueryInterface $query): string
46
    {
47
        $response =  $this->runCommand(
48
            Explain::createCommandWithArguments($query)
49
        );
50
        return implode(' ', $response);
51
    }
52
53
    public function commit(QueryInterface $query): Result
54
    {
55
        return $this->query($query);
56
    }
57
}
58