mjmunger / farret

src/TemplateHook.php

<?php
/**
 * {CLASS SUMMARY}
 *
 * Date: 7/27/18
 * Time: 11:26 PM
 * @author Michael Munger <michael@highpoweredhelp.com>
 */

namespace HPHIO\Farret;


class TemplateHook extends AbstractTag
{
    public function getLabel()
    {
        $matches = [];
        $result = (preg_match_all($this->pattern, $this->tag,$matches, PREG_SET_ORDER) !== false);

        return ($result ? $matches[0][1] : false);
    }

    public function setup() {
        $this->type = AbstractTag::HOOK;

The property type does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function fart($dictionary) {
        $label = $this->getLabel();
        foreach($dictionary as $find => $replace) {
            if(strcmp($find,$label) === 0) {

It seems like $label can also be of type false; however, parameter $str2 of strcmp() does only seem to accept string, maybe add an additional type check?

                $this->replacement = $replace;
                return true;
            }
        }

        return false;
    }

    public function getTag() {
        return $this->tag;
    }

    public function getReplacement()
    {
        return $this->replacement;
    }

}