Location\GetBoundsTrait

Complexity

Total Complexity

2

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getBounds()	0	20	2

<?php
declare(strict_types=1);

namespace Location;

/**
 * Trait GetBoundsTrait
 *
 * @package Location
 *
 * @property Coordinate[] $points
 */
trait GetBoundsTrait
{
    /**
     * @return Bounds
     */
    public function getBounds(): Bounds
    {
        $latMin = 90.0;
        $latMax = -90.0;
        $lngMin = 180.0;
        $lngMax = -180.0;

        /** @var Coordinate $point */
        foreach ($this->getPoints() as $point) {

It seems like getPoints() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $latMin = min($point->getLat(), $latMin);
            $lngMin = min($point->getLng(), $lngMin);
            $latMax = max($point->getLat(), $latMax);
            $lngMax = max($point->getLng(), $lngMax);
        }

        return new Bounds(
            new Coordinate($latMax, $lngMin),
            new Coordinate($latMin, $lngMax)
        );
    }
}