Issues in StringExcerpt.php (develop) - Issues in develop - mishal/iless - Measure and Improve Code Quality continuously with Scrutinizer

Issues (191)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/ILess/Util/StringExcerpt.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the ILess
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ILess\Util;

use ILess\CLI\ANSIColor;

/**
 * String excerpt.
 */
final class StringExcerpt
{
    /**
     * Array of lines.
     *
     * @var array
     */
    protected $lines = [];

    /**
     * Current line.
     *
     * @var int
     */
    protected $currentLine;

    /**
     * Current column.
     *
     * @var int
     */
    protected $currentColumn;

    /**
     * The line numbers width.
     *
     * @var string
     */
    protected $lineWidth;

    /**
     * Constructor.
     *
     * @param array $lines The array of lines
     * @param int $currentLine The current line
     * @param int $currentColumn The current column
     */
    public function __construct(array $lines, $currentLine, $currentColumn = null)
    {
        $this->lines = $lines;
        $this->currentLine = $currentLine;
        $this->currentColumn = $currentColumn;
        $this->lineWidth = strlen((string) key($this->lines));
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /**
     * Converts the exceprt to colorized string for terminal.
     *
     * @return string
     */
    public function toTerminal()
    {
        $output = '';
        foreach ($this->lines as $lineNumber => $lineContent) {
            if ($lineNumber + 1 == $this->currentLine) {
                // current column will be highlighted
                if ($this->currentColumn !== null) {
                    $output .= ANSIColor::colorize(sprintf("%{$this->lineWidth}s: ", $lineNumber + 1), 'grey+inverse');
                    $output .= ANSIColor::colorize(substr($lineContent, 0, $this->currentColumn - 1), 'grey');
                    $output .= ANSIColor::colorize(substr($lineContent, $this->currentColumn - 1, 1), 'red+bold');
                    $output .= ANSIColor::colorize(substr($lineContent, $this->currentColumn), 'red');
                    $output .= "\n";
                } else {
                    $output .= ANSIColor::colorize(sprintf("%{$this->lineWidth}s: %s\n",
                        $lineNumber + 1, $lineContent), 'red');
                }
            } else {
                $output .= ANSIColor::colorize(sprintf("%{$this->lineWidth}s: %s\n", $lineNumber + 1, $lineContent),
                    'grey');
            }
        }

        return $output;
    }

    /**
     * Converts the except to plain text.
     *
     * @return string
     */
    public function toText()
    {
        return strip_tags($this->toHtml());
    }

    /**
     * Coverts the lines to HTML.
     *
     * @return string The HTML
     */
    public function toHtml()
    {
        $html = '';
        foreach ($this->lines as $lineNumber => $lineContent) {
            if ($lineNumber + 1 == $this->currentLine) {
                // current column will be highlighted
                if ($this->currentColumn !== null) {
                    $html .= sprintf("<span class=\"iless-line iless-current-line\">%{$this->lineWidth}s: %s</span>\n",
                        $lineNumber + 1,
                        substr_replace($lineContent,
                            '<span class="iless-current-column">' . substr($lineContent, $this->currentColumn - 1,
                                1) . '</span>', $this->currentColumn - 1, 1));
                } else {
                    $html .= sprintf("<span class=\"iless-line iless-current-line\">%{$this->lineWidth}s: %s</span>\n",
                        $lineNumber + 1, $lineContent
                    );
                }
            } else {
                $html .= sprintf("<span class=\"iless-line\">%{$this->lineWidth}s: %s</span>\n",
                    $lineNumber + 1, $lineContent);
            }
        }

        return $html;
    }

    /**
     * Converts the object to string.
     *
     * @return string
     */
    public function __toString()
    {
        return $this->toText();
    }
}


1			<?php
2
3			/*
4			* This file is part of the ILess
5			*
6			* For the full copyright and license information, please view the LICENSE
7			* file that was distributed with this source code.
8			*/
9
10			namespace ILess\Util;
11
12			use ILess\CLI\ANSIColor;
13
14			/**
15			* String excerpt.
16			*/
17			final class StringExcerpt
18			{
19			/**
20			* Array of lines.
21			*
22			* @var array
23			*/
24			protected $lines = [];
25
26			/**
27			* Current line.
28			*
29			* @var int
30			*/
31			protected $currentLine;
32
33			/**
34			* Current column.
35			*
36			* @var int
37			*/
38			protected $currentColumn;
39
40			/**
41			* The line numbers width.
42			*
43			* @var string
44			*/
45			protected $lineWidth;
46
47			/**
48			* Constructor.
49			*
50			* @param array $lines The array of lines
51			* @param int $currentLine The current line
52			* @param int $currentColumn The current column
53			*/
54			public function __construct(array $lines, $currentLine, $currentColumn = null)
55			{
56			$this->lines = $lines;
57			$this->currentLine = $currentLine;
58			$this->currentColumn = $currentColumn;
59			$this->lineWidth = strlen((string) key($this->lines));
			0 ignored issues – show Documentation Bug introduced 2016-03-10 07:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$lineWidth` was declared of type `string`, but `strlen((string) key($this->lines))` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
60			}
61
62			/**
63			* Converts the exceprt to colorized string for terminal.
64			*
65			* @return string
66			*/
67			public function toTerminal()
68			{
69			$output = '';
70			foreach ($this->lines as $lineNumber => $lineContent) {
71			if ($lineNumber + 1 == $this->currentLine) {
72			// current column will be highlighted
73			if ($this->currentColumn !== null) {
74			$output .= ANSIColor::colorize(sprintf("%{$this->lineWidth}s: ", $lineNumber + 1), 'grey+inverse');
75			$output .= ANSIColor::colorize(substr($lineContent, 0, $this->currentColumn - 1), 'grey');
76			$output .= ANSIColor::colorize(substr($lineContent, $this->currentColumn - 1, 1), 'red+bold');
77			$output .= ANSIColor::colorize(substr($lineContent, $this->currentColumn), 'red');
78			$output .= "\n";
79			} else {
80			$output .= ANSIColor::colorize(sprintf("%{$this->lineWidth}s: %s\n",
81			$lineNumber + 1, $lineContent), 'red');
82			}
83			} else {
84			$output .= ANSIColor::colorize(sprintf("%{$this->lineWidth}s: %s\n", $lineNumber + 1, $lineContent),
85			'grey');
86			}
87			}
88
89			return $output;
90			}
91
92			/**
93			* Converts the except to plain text.
94			*
95			* @return string
96			*/
97			public function toText()
98			{
99			return strip_tags($this->toHtml());
100			}
101
102			/**
103			* Coverts the lines to HTML.
104			*
105			* @return string The HTML
106			*/
107			public function toHtml()
108			{
109			$html = '';
110			foreach ($this->lines as $lineNumber => $lineContent) {
111			if ($lineNumber + 1 == $this->currentLine) {
112			// current column will be highlighted
113			if ($this->currentColumn !== null) {
114			$html .= sprintf("<span class=\"iless-line iless-current-line\">%{$this->lineWidth}s: %s</span>\n",
115			$lineNumber + 1,
116			substr_replace($lineContent,
117			'<span class="iless-current-column">' . substr($lineContent, $this->currentColumn - 1,
118			1) . '</span>', $this->currentColumn - 1, 1));
119			} else {
120			$html .= sprintf("<span class=\"iless-line iless-current-line\">%{$this->lineWidth}s: %s</span>\n",
121			$lineNumber + 1, $lineContent
122			);
123			}
124			} else {
125			$html .= sprintf("<span class=\"iless-line\">%{$this->lineWidth}s: %s</span>\n",
126			$lineNumber + 1, $lineContent);
127			}
128			}
129
130			return $html;
131			}
132
133			/**
134			* Converts the object to string.
135			*
136			* @return string
137			*/
138			public function __toString()
139			{
140			return $this->toText();
141			}
142			}
143

mishal / iless

Issues (191)

Security Analysis no request data

lib/ILess/Util/StringExcerpt.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like