Issues in MediaNode.php (develop) - Issues in develop - mishal/iless - Measure and Improve Code Quality continuously with Scrutinizer

Issues (191)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/ILess/Node/MediaNode.php (3 issues)

Labels

Severity

Major 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the ILess
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ILess\Node;

use ILess\Context;
use ILess\Exception\Exception;
use ILess\FileInfo;
use ILess\Output\OutputInterface;
use ILess\Visitor\VisitorInterface;

/**
 * Media.
 */
class MediaNode extends DirectiveNode
{
    /**
     * Media type.
     *
     * @var string
     */
    protected $type = 'Media';

    /**
     * Current index.
     *
     * @var int
     */
    public $index = 0;

    /**
     * Features.
     *
     * @var ValueNode
     */
    public $features;

    /**
     * Rules.
     *
     * @var array
     */
    public $rules = [];

    /**
     * Referenced flag.
     *
     * @var bool
     */
    public $isReferenced = false;

    /**
     * @var array
     */
    public $allExtends = [];

    /**
     * Constructor.
     *
     * @param array $value The array of values
     * @param array $features The array of features
     * @param int $index The index
     * @param FileInfo $currentFileInfo The current file info
     */
    public function __construct(
        array $value = [],
        array $features = [],
        $index = 0,
        FileInfo $currentFileInfo = null
    ) {
        $this->index = $index;
        $this->currentFileInfo = $currentFileInfo;

        $selector = new SelectorNode([], [], null, $this->index, $this->currentFileInfo);
        $selectors = $selector->createEmptySelectors();

        $this->features = new ValueNode($features);
        $this->rules = [new RulesetNode($selectors, $value)];
        $this->rules[0]->allowImports = true;
    }

    /**
     * {@inheritdoc}
     */
    public function accept(VisitorInterface $visitor)
    {
        if ($this->features) {
            $this->features = $visitor->visit($this->features);
        }

        $this->rules = $visitor->visitArray($this->rules);

    }

    /**
     * {@inheritdoc}
     */
    public function generateCSS(Context $context, OutputInterface $output)
    {
        $output->add('@media ', $this->currentFileInfo, $this->index);
        $this->features->generateCSS($context, $output);
        $this->outputRuleset($context, $output, $this->rules);
    }

    /**
     * Compiles the node.
     *
     * @param Context $context The context
     * @param array|null $arguments Array of arguments
     * @param bool|null $important Important flag
     *
     * @return RulesetNode
     */
    public function compile(Context $context, $arguments = null, $important = null)
    {
        if (!$context->mediaBlocks) {
            $context->mediaBlocks = [];
            $context->mediaPath = [];
        }

        $media = new self([], [], $this->index, $this->currentFileInfo);

        if ($this->debugInfo) {
            $this->rules[0]->debugInfo = $this->debugInfo;
            $media->debugInfo = $this->debugInfo;
        }

        $strictMathBypass = false;
        if (!$context->strictMath) {
            $strictMathBypass = true;
            $context->strictMath = true;
        }

        try {
            $media->features = $this->features->compile($context);
        } catch (Exception $e) {
            // empty on purpose
        }

        if ($strictMathBypass) {
            $context->strictMath = false;
        }

        $context->mediaPath[] = $media;
        $context->mediaBlocks[] = $media;

        $this->rules[0]->functionRegistry =
            isset($context->frames[0]) && $context->frames[0]->functionRegistry ?
                $context->frames[0]->functionRegistry->inherit() :
                $context->getFunctionRegistry()->inherit();

        array_unshift($context->frames, $this->rules[0]);
        $media->rules = [$this->rules[0]->compile($context)];
        array_shift($context->frames);

        array_pop($context->mediaPath);

        return count($context->mediaPath) == 0 ? $media->compileTop($context) : $media->compileNested($context);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Compiles top media.
     *
     * @param Context $context
     *
     * @return RulesetNode
     */
    public function compileTop(Context $context)
    {
        $result = $this;
        if (count($context->mediaBlocks) > 1) {
            $selector = new SelectorNode([], [], null, $this->index, $this->currentFileInfo);
            $selectors = $selector->createEmptySelectors();

            $result = new RulesetNode($selectors, $context->mediaBlocks);
            $result->multiMedia = true;
        }
        $context->mediaBlocks = [];
        $context->mediaPath = [];

        return $result;

    }

    /**
     * Compiles nested media.
     *
     * @param Context $context
     *
     * @return RulesetNode
     */
    public function compileNested(Context $context)
    {
        $path = array_merge($context->mediaPath, [$this]);

        // Extract the media-query conditions separated with `,` (OR).
        foreach ($path as $key => $p) {
            $value = $p->features instanceof ValueNode ? $p->features->value : $p->features;
            $path[$key] = is_array($value) ? $value : [$value];
        }

        // Trace all permutations to generate the resulting media-query.
        //
        // (a, b and c) with nested (d, e) ->
        //a and d
        //a and e
        //b and c and d
        //b and c and e

        $permuted = $this->permute($path);
        $expressions = [];
        foreach ($permuted as $path) {
            for ($i = 0, $len = count($path); $i < $len; ++$i) {
                $path[$i] = $path[$i] instanceof GenerateCSSInterface ? $path[$i] : new AnonymousNode($path[$i]);
            }
            for ($i = count($path) - 1; $i > 0; --$i) {
                array_splice($path, $i, 0, [new AnonymousNode('and')]);
            }
            $expressions[] = new ExpressionNode($path);
        }

        $this->features = new ValueNode($expressions);

        // Fake a tree-node that doesn't output anything.
        return new RulesetNode([], []);
    }

    /**
     * Creates permutations.
     *
     * @param array $array The array
     *
     * @return array
     */
    public function permute(array $array)
    {
        if (!count($array)) {
            return [];
        } elseif (count($array) === 1) {
            return $array[0];
        } else {
            $result = [];
            $rest = $this->permute(array_slice($array, 1));
            foreach ($rest as $r) {
                foreach ($array[0] as $a) {
                    $result[] = array_merge(
                        is_array($a) ? $a : [$a], is_array($r) ? $r : [$r]
                    );
                }
            }
        }

        return $result;
    }

    /**
     * Bubbles the selectors.
     *
     * @param array $selectors
     */
    public function bubbleSelectors(array $selectors)
    {
        if (!$selectors) {
            return;
        }

        $this->rules = [
            new RulesetNode($selectors, [$this->rules[0]]),
        ];
    }

    /**
     * @return bool
     */
    public function isRulesetLike()
    {
        return true;
    }
}


1			<?php
2
3			/*
4			* This file is part of the ILess
5			*
6			* For the full copyright and license information, please view the LICENSE
7			* file that was distributed with this source code.
8			*/
9
10			namespace ILess\Node;
11
12			use ILess\Context;
13			use ILess\Exception\Exception;
14			use ILess\FileInfo;
15			use ILess\Output\OutputInterface;
16			use ILess\Visitor\VisitorInterface;
17
18			/**
19			* Media.
20			*/
21			class MediaNode extends DirectiveNode
22			{
23			/**
24			* Media type.
25			*
26			* @var string
27			*/
28			protected $type = 'Media';
29
30			/**
31			* Current index.
32			*
33			* @var int
34			*/
35			public $index = 0;
36
37			/**
38			* Features.
39			*
40			* @var ValueNode
41			*/
42			public $features;
43
44			/**
45			* Rules.
46			*
47			* @var array
48			*/
49			public $rules = [];
50
51			/**
52			* Referenced flag.
53			*
54			* @var bool
55			*/
56			public $isReferenced = false;
57
58			/**
59			* @var array
60			*/
61			public $allExtends = [];
62
63			/**
64			* Constructor.
65			*
66			* @param array $value The array of values
67			* @param array $features The array of features
68			* @param int $index The index
69			* @param FileInfo $currentFileInfo The current file info
70			*/
71			public function __construct(
72			array $value = [],
73			array $features = [],
74			$index = 0,
75			FileInfo $currentFileInfo = null
76			) {
77			$this->index = $index;
78			$this->currentFileInfo = $currentFileInfo;
79
80			$selector = new SelectorNode([], [], null, $this->index, $this->currentFileInfo);
81			$selectors = $selector->createEmptySelectors();
82
83			$this->features = new ValueNode($features);
84			$this->rules = [new RulesetNode($selectors, $value)];
85			$this->rules[0]->allowImports = true;
86			}
87
88			/**
89			* {@inheritdoc}
90			*/
91			public function accept(VisitorInterface $visitor)
92			{
93			if ($this->features) {
94			$this->features = $visitor->visit($this->features);
95			}
96
97			$this->rules = $visitor->visitArray($this->rules);
			0 ignored issues – show Documentation Bug introduced 2016-03-10 07:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$visitor->visitArray($this->rules)` of type `*` is incompatible with the declared type `array` of property `$rules`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
98			}
99
100			/**
101			* {@inheritdoc}
102			*/
103			public function generateCSS(Context $context, OutputInterface $output)
104			{
105			$output->add('@media ', $this->currentFileInfo, $this->index);
106			$this->features->generateCSS($context, $output);
107			$this->outputRuleset($context, $output, $this->rules);
108			}
109
110			/**
111			* Compiles the node.
112			*
113			* @param Context $context The context
114			* @param array\|null $arguments Array of arguments
115			* @param bool\|null $important Important flag
116			*
117			* @return RulesetNode
118			*/
119			public function compile(Context $context, $arguments = null, $important = null)
120			{
121			if (!$context->mediaBlocks) {
122			$context->mediaBlocks = [];
123			$context->mediaPath = [];
124			}
125
126			$media = new self([], [], $this->index, $this->currentFileInfo);
127
128			if ($this->debugInfo) {
129			$this->rules[0]->debugInfo = $this->debugInfo;
130			$media->debugInfo = $this->debugInfo;
131			}
132
133			$strictMathBypass = false;
134			if (!$context->strictMath) {
135			$strictMathBypass = true;
136			$context->strictMath = true;
137			}
138
139			try {
140			$media->features = $this->features->compile($context);
141			} catch (Exception $e) {
142			// empty on purpose
143			}
144
145			if ($strictMathBypass) {
146			$context->strictMath = false;
147			}
148
149			$context->mediaPath[] = $media;
150			$context->mediaBlocks[] = $media;
151
152			$this->rules[0]->functionRegistry =
153			isset($context->frames[0]) && $context->frames[0]->functionRegistry ?
154			$context->frames[0]->functionRegistry->inherit() :
155			$context->getFunctionRegistry()->inherit();
156
157			array_unshift($context->frames, $this->rules[0]);
158			$media->rules = [$this->rules[0]->compile($context)];
159			array_shift($context->frames);
160
161			array_pop($context->mediaPath);
162
163			return count($context->mediaPath) == 0 ? $media->compileTop($context) : $media->compileNested($context);
			0 ignored issues – show Bug Best Practice introduced 2016-03-10 07:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return count($context->m...ompileNested($context);` (`ILess\Node\RulesetNode`) is incompatible with the return type of the parent method `ILess\Node\DirectiveNode::compile` of type `ILess\Node\DirectiveNode`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
164			}
165
166			/**
167			* Compiles top media.
168			*
169			* @param Context $context
170			*
171			* @return RulesetNode
172			*/
173			public function compileTop(Context $context)
174			{
175			$result = $this;
176			if (count($context->mediaBlocks) > 1) {
177			$selector = new SelectorNode([], [], null, $this->index, $this->currentFileInfo);
178			$selectors = $selector->createEmptySelectors();
179
180			$result = new RulesetNode($selectors, $context->mediaBlocks);
181			$result->multiMedia = true;
182			}
183			$context->mediaBlocks = [];
184			$context->mediaPath = [];
185
186			return $result;
			0 ignored issues – show Bug Compatibility introduced 2016-03-10 07:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $result;` of type `ILess\Node\RulesetNode\|ILess\Node\MediaNode` is incompatible with the return type documented by `ILess\Node\MediaNode::compileTop` of type `ILess\Node\RulesetNode` as it can also be of type `ILess\Node\MediaNode` which is not included in this return type. Loading history...
187			}
188
189			/**
190			* Compiles nested media.
191			*
192			* @param Context $context
193			*
194			* @return RulesetNode
195			*/
196			public function compileNested(Context $context)
197			{
198			$path = array_merge($context->mediaPath, [$this]);
199
200			// Extract the media-query conditions separated with `,` (OR).
201			foreach ($path as $key => $p) {
202			$value = $p->features instanceof ValueNode ? $p->features->value : $p->features;
203			$path[$key] = is_array($value) ? $value : [$value];
204			}
205
206			// Trace all permutations to generate the resulting media-query.
207			//
208			// (a, b and c) with nested (d, e) ->
209			//a and d
210			//a and e
211			//b and c and d
212			//b and c and e
213
214			$permuted = $this->permute($path);
215			$expressions = [];
216			foreach ($permuted as $path) {
217			for ($i = 0, $len = count($path); $i < $len; ++$i) {
218			$path[$i] = $path[$i] instanceof GenerateCSSInterface ? $path[$i] : new AnonymousNode($path[$i]);
219			}
220			for ($i = count($path) - 1; $i > 0; --$i) {
221			array_splice($path, $i, 0, [new AnonymousNode('and')]);
222			}
223			$expressions[] = new ExpressionNode($path);
224			}
225
226			$this->features = new ValueNode($expressions);
227
228			// Fake a tree-node that doesn't output anything.
229			return new RulesetNode([], []);
230			}
231
232			/**
233			* Creates permutations.
234			*
235			* @param array $array The array
236			*
237			* @return array
238			*/
239			public function permute(array $array)
240			{
241			if (!count($array)) {
242			return [];
243			} elseif (count($array) === 1) {
244			return $array[0];
245			} else {
246			$result = [];
247			$rest = $this->permute(array_slice($array, 1));
248			foreach ($rest as $r) {
249			foreach ($array[0] as $a) {
250			$result[] = array_merge(
251			is_array($a) ? $a : [$a], is_array($r) ? $r : [$r]
252			);
253			}
254			}
255			}
256
257			return $result;
258			}
259
260			/**
261			* Bubbles the selectors.
262			*
263			* @param array $selectors
264			*/
265			public function bubbleSelectors(array $selectors)
266			{
267			if (!$selectors) {
268			return;
269			}
270
271			$this->rules = [
272			new RulesetNode($selectors, [$this->rules[0]]),
273			];
274			}
275
276			/**
277			* @return bool
278			*/
279			public function isRulesetLike()
280			{
281			return true;
282			}
283			}
284

mishal / iless

Issues (191)

Security Analysis no request data

lib/ILess/Node/MediaNode.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like