minulislam / multicoin-api

src/MulticoinFactory.php

<?php

namespace Multicoin\Api;

use InvalidArgumentException;
use Multicoin\Api\Multicoin as Multicoincurrency;

class MulticoinFactory
{
    /**
     * currency configurations.
     *
     * @var array
     */
    protected $config;

Protected member variable "config" must contain a leading underscore

    /**
     * currency instances.
     *
     * @var array
     */
    protected $currencys = [];

Protected member variable "currencys" must contain a leading underscore

    /**
     * Constructs currency factory instance.
     *
     * @param  array  $config
     * @return void
     */
    public function __construct(array $config)
    {
        $this->config = $config;
    }

    /**
     * Pass methods onto the default currency.
     *
     * @param  string  $method
     * @param  array  $parameters
     * @return mixed
     */
    public function __call(string $method, array $parameters)
    {
        return $this->currency()->{$method}(...$parameters);
    }

    /**
     * Gets currency instance by name or creates if not exists.
     *
     * @param  string  $name
     * @return \Multicoin\Api\Multicoin
     */
    public function currency(string $name = 'BTC'): Multicoincurrency
    {
        if (! array_key_exists($name, $this->currencys)) {
            $config = $this->getConfig($name);

            $this->currencys[$name] = $this->make($config);
        }

        return $this->currencys[$name];
    }

    /**
     * Gets currency config by name.
     *
     * @param  string  $name
     * @return array
     */
    public function getConfig(string $name = 'BTC'): array
    {
        $flip_currency = array_flip($this->config['currency']);

Variable "flip_currency" is not in valid camel caps format

        if (! array_key_exists($name, $flip_currency)) {

Variable "flip_currency" is not in valid camel caps format

            throw new InvalidArgumentException(
                "Could not find currency configuration [$name]"

As per coding-style, please use concatenation or sprintf for the variable $name instead of interpolation.

            );
        }

        return $this->withDefaults($this->config, $name);
    }

    /**
     * Creates currency instance.
     *
     * @param  array  $config
     * @return \Multicoin\Api\Multicoin
     */
    public function make(array $config = []): Multicoincurrency
    {
        return new Multicoincurrency($config);
    }

    /**
     * Appends configuration array with default values.
     *
     * @param  array  $config
     * @return array
     */
    protected function withDefaults(array $config, string $name): array
    {
        return array_merge(['coin' => $name], $config);
    }
}