FeaturedFlags\FeaturedFlagsImpl

Complexity

Total Complexity

30

Size/Duplication

Total Lines	216
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	3
A	getInstance()	0	3	1
A	isEnabled()	0	20	4
A	getEnabledValues()	0	21	4
A	setRedis()	0	4	1
A	_getDate()	0	7	2
A	_getStmt()	0	8	2
A	_getDBFlagsData()	0	21	1
A	_executeForSelect()	0	6	1
A	_compareParams()	0	10	4
A	_checkParams()	0	13	4
A	_getKey()	0	4	1
A	_getTimeout()	0	8	2

<?php

namespace FeaturedFlags;

use PDO;
use Redis;

class FeaturedFlagsImpl implements FeaturedFlags
{
    protected $_pdo;
    protected $_redis;
    protected $_date;

    CONST TABLE_NAME = 'featured_flags';

    /**
     * FeaturedFlags constructor.
     * @param PDO $pdo
     * @param Redis|null $redis
     * @param string|null $date
     */
    public function __construct(PDO $pdo, Redis $redis = null, $date = null)
    {
        $this->_pdo = $pdo;
        if ($redis) {
            $this->_redis = $redis;
        }
        if ($date) {

The expression $date of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $this->_date = $date;
        }
    }

    /**
     * @param PDO $pdo
     * @param Redis $redis
     * @return FeaturedFlags
     */
    public static function getInstance(PDO $pdo, Redis $redis = null) {
        return new self($pdo, $redis);
    }

    /**
     * @param string $flagName
     * @param array $filterParams
     * @return boolean
     */
    public function isEnabled($flagName, $filterParams = null)
    {
        $cacheKey = "isEnabled_".$this->_getKey($flagName, $filterParams);

It seems like $filterParams defined by parameter $filterParams on line 47 can also be of type null; however, FeaturedFlags\FeaturedFlagsImpl::_getKey() does only seem to accept array, maybe add an additional type check?

        if ($this->_redis->get($cacheKey))
        {
            return $this->_redis->get($cacheKey);
        }

        $flagsData = $this->_getDBFlagsData($flagName);
        foreach($flagsData as $flag){
            if ($this->_checkParams($flag['params'], $filterParams))
            {
                $this->_redis->set($cacheKey, true, $this->_getTimeout($flag['end_date']));
                return true;
            }
        }

        $this->_redis->set($cacheKey, false);
        return false;
    }

    /**
     * @param $flagName
     * @param $filterParams
     * @return null|array
     */
    public function getEnabledValues($flagName, $filterParams = null)
    {
        $cacheKey = "getEnabledValues_".$this->_getKey($flagName, $filterParams);
        if ($this->_redis->get($cacheKey))
        {
            return $this->_redis->get($cacheKey);
        }

        $flagsData = $this->_getDBFlagsData($flagName);
        foreach($flagsData as $flag){
            if ($this->_checkParams($flag['params'], $filterParams))
            {
                $returnParams = json_decode($flag['return_params'], true);
                $this->_redis->set($cacheKey, $returnParams, $this->_getTimeout($flag['end_date']));
                return $returnParams;
            }
        }

        $this->_redis->set($cacheKey, null);
        return null;
    }

    /**
     * @param Redis $redis
     */
    public function setRedis(Redis $redis)
    {
        $this->_redis = $redis;
    }

    /**
     * @return string
     */
    private function _getDate() {
        if ($this->_date) {
            return $this->_date;
        }

        return date("Y-m-d H:i:s");
    }

    /**
     * @param string $query
     * @param array $params
     * @return \mysqli_stmt
     */
    private function _getStmt($query, $params)
    {
        $stmt = $this->_pdo->prepare($query);
        foreach ($params as $field => $value) {
            $stmt->bindValue(":$field", $value);
        }
        return $stmt;
    }

    /**
     * @param string $flagName
     * @return array
     */
    private function _getDBFlagsData($flagName)
    {
        $query = "SELECT * FROM ".self::TABLE_NAME." WHERE 
        name = :flag AND 
        status = 1 AND
        (   (start_date IS NULL AND end_date IS NULL)
                OR
            (start_date <= :now AND :now <= end_date)
                OR
            (:now <= end_date AND (start_date IS NULL OR start_date = ''))
                OR
            (start_date <= :now AND (end_date IS NULL OR end_date = ''))
        )";

        $params = array(
            'flag' => $flagName,
            'now'  =>  $this->_getDate()
        );

        return $this->_executeForSelect($query, $params);
    }

    /**
     * @param string $query
     * @param array $params
     * @return array
     */
    private function _executeForSelect($query, $params = array())
    {
        $stmt = $this->_getStmt($query, $params);
        $stmt->execute();
        return $stmt->fetchAll();
    }

    /**
     * @param array $flagParams
     * @param array $filterParams
     * @return boolean
     */
    private function _compareParams($flagParams, $filterParams)
    {
        $checkParams = true;
        foreach($filterParams as $key => $value)
        {
            $checkParams = $checkParams && isset($flagParams[$key]) && $flagParams[$key] == $value;
        }

        return $checkParams;
    }

    /**
     * @param string $flagParamsJson
     * @param array $filterParams
     * @return boolean
     */
    private function _checkParams($flagParamsJson, $filterParams = null)
    {
        if (!$filterParams) {
            return true;
        }

        $flagParamsData = json_decode($flagParamsJson, true);
        if (!is_array($flagParamsData) || count($flagParamsData) === 0) {
            return false;
        }

        return $this->_compareParams($flagParamsData, $filterParams);
    }

    /**
     * @param string $flagName
     * @param array $filterParams
     * @return boolean
     */
    private function _getKey($flagName, $filterParams)
    {
        return "FF_".$flagName.json_encode($filterParams);
    }

    /**
     * @param string $endDate
     * @return int
     */
    private function _getTimeout($endDate)
    {
        if (!$endDate) {
            return 0;
        }

        return strtotime($endDate) - strtotime($this->_getDate());
    }
}