mindtwo / laravel-multilingual

src/Http/Middleware/Localization.php

<?php

namespace mindtwo\LaravelMultilingual\Http\Middleware;

use Closure;
use Illuminate\Http\Request;
use mindtwo\LaravelMultilingual\Services\Locale;

class Localization
{
    /**
     * @var Locale
     */
    protected $locale;

    /**
     * Handle an incoming request.
     *
     * @param Request     $request
     * @param Closure     $next
     * @param string|null $guard
     *
     * @throws \Illuminate\Container\EntryNotFoundException
     *
     * @return mixed
     */
    public function handle($request, Closure $next, $guard = null)

The parameter $guard is not used and could be removed.

    {
        $this->locale = app(config('laravel-multilingual.locale_class'));

It seems like app(config('laravel-multilingual.locale_class')) can also be of type Illuminate\Contracts\Foundation\Application. However, the property $locale is declared as type mindtwo\LaravelMultilingual\Services\Locale. Maybe add an additional type check?

        // Detect and save locale
        $newLocale = $this->detectAndSetLocale($request);

        // Create locale cookie
        $localeCookie = cookie()->forever('locale', $newLocale);

        // Redirect with cookie
        foreach (config('laravel-multilingual.locale_redirectors') as $redirector) {
            $redirector = app($redirector);
            if ($redirector->match($request, $newLocale, $this->locale->current)) {

The method match() does not exist on Illuminate\Contracts\Foundation\Application.

                dd('test');

                return $redirector->redirect($newLocale)->withCookie($localeCookie);
            }
        }

        // Proceed with cookie
        return $next($request)->withCookie($localeCookie);
    }

    /**
     * @param $request
     *
     * @throws \Illuminate\Container\EntryNotFoundException
     *
     * @return string locale
     */
    public function detectAndSetLocale($request): string
    {
        $locale = $this->getRequestedLocale($request);

        app()->setLocale($locale);

The method setLocale() does not exist on Illuminate\Container\Container. Are you sure you never get this type here, but always one of the subclasses?

        return $locale;
    }

    /**
     * @param Request $request
     *
     * @throws \Illuminate\Container\EntryNotFoundException
     *
     * @return string
     */
    protected function getRequestedLocale(Request $request): string
    {
        foreach (config('laravel-multilingual.locale_detectors') as $detector) {
            $detector = app($detector);
            if ($detector->match($request, $this->locale)) {
                return $detector->get($request, $this->locale);

The call to Illuminate\Container\Container::get() has too many arguments starting with $this->locale.

The expression return $detector->get($request, $this->locale) could return the type object which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

            }
        }

        return $this->locale->default;

The property default does not exist on mindtwo\LaravelMultilingual\Services\Locale. Since you implemented __get, consider adding a @property annotation.

The expression return $this->locale->default could return the type Illuminate\Support\HigherOrderCollectionProxy which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}