mindtwo\LaravelMultilingual\Http\Middleware\LocaleDetectors\LocaleInPreferredBrowserLanguage

Complexity

Total Complexity

3

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	detectPreferredLanguage()	0	3	1
A	get()	0	3	1
A	match()	0	3	1

<?php

namespace mindtwo\LaravelMultilingual\Http\Middleware\LocaleDetectors;

use Illuminate\Http\Request;
use mindtwo\LaravelMultilingual\Services\Locale;

class LocaleInPreferredBrowserLanguage implements LocaleDetector
{
    /**
     * @param Request $request
     * @param Locale  $locale
     *
     * @return bool
     */
    public function match(Request $request, Locale $locale): bool
    {
        return ! empty($this->detectPreferredLanguage());

The call to mindtwo\LaravelMultilingual\Http\Middleware\LocaleDetectors\LocaleInPreferredBrowserLanguage::detectPreferredLanguage() has too few arguments starting with request.

    }

    /**
     * @param Request $request
     * @param Locale  $locale
     *
     * @return string
     */
    public function get(Request $request, Locale $locale): string
    {
        return $this->detectPreferredLanguage();

The expression return $this->detectPreferredLanguage() could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

The call to mindtwo\LaravelMultilingual\Http\Middleware\LocaleDetectors\LocaleInPreferredBrowserLanguage::detectPreferredLanguage() has too few arguments starting with request.

    }

    /**
     * @param Request $request
     * @param Locale  $locale
     *
     * @return string
     */
    public function detectPreferredLanguage(Request $request, Locale $locale): string
    {
        return $request->getPreferredLanguage($locale->available->toArray());

The property available does not exist on mindtwo\LaravelMultilingual\Services\Locale. Since you implemented __get, consider adding a @property annotation.

The expression return $request->getPreferredLanguage($locale->available->toArray()) could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}