mindtwo\LaravelMultilingual\Http\Middleware\LocaleDetectors\LocaleInCookie

Complexity

Total Complexity

3

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	get()	0	5	2
A	match()	0	3	1

<?php

namespace mindtwo\LaravelMultilingual\Http\Middleware\LocaleDetectors;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Crypt;
use mindtwo\LaravelMultilingual\Services\Locale;

class LocaleInCookie implements LocaleDetector
{
    /**
     * @param Request $request
     * @param Locale  $locale
     *
     * @return bool
     */
    public function match(Request $request, Locale $locale): bool
    {
        return $request->hasCookie('locale');
    }

    /**
     * @param Request $request
     * @param Locale  $locale
     *
     * @return string
     */
    public function get(Request $request, Locale $locale): string
    {
        $locale = $request->cookie('locale');

        return strlen($locale) > 5 ? Crypt::decrypt($locale) : $locale;

The expression return strlen($locale) > 5 ? Illuminate\Support\Facades\Crypt::decrypt($locale) : $locale could return the type array|null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

It seems like $locale can also be of type array; however, parameter $string of strlen() does only seem to accept string, maybe add an additional type check?

It seems like $locale can also be of type array; however, parameter $payload of Illuminate\Support\Facades\Crypt::decrypt() does only seem to accept string, maybe add an additional type check?

    }
}