HasMakeMapper::composeMakeParameters() - Code Metrics - Inspection of "Updated package to version 2" - mindtwo/laravel-dynamic-model-mutators - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b97c78...14a532 )

unknown

created 2019-01-18 15:32 UTC

HasMakeMapper::composeMakeParameters() A

↳ Parent: HasMakeMapper

Complexity

Conditions	5
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	24
rs	9.2248
c	0
b	0
f	0
cc	5
nc	5
nop	2

<?php

namespace Mindtwo\DynamicMutators\Traits;

use Mindtwo\DynamicMutators\Exceptions\InvalidParameterException;
use Mindtwo\DynamicMutators\Handler\MutationHandler;

trait HasMakeMapper
{
    /**
     * Get the registered name of the component.
     *
     * @return string
     */
    protected static function getFacadeAccessor()
    {
        return MutationHandler::class;
    }

    /**
     * Make new instance.
     *
     * @param array $arguments
     *
     * @throws InvalidParameterException
     *
     * @return object
     */
    public static function make(array $arguments = [])
    {
        $class = static::getFacadeAccessor();

        try {
            $reflection = new \ReflectionClass(static::getFacadeAccessor());
            $parameters = $reflection->getConstructor()->getParameters();
        } catch (\Throwable $error) {
            throw new \Exception('Wrong parameter', 0, $error);
        }

        return new $class(...static::composeMakeParameters($parameters, $arguments));
    }

    /**
     * Compose make() parameters.
     *
     * @param array $parameters
     * @param array $arguments
     *
     * @throws InvalidParameterException
     *
     * @return array
     */
    protected static function composeMakeParameters(array $parameters, array $arguments = []): array
    {
        foreach ($parameters as $key=>$parameter) {
            $name = $parameter->getName();

            if (array_key_exists($name, $arguments)) {
                $value = $arguments[$name];
            } elseif (array_key_exists(snake_case($name), $arguments)) {
                $value = $arguments[snake_case($name)];
            } elseif ($parameter->isDefaultValueAvailable()) {
                $value = $parameter->getDefaultValue();
            } else {
                throw new InvalidParameterException('Invalid parameters for make()!', 0, null, [
                    'name'       => $name,
                    'accessor'   => static::getFacadeAccessor(),
                    'parameters' => $parameters,
                    'arguments'  => $arguments,
                ]);
            }
            $result[$parameter->getPosition()] = $value;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }

        return $result ?? [];
    }
}


1			<?php
2
3			namespace Mindtwo\DynamicMutators\Traits;
4
5			use Mindtwo\DynamicMutators\Exceptions\InvalidParameterException;
6			use Mindtwo\DynamicMutators\Handler\MutationHandler;
7
8			trait HasMakeMapper
9			{
10			/**
11			* Get the registered name of the component.
12			*
13			* @return string
14			*/
15			protected static function getFacadeAccessor()
16			{
17			return MutationHandler::class;
18			}
19
20			/**
21			* Make new instance.
22			*
23			* @param array $arguments
24			*
25			* @throws InvalidParameterException
26			*
27			* @return object
28			*/
29			public static function make(array $arguments = [])
30			{
31			$class = static::getFacadeAccessor();
32
33			try {
34			$reflection = new \ReflectionClass(static::getFacadeAccessor());
35			$parameters = $reflection->getConstructor()->getParameters();
36			} catch (\Throwable $error) {
37			throw new \Exception('Wrong parameter', 0, $error);
38			}
39
40			return new $class(...static::composeMakeParameters($parameters, $arguments));
41			}
42
43			/**
44			* Compose make() parameters.
45			*
46			* @param array $parameters
47			* @param array $arguments
48			*
49			* @throws InvalidParameterException
50			*
51			* @return array
52			*/
53			protected static function composeMakeParameters(array $parameters, array $arguments = []): array
54			{
55			foreach ($parameters as $key=>$parameter) {
56			$name = $parameter->getName();
57
58			if (array_key_exists($name, $arguments)) {
59			$value = $arguments[$name];
60			} elseif (array_key_exists(snake_case($name), $arguments)) {
61			$value = $arguments[snake_case($name)];
62			} elseif ($parameter->isDefaultValueAvailable()) {
63			$value = $parameter->getDefaultValue();
64			} else {
65			throw new InvalidParameterException('Invalid parameters for make()!', 0, null, [
66			'name' => $name,
67			'accessor' => static::getFacadeAccessor(),
68			'parameters' => $parameters,
69			'arguments' => $arguments,
70			]);
71			}
72			$result[$parameter->getPosition()] = $value;
			0 ignored issues – show Coding Style Comprehensibility introduced 2019-01-18 15:49 UTC by Report Bug Copy Issue Report `$result` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$result = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
73			}
74
75			return $result ?? [];
76			}
77			}
78

mindtwo / laravel-dynamic-model-mutators

Push — master ( b97c78...14a532 )

HasMakeMapper::composeMakeParameters() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like