Conditions | 10 |
Paths | 10 |
Total Lines | 20 |
Code Lines | 15 |
Lines | 0 |
Ratio | 0 % |
Tests | 0 |
CRAP Score | 110 |
Changes | 1 | ||
Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
12 | public function getExceptionType($sql_state, $error_code, $error_message) |
||
13 | { |
||
14 | switch ($error_code) { |
||
15 | case '1216': |
||
16 | case '1217': |
||
17 | case '1451': |
||
18 | case '1452': |
||
19 | case '1701': |
||
20 | return ForeignKeyException::class; |
||
21 | |||
22 | case '1062': |
||
23 | case '1557': |
||
24 | case '1569': |
||
25 | case '1586': |
||
26 | return UniqueConstraintException::class; |
||
27 | |||
28 | default: |
||
29 | return SQLException::class; |
||
30 | } |
||
31 | } |
||
32 | } |
||
33 |