Issues in TextField.php (master) - Issues in master - mindplay-dk/kissform - Measure and Improve Code Quality continuously with Scrutinizer

Issues (41)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Fields/TextField.php (3 issues)

Labels

Severity

Major 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace mindplay\kissform\Fields;

use mindplay\kissform\Field;
use mindplay\kissform\InputModel;
use mindplay\kissform\InputRenderer;
use mindplay\kissform\Validators\CheckLength;
use mindplay\kissform\Validators\CheckMaxLength;
use mindplay\kissform\Validators\CheckMinLength;
use mindplay\kissform\Validators\CheckPattern;

/**
 * This class provides information about a text field, e.g. a plain
 * input type=text element.
 */
class TextField extends Field
{
    /**
     * @var int|null
     */
    public $min_length;

    /**
     * @var int|null
     */
    public $max_length;

    /**
     * @var string|null
     */
    protected $pattern;

    /**
     * @var string|null
     */
    protected $pattern_error;

    /**
     * @param string $pattern regular expression pattern (optional; no delimiters, modifiers or anchors)
     * @param string $error   error message to apply on pattern mismatch
     */
    public function setPattern($pattern, $error)
    {
        $this->pattern = $pattern;
        $this->pattern_error = $error;
    }

    /**
     * {@inheritdoc}
     */
    public function renderInput(InputRenderer $renderer, InputModel $model, array $attr)
    {
        $defaults = [];

        if ($this->max_length) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $defaults['maxlength'] = $this->max_length;
        }

        if ($this->pattern) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $defaults['pattern'] = $this->pattern;
            $defaults['data-pattern-error'] = $this->pattern_error;
        }
        
        return $renderer->inputFor($this, 'text', $attr + $defaults);
    }

    /**
     * @inheritdoc
     */
    public function createValidators()
    {
        $validators = parent::createValidators();

        if ($this->min_length !== null) {
            if ($this->max_length !== null) {
                $validators[] = new CheckLength($this->min_length, $this->max_length);
            } else {
                $validators[] = new CheckMinLength($this->min_length);
            }
        } else if ($this->max_length !== null) {
            $validators[] = new CheckMaxLength($this->max_length);
        }

        if ($this->pattern) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $validators[] = new CheckPattern("/^{$this->pattern}$/", $this->pattern_error);
        }

        return $validators;
    }
}


1		<?php
2
3		namespace mindplay\kissform\Fields;
4
5		use mindplay\kissform\Field;
6		use mindplay\kissform\InputModel;
7		use mindplay\kissform\InputRenderer;
8		use mindplay\kissform\Validators\CheckLength;
9		use mindplay\kissform\Validators\CheckMaxLength;
10		use mindplay\kissform\Validators\CheckMinLength;
11		use mindplay\kissform\Validators\CheckPattern;
12
13		/**
14		* This class provides information about a text field, e.g. a plain
15		* input type=text element.
16		*/
17		class TextField extends Field
18		{
19		/**
20		* @var int\|null
21		*/
22		public $min_length;
23
24		/**
25		* @var int\|null
26		*/
27		public $max_length;
28
29		/**
30		* @var string\|null
31		*/
32		protected $pattern;
33
34		/**
35		* @var string\|null
36		*/
37		protected $pattern_error;
38
39		/**
40		* @param string $pattern regular expression pattern (optional; no delimiters, modifiers or anchors)
41		* @param string $error error message to apply on pattern mismatch
42		*/
43	5	public function setPattern($pattern, $error)
44		{
45	5	$this->pattern = $pattern;
46	5	$this->pattern_error = $error;
47	5	}
48
49		/**
50		* {@inheritdoc}
51		*/
52	6	public function renderInput(InputRenderer $renderer, InputModel $model, array $attr)
53		{
54	6	$defaults = [];
55
56	6	if ($this->max_length) {
		0 ignored issues – show Bug Best Practice introduced 2016-04-18 10:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->max_length` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
57	1	$defaults['maxlength'] = $this->max_length;
58		}
59
60	6	if ($this->pattern) {
		0 ignored issues – show Bug Best Practice introduced 2016-04-18 10:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->pattern` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
61	1	$defaults['pattern'] = $this->pattern;
62	1	$defaults['data-pattern-error'] = $this->pattern_error;
63		}
64
65	6	return $renderer->inputFor($this, 'text', $attr + $defaults);
66		}
67
68		/**
69		* @inheritdoc
70		*/
71	8	public function createValidators()
72		{
73	8	$validators = parent::createValidators();
74
75	8	if ($this->min_length !== null) {
76	7	if ($this->max_length !== null) {
77	7	$validators[] = new CheckLength($this->min_length, $this->max_length);
78		} else {
79	7	$validators[] = new CheckMinLength($this->min_length);
80		}
81	8	} else if ($this->max_length !== null) {
82	7	$validators[] = new CheckMaxLength($this->max_length);
83		}
84
85	8	if ($this->pattern) {
		0 ignored issues – show Bug Best Practice introduced 2016-04-18 10:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->pattern` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
86	4	$validators[] = new CheckPattern("/^{$this->pattern}$/", $this->pattern_error);
87		}
88
89	8	return $validators;
90		}
91		}
92

mindplay-dk / kissform

Issues (41)

Security Analysis no request data

src/Fields/TextField.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like