CheckToken::validate() - Code Metrics - mindplay-dk/kissform - Measure and Improve Code Quality continuously with Scrutinizer

CheckToken::validate() B
last analyzed 2018-03-20 08:07 UTC

↳ Parent: CheckToken

Complexity

Conditions	5
Paths	4

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	5

Importance

Changes

Metric	Value
dl	0
loc	12
c	0
b	0
f	0
ccs	7
cts	7
cp	1
rs	8.8571
cc	5
eloc	6
nc	4
nop	3
crap	5

<?php

namespace mindplay\kissform\Validators;

use mindplay\kissform\Facets\FieldInterface;
use mindplay\kissform\Facets\TokenServiceInterface;
use mindplay\kissform\Facets\ValidatorInterface;
use mindplay\kissform\InputModel;
use mindplay\kissform\InputValidation;
use mindplay\lang;

/**
 * This validator is auto-generated by TokenField - you can validate the CSRF token by
 * simply calling Validation::check() with your TokenField instance, it will create the
 * CheckToken validator automatically. See "examples/demo.php" for a working sample.
 */
class CheckToken implements ValidatorInterface
{
    /**
     * @var TokenServiceInterface
     */
    private $service;

    /**
     * @var string|null
     */
    private $error;

    /**
     * @param TokenServiceInterface $service
     * @param string|null           $error optional custom error message
     */
    public function __construct(TokenServiceInterface $service, $error = null)
    {
        $this->service = $service;
        $this->error = $error;
    }

    public function validate(FieldInterface $field, InputModel $model, InputValidation $validation)
    {
        $input = $model->getInput($field);
        
        if ($input === null) {
            $model->setError($field, $this->error ?: lang::text("mindplay/kissform", "noToken"));
        }

        if (! $this->service->checkToken($field->getName(), $input)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $model->setError($field, $this->error ?: lang::text("mindplay/kissform", "token"));
        }
    }
}


1		<?php
2
3		namespace mindplay\kissform\Validators;
4
5		use mindplay\kissform\Facets\FieldInterface;
6		use mindplay\kissform\Facets\TokenServiceInterface;
7		use mindplay\kissform\Facets\ValidatorInterface;
8		use mindplay\kissform\InputModel;
9		use mindplay\kissform\InputValidation;
10		use mindplay\lang;
11
12		/**
13		* This validator is auto-generated by TokenField - you can validate the CSRF token by
14		* simply calling Validation::check() with your TokenField instance, it will create the
15		* CheckToken validator automatically. See "examples/demo.php" for a working sample.
16		*/
17		class CheckToken implements ValidatorInterface
18		{
19		/**
20		* @var TokenServiceInterface
21		*/
22		private $service;
23
24		/**
25		* @var string\|null
26		*/
27		private $error;
28
29		/**
30		* @param TokenServiceInterface $service
31		* @param string\|null $error optional custom error message
32		*/
33	2	public function __construct(TokenServiceInterface $service, $error = null)
34		{
35	2	$this->service = $service;
36	2	$this->error = $error;
37	2	}
38
39	2	public function validate(FieldInterface $field, InputModel $model, InputValidation $validation)
40		{
41	2	$input = $model->getInput($field);
42
43	2	if ($input === null) {
44	1	$model->setError($field, $this->error ?: lang::text("mindplay/kissform", "noToken"));
45		}
46
47	2	if (! $this->service->checkToken($field->getName(), $input)) {
		0 ignored issues – show Bug introduced 2016-04-15 12:37 UTC by Report Bug Copy Issue Report It seems like `$input` defined by `$model->getInput($field)` on line `41` can also be of type `array` or `null`; however, `mindplay\kissform\Facets...Interface::checkToken()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
48	2	$model->setError($field, $this->error ?: lang::text("mindplay/kissform", "token"));
49		}
50	2	}
51		}
52

mindplay-dk / kissform

CheckToken::validate() B last analyzed 2018-03-20 08:07 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

CheckToken::validate() B
last analyzed 2018-03-20 08:07 UTC