CheckParser::validate() - Code Metrics - mindplay-dk/kissform - Measure and Improve Code Quality continuously with Scrutinizer

CheckParser::validate() A
last analyzed 2018-03-20 08:07 UTC

↳ Parent: CheckParser

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	12
Ratio	100 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
dl	12
loc	12
c	0
b	0
f	0
ccs	7
cts	7
cp	1
rs	9.4285
cc	3
eloc	6
nc	3
nop	3
crap	3

<?php

namespace mindplay\kissform\Validators;

use mindplay\kissform\Facets\FieldInterface;
use mindplay\kissform\Facets\ParserInterface;
use mindplay\kissform\Facets\ValidatorInterface;
use mindplay\kissform\InputModel;
use mindplay\kissform\InputValidation;
use mindplay\lang;

/**
 * Validate a Field by attempting to parse the input value.
 *
 * This is useful for e.g. date or date/time input which may be parsed by {@see DateTimeStringField}.
 */
class CheckParser implements ValidatorInterface

{
    /**
     * @var ParserInterface
     */
    private $parser;

    /**
     * @var string
     */
    private $error_id;

    /**
     * @param ParserInterface $parser   the InputParser (usually a Field) which should attempt to parse the input
     * @param string          $error_id error message translation key
     */
    public function __construct(ParserInterface $parser, $error_id)
    {
        $this->parser = $parser;
        $this->error_id = $error_id;
    }

    public function validate(FieldInterface $field, InputModel $model, InputValidation $validation)
    {
        $input = $model->getInput($field);

        if ($input === null) {
            return; // no input
        }

        if ($this->parser->parseInput($input) === null) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $model->setError($field, lang::text("mindplay/kissform", $this->error_id, ["field" => $validation->getLabel($field)]));
        }
    }
}


1			<?php
2
3			namespace mindplay\kissform\Validators;
4
5			use mindplay\kissform\Facets\FieldInterface;
6			use mindplay\kissform\Facets\ParserInterface;
7			use mindplay\kissform\Facets\ValidatorInterface;
8			use mindplay\kissform\InputModel;
9			use mindplay\kissform\InputValidation;
10			use mindplay\lang;
11
12			/**
13			* Validate a Field by attempting to parse the input value.
14			*
15			* This is useful for e.g. date or date/time input which may be parsed by {@see DateTimeStringField}.
16			*/
17		View Code Duplication	class CheckParser implements ValidatorInterface
			0 ignored issues – show Duplication introduced 2016-04-15 12:37 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18			{
19			/**
20			* @var ParserInterface
21			*/
22			private $parser;
23
24			/**
25			* @var string
26			*/
27			private $error_id;
28
29			/**
30			* @param ParserInterface $parser the InputParser (usually a Field) which should attempt to parse the input
31			* @param string $error_id error message translation key
32			*/
33	3		public function __construct(ParserInterface $parser, $error_id)
34			{
35	3		$this->parser = $parser;
36	3		$this->error_id = $error_id;
37	3		}
38
39	1		public function validate(FieldInterface $field, InputModel $model, InputValidation $validation)
40			{
41	1		$input = $model->getInput($field);
42
43	1		if ($input === null) {
44	1		return; // no input
45			}
46
47	1		if ($this->parser->parseInput($input) === null) {
			0 ignored issues – show Bug introduced 2016-04-15 12:37 UTC by Report Bug Copy Issue Report It seems like `$input` defined by `$model->getInput($field)` on line `41` can also be of type `array`; however, `mindplay\kissform\Facets...Interface::parseInput()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
48	1		$model->setError($field, lang::text("mindplay/kissform", $this->error_id, ["field" => $validation->getLabel($field)]));
49			}
50	1		}
51			}
52

mindplay-dk / kissform

CheckParser::validate() A last analyzed 2018-03-20 08:07 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

CheckParser::validate() A
last analyzed 2018-03-20 08:07 UTC