milwad-dev / laravel-validate

src/Rules/ValidImei.php

<?php

namespace Milwad\LaravelValidate\Rules;

use Illuminate\Contracts\Validation\Rule;

class ValidImei implements Rule
{
    /**
     * Check IMEI is valid.
     */
    public function passes($attribute, $value): bool
    {
        $imei = $value;

        if (strlen($imei) != 15 || ! ctype_digit($imei)) {
            return false;
        }

        $digits = str_split($imei); // Get digits
        $imei_last = array_pop($digits); // Remove last digit, and store it

It seems like $digits can also be of type true; however, parameter $array of array_pop() does only seem to accept array, maybe add an additional type check?

        $log = [];

        foreach ($digits as $key => $n) {
            if ($key & 1) {
                $double = str_split($n * 2); // Get double digits
                $n = array_sum($double); // Sum double digits

It seems like $double can also be of type true; however, parameter $array of array_sum() does only seem to accept array, maybe add an additional type check?

            }

            $log[] = $n; // Append log
        }
        $sum = array_sum($log) * 9; // Sum log & multiply by 9

        return substr($sum, -1) === $imei_last;
    }

    /**
     * Get the validation error message.
     */
    public function message(): string
    {
        return __('validate.imei');
    }
}