Milwad\LaravelValidate\Rules\ValidImei

Complexity

Total Complexity

7

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	validate()	0	5	2
A	isImeiValid()	0	23	5

<?php

namespace Milwad\LaravelValidate\Rules;

use Closure;
use Illuminate\Contracts\Validation\ValidationRule;

The type Illuminate\Contracts\Validation\ValidationRule was not found. Maybe you did not declare it correctly or list all dependencies?

class ValidImei implements ValidationRule
{
    /**
     * Check IMEI is valid.
     *
     * @param string $attribute
     * @param mixed $value
     * @param Closure $fail
     * @return void
     */
    public function validate(string $attribute, mixed $value, Closure $fail): void
    {
        if (! $this->isImeiValid($value)) {

            $fail('validate.imei')->translate();
        }
    }

    /**
     * Check if IMEI is valid
     *
     * @param mixed $value
     * @return bool
     */
    private function isImeiValid(mixed $value): bool
    {
        $imei = $value;

        if (strlen($imei) != 15 || ! ctype_digit($imei)) {
            return false;
        }

        $digits = str_split($imei); // Get digits
        $imei_last = array_pop($digits); // Remove last digit, and store it

It seems like $digits can also be of type true; however, parameter $array of array_pop() does only seem to accept array, maybe add an additional type check?

        $log = [];

        foreach ($digits as $key => $n) {
            if ($key & 1) {
                $double = str_split($n * 2); // Get double digits
                $n = array_sum($double); // Sum double digits

It seems like $double can also be of type true; however, parameter $array of array_sum() does only seem to accept array, maybe add an additional type check?

            }

            $log[] = $n; // Append log
        }
        $sum = array_sum($log) * 9; // Sum log & multiply by 9

        return substr($sum, -1) === $imei_last;
    }
}