ValidCreditCard::isCreditCardValid() - Code Metrics - Inspection of "[1.x] Migrate validation rule classes from Rule to..." - milwad-dev/laravel-validate - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — 1.x (#84)

unknown

created 2024-04-17 08:50 UTC

ValidCreditCard::isCreditCardValid() A

↳ Parent: ValidCreditCard

Complexity

Conditions	4
Paths	4

Size

Total Lines	20
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	12
nc	4
nop	1
dl	0
loc	20
rs	9.8666
c	1
b	0
f	0

<?php

namespace Milwad\LaravelValidate\Rules;

use Closure;
use Illuminate\Contracts\Validation\ValidationRule;
filter:
    dependency_paths: ["lib/*"]

class ValidCreditCard implements ValidationRule
{
    /**
     * Check if the credit card number is valid using the Luhn algorithm.
     *
     * @param string $attribute
     * @param mixed $value
     * @param Closure $fail
     * @return void
     */
    public function validate(string $attribute, mixed $value, Closure $fail): void
    {
        if (! $this->isCreditCardValid($value)) {

            $fail('validate.credit-card')->translate();
        }
    }

    /**
     * Check if credit card number is valid using th Luhn algorithm
     *
     * @param mixed $value
     * @return bool
     */
    private function isCreditCardValid(mixed $value): bool
    {
        $value = preg_replace('/\D/', '', $value);

        $numLength = strlen($value);
        $sum = 0;
        $reverse = strrev($value);

        for ($i = 0; $i < $numLength; $i++) {
            $currentNum = intval($reverse[$i]);
            if ($i % 2 == 1) {
                $currentNum *= 2;
                if ($currentNum > 9) {
                    $currentNum -= 9;
                }
            }
            $sum += $currentNum;
        }

        return $sum % 10 == 0;
    }
}


1			<?php
2
3			namespace Milwad\LaravelValidate\Rules;
4
5			use Closure;
6			use Illuminate\Contracts\Validation\ValidationRule;
			0 ignored issues – show Bug introduced 2023-06-04 23:19 UTC by Report Bug Copy Issue Report The type `Illuminate\Contracts\Validation\ValidationRule` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
7
8			class ValidCreditCard implements ValidationRule
9			{
10			/**
11			* Check if the credit card number is valid using the Luhn algorithm.
12			*
13			* @param string $attribute
14			* @param mixed $value
15			* @param Closure $fail
16			* @return void
17			*/
18			public function validate(string $attribute, mixed $value, Closure $fail): void
19			{
20			if (! $this->isCreditCardValid($value)) {
21
22			$fail('validate.credit-card')->translate();
23			}
24			}
25
26			/**
27			* Check if credit card number is valid using th Luhn algorithm
28			*
29			* @param mixed $value
30			* @return bool
31			*/
32			private function isCreditCardValid(mixed $value): bool
33			{
34			$value = preg_replace('/\D/', '', $value);
35
36			$numLength = strlen($value);
37			$sum = 0;
38			$reverse = strrev($value);
39
40			for ($i = 0; $i < $numLength; $i++) {
41			$currentNum = intval($reverse[$i]);
42			if ($i % 2 == 1) {
43			$currentNum *= 2;
44			if ($currentNum > 9) {
45			$currentNum -= 9;
46			}
47			}
48			$sum += $currentNum;
49			}
50
51			return $sum % 10 == 0;
52			}
53			}
54

milwad-dev / laravel-validate

Pull Request — 1.x (#84)

ValidCreditCard::isCreditCardValid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like