milkmeowo /
laravel-queue-aliyun-mns
| Total Complexity | 55 |
| Total Lines | 294 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like QueueAttributes often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use QueueAttributes, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 11 | class QueueAttributes |
||
| 12 | { |
||
| 13 | private $delaySeconds; |
||
| 14 | private $maximumMessageSize; |
||
| 15 | private $messageRetentionPeriod; |
||
| 16 | private $visibilityTimeout; |
||
| 17 | private $pollingWaitSeconds; |
||
| 18 | private $LoggingEnabled; |
||
| 19 | |||
| 20 | # the following attributes cannot be changed |
||
| 21 | private $queueName; |
||
| 22 | private $createTime; |
||
| 23 | private $lastModifyTime; |
||
| 24 | private $activeMessages; |
||
| 25 | private $inactiveMessages; |
||
| 26 | private $delayMessages; |
||
| 27 | |||
| 28 | public function __construct( |
||
| 29 | $delaySeconds = NULL, |
||
| 30 | $maximumMessageSize = NULL, |
||
| 31 | $messageRetentionPeriod = NULL, |
||
| 32 | $visibilityTimeout = NULL, |
||
| 33 | $pollingWaitSeconds = NULL, |
||
| 34 | $queueName = NULL, |
||
| 35 | $createTime = NULL, |
||
| 36 | $lastModifyTime = NULL, |
||
| 37 | $activeMessages = NULL, |
||
| 38 | $inactiveMessages = NULL, |
||
| 39 | $delayMessages = NULL, |
||
| 40 | $LoggingEnabled = NULL) |
||
| 41 | { |
||
| 42 | $this->delaySeconds = $delaySeconds; |
||
| 43 | $this->maximumMessageSize = $maximumMessageSize; |
||
| 44 | $this->messageRetentionPeriod = $messageRetentionPeriod; |
||
| 45 | $this->visibilityTimeout = $visibilityTimeout; |
||
| 46 | $this->pollingWaitSeconds = $pollingWaitSeconds; |
||
| 47 | $this->loggingEnabled = $LoggingEnabled; |
||
| 48 | |||
| 49 | $this->queueName = $queueName; |
||
| 50 | $this->createTime = $createTime; |
||
| 51 | $this->lastModifyTime = $lastModifyTime; |
||
| 52 | $this->activeMessages = $activeMessages; |
||
| 53 | $this->inactiveMessages = $inactiveMessages; |
||
| 54 | $this->delayMessages = $delayMessages; |
||
| 55 | } |
||
| 56 | |||
| 57 | public function setDelaySeconds($delaySeconds) |
||
| 58 | { |
||
| 59 | $this->delaySeconds = $delaySeconds; |
||
| 60 | } |
||
| 61 | |||
| 62 | public function getDelaySeconds() |
||
| 63 | { |
||
| 64 | return $this->delaySeconds; |
||
| 65 | } |
||
| 66 | |||
| 67 | public function setLoggingEnabled($loggingEnabled) |
||
| 68 | { |
||
| 69 | $this->loggingEnabled = $loggingEnabled; |
||
| 70 | } |
||
| 71 | |||
| 72 | public function getLoggingEnabled() |
||
| 73 | { |
||
| 74 | return $this->loggingEnabled; |
||
| 75 | } |
||
| 76 | |||
| 77 | public function setMaximumMessageSize($maximumMessageSize) |
||
| 78 | { |
||
| 79 | $this->maximumMessageSize = $maximumMessageSize; |
||
| 80 | } |
||
| 81 | |||
| 82 | public function getMaximumMessageSize() |
||
| 83 | { |
||
| 84 | return $this->maximumMessageSize; |
||
| 85 | } |
||
| 86 | |||
| 87 | public function setMessageRetentionPeriod($messageRetentionPeriod) |
||
| 88 | { |
||
| 89 | $this->messageRetentionPeriod = $messageRetentionPeriod; |
||
| 90 | } |
||
| 91 | |||
| 92 | public function getMessageRetentionPeriod() |
||
| 93 | { |
||
| 94 | return $this->messageRetentionPeriod; |
||
| 95 | } |
||
| 96 | |||
| 97 | public function setVisibilityTimeout($visibilityTimeout) |
||
| 98 | { |
||
| 99 | $this->visibilityTimeout = $visibilityTimeout; |
||
| 100 | } |
||
| 101 | |||
| 102 | public function getVisibilityTimeout() |
||
| 103 | { |
||
| 104 | return $this->visibilityTimeout; |
||
| 105 | } |
||
| 106 | |||
| 107 | public function setPollingWaitSeconds($pollingWaitSeconds) |
||
| 108 | { |
||
| 109 | $this->pollingWaitSeconds = $pollingWaitSeconds; |
||
| 110 | } |
||
| 111 | |||
| 112 | public function getPollingWaitSeconds() |
||
| 113 | { |
||
| 114 | return $this->pollingWaitSeconds; |
||
| 115 | } |
||
| 116 | |||
| 117 | public function getQueueName() |
||
| 118 | { |
||
| 119 | return $this->queueName; |
||
| 120 | } |
||
| 121 | |||
| 122 | public function getCreateTime() |
||
| 123 | { |
||
| 124 | return $this->createTime; |
||
| 125 | } |
||
| 126 | |||
| 127 | public function getLastModifyTime() |
||
| 128 | { |
||
| 129 | return $this->lastModifyTime; |
||
| 130 | } |
||
| 131 | |||
| 132 | public function getActiveMessages() |
||
| 133 | { |
||
| 134 | return $this->activeMessages; |
||
| 135 | } |
||
| 136 | |||
| 137 | public function getInactiveMessages() |
||
| 138 | { |
||
| 139 | return $this->inactiveMessages; |
||
| 140 | } |
||
| 141 | |||
| 142 | public function getDelayMessages() |
||
| 143 | { |
||
| 144 | return $this->delayMessages; |
||
| 145 | } |
||
| 146 | |||
| 147 | public function writeXML(\XMLWriter $xmlWriter) |
||
| 148 | { |
||
| 149 | if ($this->delaySeconds != NULL) |
||
| 150 | { |
||
| 151 | $xmlWriter->writeElement(Constants::DELAY_SECONDS, $this->delaySeconds); |
||
| 152 | } |
||
| 153 | if ($this->maximumMessageSize != NULL) |
||
| 154 | { |
||
| 155 | $xmlWriter->writeElement(Constants::MAXIMUM_MESSAGE_SIZE, $this->maximumMessageSize); |
||
| 156 | } |
||
| 157 | if ($this->messageRetentionPeriod != NULL) |
||
| 158 | { |
||
| 159 | $xmlWriter->writeElement(Constants::MESSAGE_RETENTION_PERIOD, $this->messageRetentionPeriod); |
||
| 160 | } |
||
| 161 | if ($this->visibilityTimeout != NULL) |
||
| 162 | { |
||
| 163 | $xmlWriter->writeElement(Constants::VISIBILITY_TIMEOUT, $this->visibilityTimeout); |
||
| 164 | } |
||
| 165 | if ($this->pollingWaitSeconds != NULL) |
||
| 166 | { |
||
| 167 | $xmlWriter->writeElement(Constants::POLLING_WAIT_SECONDS, $this->pollingWaitSeconds); |
||
| 168 | } |
||
| 169 | if ($this->loggingEnabled !== NULL) |
||
| 170 | { |
||
| 171 | $xmlWriter->writeElement(Constants::LOGGING_ENABLED, $this->loggingEnabled ? "True" : "False"); |
||
| 172 | } |
||
| 173 | } |
||
| 174 | |||
| 175 | static public function fromXML(\XMLReader $xmlReader) |
||
| 176 | { |
||
| 177 | $delaySeconds = NULL; |
||
| 178 | $maximumMessageSize = NULL; |
||
| 179 | $messageRetentionPeriod = NULL; |
||
| 180 | $visibilityTimeout = NULL; |
||
| 181 | $pollingWaitSeconds = NULL; |
||
| 182 | $queueName = NULL; |
||
| 183 | $createTime = NULL; |
||
| 184 | $lastModifyTime = NULL; |
||
| 185 | $activeMessages = NULL; |
||
| 186 | $inactiveMessages = NULL; |
||
| 187 | $delayMessages = NULL; |
||
| 188 | $loggingEnabled = NULL; |
||
| 189 | |||
| 190 | while ($xmlReader->read()) |
||
| 191 | { |
||
| 192 | if ($xmlReader->nodeType == \XMLReader::ELEMENT) |
||
| 193 | { |
||
| 194 | switch ($xmlReader->name) { |
||
| 195 | case 'DelaySeconds': |
||
| 196 | $xmlReader->read(); |
||
| 197 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 198 | { |
||
| 199 | $delaySeconds = $xmlReader->value; |
||
| 200 | } |
||
| 201 | break; |
||
| 202 | case 'MaximumMessageSize': |
||
| 203 | $xmlReader->read(); |
||
| 204 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 205 | { |
||
| 206 | $maximumMessageSize = $xmlReader->value; |
||
| 207 | } |
||
| 208 | break; |
||
| 209 | case 'MessageRetentionPeriod': |
||
| 210 | $xmlReader->read(); |
||
| 211 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 212 | { |
||
| 213 | $messageRetentionPeriod = $xmlReader->value; |
||
| 214 | } |
||
| 215 | break; |
||
| 216 | case 'VisibilityTimeout': |
||
| 217 | $xmlReader->read(); |
||
| 218 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 219 | { |
||
| 220 | $visibilityTimeout = $xmlReader->value; |
||
| 221 | } |
||
| 222 | break; |
||
| 223 | case 'PollingWaitSeconds': |
||
| 224 | $xmlReader->read(); |
||
| 225 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 226 | { |
||
| 227 | $pollingWaitSeconds = $xmlReader->value; |
||
| 228 | } |
||
| 229 | break; |
||
| 230 | case 'QueueName': |
||
| 231 | $xmlReader->read(); |
||
| 232 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 233 | { |
||
| 234 | $queueName = $xmlReader->value; |
||
| 235 | } |
||
| 236 | break; |
||
| 237 | case 'CreateTime': |
||
| 238 | $xmlReader->read(); |
||
| 239 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 240 | { |
||
| 241 | $createTime = $xmlReader->value; |
||
| 242 | } |
||
| 243 | break; |
||
| 244 | case 'LastModifyTime': |
||
| 245 | $xmlReader->read(); |
||
| 246 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 247 | { |
||
| 248 | $lastModifyTime = $xmlReader->value; |
||
| 249 | } |
||
| 250 | break; |
||
| 251 | case 'ActiveMessages': |
||
| 252 | $xmlReader->read(); |
||
| 253 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 254 | { |
||
| 255 | $activeMessages = $xmlReader->value; |
||
| 256 | } |
||
| 257 | break; |
||
| 258 | case 'InactiveMessages': |
||
| 259 | $xmlReader->read(); |
||
| 260 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 261 | { |
||
| 262 | $inactiveMessages = $xmlReader->value; |
||
| 263 | } |
||
| 264 | break; |
||
| 265 | case 'DelayMessages': |
||
| 266 | $xmlReader->read(); |
||
| 267 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 268 | { |
||
| 269 | $delayMessages = $xmlReader->value; |
||
| 270 | } |
||
| 271 | break; |
||
| 272 | case 'LoggingEnabled': |
||
| 273 | $xmlReader->read(); |
||
| 274 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 275 | { |
||
| 276 | $loggingEnabled = $xmlReader->value; |
||
| 277 | if ($loggingEnabled == "True") |
||
| 278 | { |
||
| 279 | $loggingEnabled = True; |
||
| 280 | } |
||
| 281 | else |
||
| 282 | { |
||
| 283 | $loggingEnabled = False; |
||
| 284 | } |
||
| 285 | } |
||
| 286 | break; |
||
| 287 | } |
||
| 288 | } |
||
| 289 | } |
||
| 290 | |||
| 291 | $attributes = new QueueAttributes( |
||
| 292 | $delaySeconds, |
||
| 293 | $maximumMessageSize, |
||
| 294 | $messageRetentionPeriod, |
||
| 295 | $visibilityTimeout, |
||
| 296 | $pollingWaitSeconds, |
||
| 297 | $queueName, |
||
| 298 | $createTime, |
||
| 299 | $lastModifyTime, |
||
| 300 | $activeMessages, |
||
| 301 | $inactiveMessages, |
||
| 302 | $delayMessages, |
||
| 303 | $loggingEnabled); |
||
| 304 | return $attributes; |
||
| 305 | } |
||
| 309 |
