miladrahimi / phprouter

src/Publisher/HttpPublisher.php

<?php

namespace MiladRahimi\PhpRouter\Publisher;

use Psr\Http\Message\ResponseInterface;

/**
 * It publishes responses provided by controllers and middleware as HTTP responses
 */
class HttpPublisher implements Publisher
{
    /**
     * @inheritdoc
     */
    public function publish($response): void
    {
        $output = fopen('php://output', 'a');

        if ($response instanceof ResponseInterface) {
            http_response_code($response->getStatusCode());

            foreach ($response->getHeaders() as $name => $values) {
                @header($name . ': ' . $response->getHeaderLine($name));

It seems like you do not handle an error condition for header(). This can introduce security issues, and is generally not recommended.

Are you sure the usage of header($name . ': ' . $response->getHeaderLine($name)) is correct as it seems to always return null.

            }

            fwrite($output, $response->getBody());
        } elseif (is_scalar($response)) {
            fwrite($output, $response);
        } elseif ($response === null) {
            fwrite($output, '');
        } else {
            fwrite($output, json_encode($response));
        }

        fclose($output);
    }
}