MiladRahimi\PhpRouter\View\PhpView

Complexity

Total Complexity

3

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	make()	0	16	2

<?php

namespace MiladRahimi\PhpRouter\View;

/**
 * It makes views from PHP and HTML/PHP files
 */
class PhpView implements View
{
    /**
     * The root directory of view files
     */
    private string $directory;

    public function __construct(string $directory)
    {
        $this->directory = $directory;
    }

    /**
     * @inheritDoc
     */
    public function make(string $name, array $data = [], int $httpStatus = 200, array $httpHeaders = [])
    {
        $file = str_replace('.', DIRECTORY_SEPARATOR, $name) . '.phtml';
        $path = join('/', [$this->directory, $file]);

        http_response_code($httpStatus);

        foreach ($httpHeaders as $name => $values) {
            @header($name . ': ' . $values);

It seems like you do not handle an error condition for header(). This can introduce security issues, and is generally not recommended.

Are you sure the usage of header($name . ': ' . $values) is correct as it seems to always return null.

        }

        extract($data);

        require $path;

        return null;
    }
}