| Total Complexity | 57 |
| Total Lines | 351 |
| Duplicated Lines | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like CallQueuesController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CallQueuesController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | class CallQueuesController extends BaseController |
||
| 16 | { |
||
| 17 | |||
| 18 | /** |
||
| 19 | * Получение списка очередей вызовово |
||
| 20 | */ |
||
| 21 | public function indexAction(): void |
||
| 22 | { |
||
| 23 | $queues = CallQueues::find(); |
||
| 24 | $this->view->queues = $queues; |
||
| 25 | } |
||
| 26 | |||
| 27 | |||
| 28 | /** |
||
| 29 | * Карточка редактирования очереди |
||
| 30 | * |
||
| 31 | * @param string $uniqid - идентификатор редактируемой очереди |
||
| 32 | */ |
||
| 33 | public function modifyAction(string $uniqid = null): void |
||
| 104 | } |
||
| 105 | |||
| 106 | |||
| 107 | /** |
||
| 108 | * Сохранение очереди через AJAX запрос из формы |
||
| 109 | */ |
||
| 110 | public function saveAction(): void |
||
| 163 | } |
||
| 164 | } |
||
| 165 | |||
| 166 | /** |
||
| 167 | * Обновление параметров внутреннего номера |
||
| 168 | * |
||
| 169 | * @param \MikoPBX\Common\Models\Extensions $extension |
||
| 170 | * @param array $data массив полей из POST запроса |
||
| 171 | * |
||
| 172 | * @return bool update result |
||
| 173 | */ |
||
| 174 | private function updateExtension(Extensions $extension, array $data): bool |
||
| 186 | } |
||
| 187 | |||
| 188 | /** |
||
| 189 | * Обновление параметров очереди |
||
| 190 | * |
||
| 191 | * @param \MikoPBX\Common\Models\CallQueues $queue |
||
| 192 | * @param array $data массив полей из POST запроса |
||
| 193 | * |
||
| 194 | * @return bool update result |
||
| 195 | */ |
||
| 196 | private function updateQueue(CallQueues $queue, array $data): bool |
||
| 197 | { |
||
| 198 | foreach ($queue as $name => $value) { |
||
| 199 | switch ($name) { |
||
| 200 | case "extension": |
||
| 201 | case "name": |
||
| 202 | $queue->$name = $data[$name]; |
||
| 203 | break; |
||
| 204 | case "recive_calls_while_on_a_call": |
||
| 205 | case "announce_position": |
||
| 206 | case "announce_hold_time": |
||
| 207 | if (array_key_exists($name, $data)) { |
||
| 208 | $queue->$name = ($data[$name] == 'on') ? "1" : "0"; |
||
| 209 | } else { |
||
| 210 | $queue->$name = "0"; |
||
| 211 | } |
||
| 212 | break; |
||
| 213 | |||
| 214 | case "periodic_announce_sound_id": |
||
| 215 | case "redirect_to_extension_if_repeat_exceeded": |
||
| 216 | case "redirect_to_extension_if_empty": |
||
| 217 | if ( ! array_key_exists($name, $data) || empty($data[$name])) { |
||
| 218 | $queue->$name = null; |
||
| 219 | continue 2; |
||
| 220 | } |
||
| 221 | $queue->$name = $data[$name]; |
||
| 222 | |||
| 223 | break; |
||
| 224 | case "timeout_to_redirect_to_extension": |
||
| 225 | case "number_unanswered_calls_to_redirect": |
||
| 226 | if ( ! array_key_exists($name, $data)) { |
||
| 227 | continue 2; |
||
| 228 | } |
||
| 229 | if (empty($data[$name])) { |
||
| 230 | $queue->$name = null; |
||
| 231 | } else { |
||
| 232 | $queue->$name = $data[$name]; |
||
| 233 | } |
||
| 234 | break; |
||
| 235 | case "timeout_extension": |
||
| 236 | if ( ! array_key_exists($name, $data) |
||
| 237 | || empty($data[$name]) |
||
| 238 | || (array_key_exists('timeout_to_redirect_to_extension', $data) |
||
| 239 | && intval($data['timeout_to_redirect_to_extension']) === 0)) { |
||
| 240 | $queue->$name = null; |
||
| 241 | continue 2; |
||
| 242 | } |
||
| 243 | $queue->$name = $data[$name]; |
||
| 244 | |||
| 245 | break; |
||
| 246 | case "redirect_to_extension_if_unanswered": |
||
| 247 | if ( ! array_key_exists($name, $data) |
||
| 248 | || empty($data[$name]) |
||
| 249 | || (array_key_exists('number_unanswered_calls_to_redirect', $data) |
||
| 250 | && intval($data['number_unanswered_calls_to_redirect']) === 0)) { |
||
| 251 | $queue->$name = null; |
||
| 252 | continue 2; |
||
| 253 | } |
||
| 254 | $queue->$name = $data[$name]; |
||
| 255 | |||
| 256 | break; |
||
| 257 | default: |
||
| 258 | if ( ! array_key_exists($name, $data)) { |
||
| 259 | continue 2; |
||
| 260 | } |
||
| 261 | $queue->$name = $data[$name]; |
||
| 262 | } |
||
| 263 | } |
||
| 264 | |||
| 265 | if ($queue->save() === false) { |
||
| 266 | $errors = $queue->getMessages(); |
||
| 267 | $this->flash->error(implode('<br>', $errors)); |
||
| 268 | |||
| 269 | return false; |
||
| 270 | } |
||
| 271 | |||
| 272 | return true; |
||
| 273 | } |
||
| 274 | |||
| 275 | /** |
||
| 276 | * Обновление списка участников очереди |
||
| 277 | * |
||
| 278 | * @param array $data массив полей из POST запроса |
||
| 279 | * |
||
| 280 | * @return bool update result |
||
| 281 | */ |
||
| 282 | private function updateQueueMembers(array $data): bool |
||
| 341 | } |
||
| 342 | |||
| 343 | /** |
||
| 344 | * Удаление очереди по ее ID |
||
| 345 | * |
||
| 346 | * @param string $uniqid |
||
| 347 | */ |
||
| 348 | public function deleteAction(string $uniqid = null) |
||
| 366 | } |
||
| 367 | } |