mikopbx /
Core
| Conditions | 30 |
| Paths | 28 |
| Total Lines | 133 |
| Code Lines | 122 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 31 | public static function systemCallBack(array $request): PBXApiResult |
||
| 32 | { |
||
| 33 | $action = $request['action']; |
||
| 34 | $data = $request['data']; |
||
| 35 | $res = new PBXApiResult(); |
||
| 36 | $res->processor = __METHOD__; |
||
| 37 | switch ($action) { |
||
| 38 | case 'reboot': |
||
| 39 | System::rebootSync(); |
||
| 40 | $res->success = true; |
||
| 41 | break; |
||
| 42 | case 'shutdown': |
||
| 43 | System::shutdown(); |
||
| 44 | $res->success = true; |
||
| 45 | break; |
||
| 46 | case 'mergeUploadedFile': |
||
| 47 | $phpPath = Util::which('php'); |
||
| 48 | $workerDownloaderPath = Util::getFilePathByClassName(WorkerMergeUploadedFile::class); |
||
| 49 | Util::mwExecBg("{$phpPath} -f {$workerDownloaderPath} '{$data['settings_file']}'"); |
||
| 50 | $res->success = true; |
||
| 51 | break; |
||
| 52 | case 'setDate': |
||
| 53 | $res->success = System::setDate($data['date']); |
||
| 54 | break; |
||
| 55 | case 'updateMailSettings': |
||
| 56 | // TODO |
||
| 57 | $res->success = true; |
||
| 58 | break; |
||
| 59 | case 'sendMail': |
||
| 60 | if (isset($data['email']) && isset($data['subject']) && isset($data['body'])) { |
||
| 61 | if (isset($data['encode']) && $data['encode'] === 'base64') { |
||
| 62 | $data['subject'] = base64_decode($data['subject']); |
||
| 63 | $data['body'] = base64_decode($data['body']); |
||
| 64 | } |
||
| 65 | $result = Notifications::sendMail($data['email'], $data['subject'], $data['body']); |
||
| 66 | if ($result === true) { |
||
| 67 | $res->success = true; |
||
| 68 | } else { |
||
| 69 | $res->success = false; |
||
| 70 | $res->messages[] = $result; |
||
| 71 | } |
||
| 72 | } else { |
||
| 73 | $res->success = false; |
||
| 74 | $res->messages[] = 'Not all query parameters are set'; |
||
| 75 | } |
||
| 76 | break; |
||
| 77 | case 'fileReadContent': |
||
| 78 | $res = FilesManagementProcessor::fileReadContent($data['filename'], $data['needOriginal']); |
||
| 79 | break; |
||
| 80 | case 'reloadMsmtp': |
||
| 81 | $notifications = new Notifications(); |
||
| 82 | $notifications->configure(); |
||
| 83 | $voiceMailConfig = new VoiceMailConf(); |
||
| 84 | $voiceMailConfig->generateConfig(); |
||
| 85 | $asteriskPath = Util::which('asterisk'); |
||
| 86 | Util::mwExec("{$asteriskPath} -rx 'voicemail reload'"); |
||
| 87 | $res->success = true; |
||
| 88 | break; |
||
| 89 | case 'unBanIp': |
||
| 90 | $res = FirewallManagementProcessor::fail2banUnbanAll($data['ip']); |
||
| 91 | break; |
||
| 92 | case 'getBanIp': |
||
| 93 | $res = FirewallManagementProcessor::getBanIp(); |
||
| 94 | break; |
||
| 95 | case 'downloadNewFirmware': |
||
| 96 | $res = FilesManagementProcessor::downloadNewFirmware($request['data']); |
||
| 97 | break; |
||
| 98 | case 'firmwareDownloadStatus': |
||
| 99 | $res = FilesManagementProcessor::firmwareDownloadStatus(); |
||
| 100 | break; |
||
| 101 | case 'upgrade': |
||
| 102 | $res = SystemManagementProcessor::upgradeFromImg($data['temp_filename']); |
||
| 103 | break; |
||
| 104 | case 'removeAudioFile': |
||
| 105 | $res = FilesManagementProcessor::removeAudioFile($data['filename']); |
||
| 106 | break; |
||
| 107 | case 'convertAudioFile': |
||
| 108 | $mvPath = Util::which('mv'); |
||
| 109 | Util::mwExec("{$mvPath} {$data['temp_filename']} {$data['filename']}"); |
||
| 110 | $res = FilesManagementProcessor::convertAudioFile($data['filename']); |
||
| 111 | break; |
||
| 112 | case 'downloadNewModule': |
||
| 113 | $module = $request['data']['uniqid']; |
||
| 114 | $url = $request['data']['url']; |
||
| 115 | $md5 = $request['data']['md5']; |
||
| 116 | $res = FilesManagementProcessor::moduleStartDownload($module, $url, $md5); |
||
| 117 | break; |
||
| 118 | case 'moduleDownloadStatus': |
||
| 119 | $module = $request['data']['uniqid']; |
||
| 120 | $res = FilesManagementProcessor::moduleDownloadStatus($module); |
||
| 121 | break; |
||
| 122 | case 'installNewModule': |
||
| 123 | $filePath = $request['data']['filePath']; |
||
| 124 | $res = FilesManagementProcessor::installModuleFromFile($filePath); |
||
| 125 | break; |
||
| 126 | case 'enableModule': |
||
| 127 | $moduleUniqueID = $request['data']['uniqid']; |
||
| 128 | $moduleStateProcessor = new PbxExtensionState($moduleUniqueID); |
||
| 129 | if ($moduleStateProcessor->enableModule() === false) { |
||
| 130 | $res->success = false; |
||
| 131 | $res->messages = $moduleStateProcessor->getMessages(); |
||
| 132 | } else { |
||
| 133 | PBXConfModulesProvider::recreateModulesProvider(); |
||
| 134 | $res->data['needReloadModules'] = true; |
||
| 135 | $res->success = true; |
||
| 136 | } |
||
| 137 | break; |
||
| 138 | case 'disableModule': |
||
| 139 | $moduleUniqueID = $request['data']['uniqid']; |
||
| 140 | $moduleStateProcessor = new PbxExtensionState($moduleUniqueID); |
||
| 141 | if ($moduleStateProcessor->disableModule() === false) { |
||
| 142 | $res->success = false; |
||
| 143 | $res->messages = $moduleStateProcessor->getMessages(); |
||
| 144 | } else { |
||
| 145 | PBXConfModulesProvider::recreateModulesProvider(); |
||
| 146 | $res->data['needReloadModules'] = true; |
||
| 147 | $res->success = true; |
||
| 148 | } |
||
| 149 | break; |
||
| 150 | case 'uninstallModule': |
||
| 151 | $moduleUniqueID = $request['data']['uniqid']; |
||
| 152 | $keepSettings = $request['data']['keepSettings'] === 'true'; |
||
| 153 | $res = FilesManagementProcessor::uninstallModule($moduleUniqueID, $keepSettings); |
||
| 154 | break; |
||
| 155 | default: |
||
| 156 | $res = new PBXApiResult(); |
||
| 157 | $res->processor = __METHOD__; |
||
| 158 | $res->messages[] = "Unknown action - {$action} in systemCallBack"; |
||
| 159 | } |
||
| 160 | |||
| 161 | $res->function = $action; |
||
| 162 | |||
| 163 | return $res; |
||
| 164 | } |
||
| 204 | } |
