mikopbx /
Core
| Conditions | 21 |
| Paths | 6480 |
| Total Lines | 128 |
| Code Lines | 88 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 295 | private function updateConfigsUpToVer20202573(): void |
||
| 296 | { |
||
| 297 | |||
| 298 | $availCodecs = [ |
||
| 299 | // Видео кодеки. |
||
| 300 | 'h263p' => 'H.263+', |
||
| 301 | 'h263' => 'H.263', |
||
| 302 | 'h264' => 'H.264', |
||
| 303 | |||
| 304 | // Аудио кодеки |
||
| 305 | 'adpcm' => 'ADPCM', |
||
| 306 | 'alaw' => 'G.711 A-law', |
||
| 307 | 'ulaw' => 'G.711 µ-law', |
||
| 308 | 'g719' => 'G.719', |
||
| 309 | 'g722' => 'G.722', |
||
| 310 | 'g726' => 'G.726', |
||
| 311 | 'gsm' => 'GSM', |
||
| 312 | 'ilbc' => 'ILBC', |
||
| 313 | 'lpc10' => 'LPC-10', |
||
| 314 | 'speex' => 'Speex', |
||
| 315 | 'slin' => 'Signed Linear PCM', |
||
| 316 | 'opus' => 'Opus', |
||
| 317 | ]; |
||
| 318 | $codecs = Codecs::find(); |
||
| 319 | // Удалим лишние кодеки |
||
| 320 | /** @var \MikoPBX\Common\Models\Codecs $codec */ |
||
| 321 | foreach ($codecs as $codec){ |
||
| 322 | if(array_key_exists($codec->name, $availCodecs)){ |
||
| 323 | continue; |
||
| 324 | } |
||
| 325 | if(!$codec->delete()){ |
||
| 326 | Util::sysLogMsg(__CLASS__, 'Can not delete codec '.$codec->name. ' from MikoPBX\Common\Models\Codecs'); |
||
| 327 | } |
||
| 328 | } |
||
| 329 | |||
| 330 | foreach ($availCodecs as $availCodec => $desc){ |
||
| 331 | $codecData = Codecs::findFirst('name="'.$availCodec.'"'); |
||
| 332 | if ($codecData === null) { |
||
| 333 | $codecData = new Codecs(); |
||
| 334 | }elseif($codecData->description === $desc){ |
||
| 335 | unset($codecData); |
||
| 336 | continue; |
||
| 337 | } |
||
| 338 | $codecData->name = $availCodec; |
||
| 339 | if(substr($availCodec,0,3) === 'h26'){ |
||
| 340 | $type = 'video'; |
||
| 341 | }else{ |
||
| 342 | $type = 'audio'; |
||
| 343 | } |
||
| 344 | $codecData->type = $type; |
||
| 345 | $codecData->description = $desc; |
||
| 346 | if(!$codecData->save()){ |
||
| 347 | Util::sysLogMsg(__CLASS__, 'Can not update codec info '.$codecData->name. ' from \MikoPBX\Common\Models\Codecs'); |
||
| 348 | } |
||
| 349 | } |
||
| 350 | unset($codecs); |
||
| 351 | |||
| 352 | // Add custom category to all sound files |
||
| 353 | $soundFiles = SoundFiles::find(); |
||
| 354 | foreach ($soundFiles as $sound_file) { |
||
| 355 | $sound_file->category = SoundFiles::CATEGORY_CUSTOM; |
||
| 356 | $sound_file->update(); |
||
| 357 | } |
||
| 358 | |||
| 359 | // Clean AstDB |
||
| 360 | $astDbPath = $this->config->path('astDatabase.dbfile'); |
||
| 361 | if(file_exists($astDbPath)){ |
||
| 362 | $table = 'astdb'; |
||
| 363 | $sql = 'DELETE FROM '.$table.' WHERE key LIKE "/DND/SIP%" OR key LIKE "/CF/SIP%" OR key LIKE "/UserBuddyStatus/SIP%"'; |
||
| 364 | $db = new \SQLite3($astDbPath); |
||
| 365 | try { |
||
| 366 | $db->exec($sql); |
||
| 367 | } catch (\Exception $e) { |
||
| 368 | Util::sysLogMsg(__CLASS__, 'Can clean astdb from UserBuddyStatus...'); |
||
| 369 | sleep(2); |
||
| 370 | } |
||
| 371 | $db->close(); |
||
| 372 | unset($db); |
||
| 373 | } |
||
| 374 | |||
| 375 | // Add moh files to db and copy them to storage |
||
| 376 | $oldMohDir = $this->config->path('asterisk.astvarlibdir') . '/sounds/moh'; |
||
| 377 | $currentMohDir = $this->config->path('asterisk.mohdir'); |
||
| 378 | if ( ! Util::mwMkdir($currentMohDir)) { |
||
| 379 | return; |
||
| 380 | } |
||
| 381 | if(!file_exists($oldMohDir)){ |
||
| 382 | if(!file_exists('/offload/livecd')){ |
||
| 383 | Util::sysLogMsg("UpdateConfigsUpToVer20202314", 'Directory sounds/moh not found', LOG_ERR); |
||
| 384 | } |
||
| 385 | return; |
||
| 386 | } |
||
| 387 | $files = scandir($oldMohDir); |
||
| 388 | foreach ($files as $file) { |
||
| 389 | if (in_array($file, ['.', '..'])) { |
||
| 390 | continue; |
||
| 391 | } |
||
| 392 | if (copy($oldMohDir . '/' . $file, $currentMohDir . '/' . $file)) { |
||
| 393 | $sound_file = new SoundFiles(); |
||
| 394 | $sound_file->path = $currentMohDir . '/' . $file; |
||
| 395 | $sound_file->category = SoundFiles::CATEGORY_MOH; |
||
| 396 | $sound_file->name = $file; |
||
| 397 | $sound_file->save(); |
||
| 398 | } |
||
| 399 | } |
||
| 400 | |||
| 401 | // Remove old cache folders |
||
| 402 | $mediaMountPoint = $this->config->path('core.mediaMountPoint'); |
||
| 403 | $oldCacheDirs = [ |
||
| 404 | "$mediaMountPoint/mikopbx/cache_js_dir", |
||
| 405 | "$mediaMountPoint/mikopbx/cache_img_dir", |
||
| 406 | "$mediaMountPoint/mikopbx/cache_css_dir", |
||
| 407 | ]; |
||
| 408 | foreach ($oldCacheDirs as $old_cache_dir) { |
||
| 409 | if (is_dir($old_cache_dir)) { |
||
| 410 | $rmPath = Util::which('rm'); |
||
| 411 | Util::mwExec("{$rmPath} -rf $old_cache_dir"); |
||
| 412 | } |
||
| 413 | } |
||
| 414 | |||
| 415 | // Update Extensions table |
||
| 416 | $parameters = [ |
||
| 417 | 'conditions' => 'not show_in_phonebook="1" AND is_general_user_number="1"', |
||
| 418 | ]; |
||
| 419 | $wrongRecords = Extensions::find($parameters); |
||
| 420 | foreach ($wrongRecords as $extension){ |
||
| 421 | $extension->show_in_phonebook='1'; |
||
| 422 | $extension->update(); |
||
| 423 | } |
||
| 426 | } |
Loading history...
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..