mikopbx /
Core
| Total Complexity | 40 |
| Total Lines | 257 |
| Duplicated Lines | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Complex classes like SystemManagementProcessor often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use SystemManagementProcessor, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | class SystemManagementProcessor extends Injectable |
||
| 24 | { |
||
| 25 | /** |
||
| 26 | * Processes System requests |
||
| 27 | * |
||
| 28 | * @param array $request |
||
| 29 | * |
||
| 30 | * @return \MikoPBX\PBXCoreREST\Lib\PBXApiResult |
||
| 31 | */ |
||
| 32 | public static function systemCallBack(array $request): PBXApiResult |
||
| 33 | { |
||
| 34 | $action = $request['action']; |
||
| 35 | $data = $request['data']; |
||
| 36 | $res = new PBXApiResult(); |
||
| 37 | $res->processor = __METHOD__; |
||
| 38 | switch ($action) { |
||
| 39 | case 'reboot': |
||
| 40 | System::rebootSync(); |
||
| 41 | $res->success = true; |
||
| 42 | break; |
||
| 43 | case 'shutdown': |
||
| 44 | System::shutdown(); |
||
| 45 | $res->success = true; |
||
| 46 | break; |
||
| 47 | case 'mergeUploadedFile': |
||
| 48 | $phpPath = Util::which('php'); |
||
| 49 | $workerDownloaderPath = Util::getFilePathByClassName(WorkerMergeUploadedFile::class); |
||
| 50 | Util::mwExecBg("{$phpPath} -f {$workerDownloaderPath} '{$data['settings_file']}'"); |
||
| 51 | $res->success = true; |
||
| 52 | break; |
||
| 53 | case 'setDate': |
||
| 54 | $res->success = System::setDate($data['date']); |
||
| 55 | break; |
||
| 56 | case 'getInfo': |
||
| 57 | $res = SystemManagementProcessor::getInfo(); |
||
| 58 | break; |
||
| 59 | case 'updateMailSettings': |
||
| 60 | // TODO |
||
| 61 | $res->success = true; |
||
| 62 | break; |
||
| 63 | case 'sendMail': |
||
| 64 | if (isset($data['email']) && isset($data['subject']) && isset($data['body'])) { |
||
| 65 | if (isset($data['encode']) && $data['encode'] === 'base64') { |
||
| 66 | $data['subject'] = base64_decode($data['subject']); |
||
| 67 | $data['body'] = base64_decode($data['body']); |
||
| 68 | } |
||
| 69 | $result = Notifications::sendMail($data['email'], $data['subject'], $data['body']); |
||
| 70 | if ($result===true){ |
||
| 71 | $res->success = true; |
||
| 72 | } else { |
||
| 73 | $res->success = false; |
||
| 74 | $res->messages[] = $result; |
||
| 75 | } |
||
| 76 | } else { |
||
| 77 | $res->success = false; |
||
| 78 | $res->messages[] = 'Not all query parameters are set'; |
||
| 79 | } |
||
| 80 | break; |
||
| 81 | case 'fileReadContent': |
||
| 82 | $res = FilesManagementProcessor::fileReadContent($data['filename'], $data['needOriginal']); |
||
| 83 | break; |
||
| 84 | case 'getExternalIpInfo': |
||
| 85 | $res = NetworkManagementProcessor::getExternalIpInfo(); |
||
| 86 | break; |
||
| 87 | case 'reloadMsmtp': |
||
| 88 | $notifications = new Notifications(); |
||
| 89 | $notifications->configure(); |
||
| 90 | $voiceMailConfig = new VoiceMailConf(); |
||
| 91 | $voiceMailConfig->generateConfig(); |
||
| 92 | $asteriskPath = Util::which('asterisk'); |
||
| 93 | Util::mwExec("{$asteriskPath} -rx 'voicemail reload'"); |
||
| 94 | $res->success = true; |
||
| 95 | break; |
||
| 96 | case 'unBanIp': |
||
| 97 | $res = FirewallManagementProcessor::fail2banUnbanAll($data['ip']); |
||
| 98 | break; |
||
| 99 | case 'getBanIp': |
||
| 100 | $res = FirewallManagementProcessor::getBanIp(); |
||
| 101 | break; |
||
| 102 | case 'downloadNewFirmware': |
||
| 103 | $res = FilesManagementProcessor::downloadNewFirmware($request['data']); |
||
| 104 | break; |
||
| 105 | case 'firmwareDownloadStatus': |
||
| 106 | $res = FilesManagementProcessor::firmwareDownloadStatus(); |
||
| 107 | break; |
||
| 108 | case 'upgrade': |
||
| 109 | $res = SystemManagementProcessor::upgradeFromImg($data['temp_filename']); |
||
| 110 | break; |
||
| 111 | case 'removeAudioFile': |
||
| 112 | $res = FilesManagementProcessor::removeAudioFile($data['filename']); |
||
| 113 | break; |
||
| 114 | case 'convertAudioFile': |
||
| 115 | $mvPath = Util::which('mv'); |
||
| 116 | Util::mwExec("{$mvPath} {$data['temp_filename']} {$data['filename']}"); |
||
| 117 | $res = FilesManagementProcessor::convertAudioFile($data['filename']); |
||
| 118 | break; |
||
| 119 | case 'downloadNewModule': |
||
| 120 | $module = $request['data']['uniqid']; |
||
| 121 | $url = $request['data']['url']; |
||
| 122 | $md5 = $request['data']['md5']; |
||
| 123 | $res = FilesManagementProcessor::moduleStartDownload($module, $url, $md5); |
||
| 124 | break; |
||
| 125 | case 'moduleDownloadStatus': |
||
| 126 | $module = $request['data']['uniqid']; |
||
| 127 | $res = FilesManagementProcessor::moduleDownloadStatus($module); |
||
| 128 | break; |
||
| 129 | case 'installNewModule': |
||
| 130 | $filePath = $request['data']['filePath']; |
||
| 131 | $res = FilesManagementProcessor::installModuleFromFile($filePath); |
||
| 132 | break; |
||
| 133 | case 'enableModule': |
||
| 134 | $moduleUniqueID = $request['data']['uniqid']; |
||
| 135 | $moduleStateProcessor = new PbxExtensionState($moduleUniqueID); |
||
| 136 | if ($moduleStateProcessor->enableModule() === false) { |
||
| 137 | $res->success = false; |
||
| 138 | $res->messages = $moduleStateProcessor->getMessages(); |
||
| 139 | } else { |
||
| 140 | PBXConfModulesProvider::recreateModulesProvider(); |
||
| 141 | $res->data['needReloadModules'] = true; |
||
| 142 | $res->success = true; |
||
| 143 | } |
||
| 144 | break; |
||
| 145 | case 'disableModule': |
||
| 146 | $moduleUniqueID = $request['data']['uniqid']; |
||
| 147 | $moduleStateProcessor = new PbxExtensionState($moduleUniqueID); |
||
| 148 | if ($moduleStateProcessor->disableModule() === false) { |
||
| 149 | $res->success = false; |
||
| 150 | $res->messages = $moduleStateProcessor->getMessages(); |
||
| 151 | } else { |
||
| 152 | PBXConfModulesProvider::recreateModulesProvider(); |
||
| 153 | $res->data['needReloadModules'] = true; |
||
| 154 | $res->success = true; |
||
| 155 | } |
||
| 156 | break; |
||
| 157 | case 'uninstallModule': |
||
| 158 | $moduleUniqueID = $request['data']['uniqid']; |
||
| 159 | $keepSettings = $request['data']['keepSettings']==='true'; |
||
| 160 | $res = FilesManagementProcessor::uninstallModule($moduleUniqueID, $keepSettings); |
||
| 161 | break; |
||
| 162 | default: |
||
| 163 | $res = new PBXApiResult(); |
||
| 164 | $res->processor = __METHOD__; |
||
| 165 | $res->messages[] = "Unknown action - {$action} in systemCallBack"; |
||
| 166 | } |
||
| 167 | |||
| 168 | $res->function = $action; |
||
| 169 | |||
| 170 | return $res; |
||
| 171 | } |
||
| 172 | |||
| 173 | /** |
||
| 174 | * Получение сведений о системе. |
||
| 175 | * |
||
| 176 | * @return PBXApiResult |
||
| 177 | */ |
||
| 178 | public static function getInfo(): PBXApiResult |
||
| 179 | { |
||
| 180 | $res = new PBXApiResult(); |
||
| 181 | $res->processor = __METHOD__; |
||
| 182 | $res->success = true; |
||
| 183 | |||
| 184 | $storage = new Storage(); |
||
| 185 | $res->data = [ |
||
| 186 | 'disks' => $storage->getAllHdd(), |
||
| 187 | 'cpu' => self::getCpu(), |
||
| 188 | 'uptime' => self::getUpTime(), |
||
| 189 | 'mem' => self::getMemInfo(), |
||
| 190 | ]; |
||
| 191 | $res->processor = __METHOD__; |
||
| 192 | return $res; |
||
| 193 | } |
||
| 194 | |||
| 195 | /** |
||
| 196 | * Возвращает информацию по загрузке CPU. |
||
| 197 | */ |
||
| 198 | public static function getCpu() |
||
| 199 | { |
||
| 200 | $ut = []; |
||
| 201 | $grepPath = Util::which('grep'); |
||
| 202 | $mpstatPath = Util::which('mpstat'); |
||
| 203 | Util::mwExec("{$mpstatPath} | {$grepPath} all", $ut); |
||
| 204 | preg_match("/^.*\s+all\s+.*\s+.*\s+.*\s+.*\s+.*\s+.*\s+.*\s+.*\s+(.*)\s*.*/i", $ut[0], $matches); |
||
| 205 | $rv = 100 - $matches[1]; |
||
| 206 | |||
| 207 | if (100 < $rv) { |
||
| 208 | $rv = 100; |
||
| 209 | } |
||
| 210 | |||
| 211 | return round($rv, 2); |
||
| 212 | } |
||
| 213 | |||
| 214 | /** |
||
| 215 | * Получаем информацию по времени работы ПК. |
||
| 216 | */ |
||
| 217 | public static function getUpTime(): string |
||
| 218 | { |
||
| 219 | $ut = []; |
||
| 220 | $uptimePath = Util::which('uptime'); |
||
| 221 | $awkPath = Util::which('awk'); |
||
| 222 | Util::mwExec("{$uptimePath} | {$awkPath} -F \" |,\" '{print $5}'", $ut); |
||
| 223 | |||
| 224 | return implode('', $ut); |
||
| 225 | } |
||
| 226 | |||
| 227 | /** |
||
| 228 | * Получаем информацию по оперативной памяти. |
||
| 229 | */ |
||
| 230 | public static function getMemInfo(): array |
||
| 245 | } |
||
| 246 | |||
| 247 | /** |
||
| 248 | * Upgrade MikoPBX from uploaded IMG file |
||
| 249 | * |
||
| 250 | * @param string $tempFilename path to uploaded image |
||
| 251 | * |
||
| 252 | * @return PBXApiResult |
||
| 253 | */ |
||
| 254 | public static function upgradeFromImg(string $tempFilename): PBXApiResult |
||
| 282 | } |
