| Total Complexity | 63 |
| Total Lines | 365 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like ProvidersController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ProvidersController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 25 | class ProvidersController extends BaseController |
||
| 26 | { |
||
| 27 | |||
| 28 | /** |
||
| 29 | * Получение общего списка провайдеров |
||
| 30 | */ |
||
| 31 | public function indexAction(): void |
||
| 50 | } |
||
| 51 | |||
| 52 | |||
| 53 | /** |
||
| 54 | * Открытие карточки SIP провайдера и заполнение значений по умолчанию |
||
| 55 | * |
||
| 56 | * @param string $uniqid Уникальный идентификатор провайдера, если мы открываем существующего |
||
| 57 | */ |
||
| 58 | public function modifysipAction(string $uniqid = ''): void |
||
| 59 | { |
||
| 60 | $provider = Providers::findFirstByUniqid($uniqid); |
||
| 61 | |||
| 62 | if ($provider === null) { |
||
| 63 | $uniqid = strtoupper('SIP-' . time()); |
||
| 64 | $provider = new Providers(); |
||
| 65 | $provider->type = 'SIP'; |
||
| 66 | $provider->uniqid = $uniqid; |
||
| 67 | $provider->sipuid = $uniqid; |
||
| 68 | $provider->Sip = new Sip(); |
||
| 69 | $provider->Sip->uniqid = $uniqid; |
||
| 70 | $provider->Sip->type = 'friend'; |
||
| 71 | $provider->Sip->port = 5060; |
||
| 72 | $provider->Sip->disabled = '0'; |
||
| 73 | $provider->Sip->qualifyfreq = 60; |
||
| 74 | $provider->Sip->qualify = '1'; |
||
| 75 | } |
||
| 76 | |||
| 77 | $providerHost = $provider->Sip->host; |
||
| 78 | $sipHosts = $provider->Sip->SipHosts; |
||
|
|
|||
| 79 | $hostsTable = []; |
||
| 80 | foreach ($sipHosts as $host) { |
||
| 81 | if ($providerHost !== $host->address){ |
||
| 82 | $hostsTable[] = $host->address; |
||
| 83 | } |
||
| 84 | } |
||
| 85 | $this->view->hostsTable = $hostsTable; |
||
| 86 | $this->view->form = new SipProviderEditForm($provider->Sip); |
||
| 87 | $this->view->represent = $provider->getRepresent(); |
||
| 88 | } |
||
| 89 | |||
| 90 | /** |
||
| 91 | * Открытие карточки IAX провайдера и заполнение значений по умолчанию |
||
| 92 | * |
||
| 93 | * @param string $uniqid Уникальный идентификатор провайдера, если мы открываем существующего |
||
| 94 | */ |
||
| 95 | public function modifyiaxAction(string $uniqid = ''): void |
||
| 113 | } |
||
| 114 | |||
| 115 | /** |
||
| 116 | * Включение провайдера |
||
| 117 | * |
||
| 118 | * @param string $type тип провайдера SIP или IAX |
||
| 119 | * @param string $uniqid Уникальный идентификатор провайдера, если мы открываем существующего |
||
| 120 | */ |
||
| 121 | public function enableAction(string $type, string $uniqid = ''): void |
||
| 122 | { |
||
| 123 | $this->view->success = false; |
||
| 124 | switch ($type) { |
||
| 125 | case 'iax': |
||
| 126 | { |
||
| 127 | $provider = Iax::findFirstByUniqid($uniqid); |
||
| 128 | break; |
||
| 129 | } |
||
| 130 | case 'sip': |
||
| 131 | { |
||
| 132 | $provider = Sip::findFirstByUniqid($uniqid); |
||
| 133 | break; |
||
| 134 | } |
||
| 135 | default: |
||
| 136 | $provider = null; |
||
| 137 | } |
||
| 138 | if ($provider !== null) { |
||
| 139 | $provider->disabled = '0'; |
||
| 140 | if ($provider->save() === true) { |
||
| 141 | $this->view->success = true; |
||
| 142 | } |
||
| 143 | } |
||
| 144 | } |
||
| 145 | |||
| 146 | /** |
||
| 147 | * Отключение провайдера |
||
| 148 | * |
||
| 149 | * @param string $type тип провайдера SIP или IAX |
||
| 150 | * @param string $uniqid Уникальный идентификатор провайдера, если мы открываем существующего |
||
| 151 | */ |
||
| 152 | public function disableAction(string $type, string $uniqid = ''): void |
||
| 153 | { |
||
| 154 | $this->view->success = false; |
||
| 155 | switch ($type) { |
||
| 156 | case 'iax': |
||
| 157 | { |
||
| 158 | $provider = Iax::findFirstByUniqid($uniqid); |
||
| 159 | break; |
||
| 160 | } |
||
| 161 | case 'sip': |
||
| 162 | { |
||
| 163 | $provider = Sip::findFirstByUniqid($uniqid); |
||
| 164 | break; |
||
| 165 | } |
||
| 166 | default: |
||
| 167 | $provider = null; |
||
| 168 | } |
||
| 169 | if ($provider !== null) { |
||
| 170 | $provider->disabled = '1'; |
||
| 171 | if ($provider->save() === true) { |
||
| 172 | $this->view->success = true; |
||
| 173 | } |
||
| 174 | } |
||
| 175 | } |
||
| 176 | |||
| 177 | /** |
||
| 178 | * Saves provider over ajax request from a web form |
||
| 179 | * |
||
| 180 | * @param string $type - sip or iax |
||
| 181 | * |
||
| 182 | */ |
||
| 183 | public function saveAction(string $type): void |
||
| 184 | { |
||
| 185 | if ( ! $this->request->isPost()) { |
||
| 186 | $this->forward('network/index'); |
||
| 187 | } |
||
| 188 | $this->db->begin(); |
||
| 189 | $data = $this->request->getPost(); |
||
| 190 | |||
| 191 | // Updates SIP and IAX tables |
||
| 192 | if ( ! $this->saveProvider($data, $type)) { |
||
| 193 | $this->view->success = false; |
||
| 194 | $this->db->rollback(); |
||
| 195 | |||
| 196 | return; |
||
| 197 | } |
||
| 198 | |||
| 199 | // Update additional hosts table |
||
| 200 | if ( ! $this->updateAdditionalHosts($data)) { |
||
| 201 | $this->view->success = false; |
||
| 202 | $this->db->rollback(); |
||
| 203 | |||
| 204 | return; |
||
| 205 | } |
||
| 206 | |||
| 207 | $this->flash->success($this->translation->_('ms_SuccessfulSaved')); |
||
| 208 | $this->view->success = true; |
||
| 209 | $this->db->commit(); |
||
| 210 | |||
| 211 | // Если это было создание карточки то надо перегрузить страницу с указанием ID |
||
| 212 | if (empty($data['id'])) { |
||
| 213 | $this->view->reload = "providers/modify{$type}/{$data['uniqid']}"; |
||
| 214 | } |
||
| 215 | } |
||
| 216 | |||
| 217 | /** |
||
| 218 | * Save providers data table |
||
| 219 | * |
||
| 220 | * @param array $data - POST DATA |
||
| 221 | * @param string $type - sip or iax |
||
| 222 | * |
||
| 223 | * @return bool save result |
||
| 224 | */ |
||
| 225 | private function saveProvider(array $data, string $type): bool |
||
| 226 | { |
||
| 227 | // Проверим это новый провайдер или старый |
||
| 228 | $provider = Providers::findFirstByUniqid($data['uniqid']); |
||
| 229 | if ($provider === null) { |
||
| 230 | $provider = new Providers(); |
||
| 231 | $provider->uniqid = $data['uniqid']; |
||
| 232 | switch ($type) { |
||
| 233 | case 'iax': |
||
| 234 | $provider->iaxuid = $data['uniqid']; |
||
| 235 | $provider->type = 'IAX'; |
||
| 236 | $provider->Iax = new Iax(); |
||
| 237 | break; |
||
| 238 | case 'sip': |
||
| 239 | $provider->sipuid = $data['uniqid']; |
||
| 240 | $provider->type = 'SIP'; |
||
| 241 | $provider->Sip = new Sip(); |
||
| 242 | break; |
||
| 243 | } |
||
| 244 | } |
||
| 245 | |||
| 246 | if ($provider->save() === false) { |
||
| 247 | $errors = $provider->getMessages(); |
||
| 248 | $this->flash->warning(implode('<br>', $errors)); |
||
| 249 | return false; |
||
| 250 | } |
||
| 251 | |||
| 252 | switch ($type) { |
||
| 253 | case 'iax': |
||
| 254 | $providerByType = $provider->Iax; |
||
| 255 | break; |
||
| 256 | case 'sip': |
||
| 257 | $providerByType = $provider->Sip; |
||
| 258 | break; |
||
| 259 | default: |
||
| 260 | $providerByType = []; |
||
| 261 | } |
||
| 262 | |||
| 263 | foreach ($providerByType as $name => $value) { |
||
| 264 | switch ($name) { |
||
| 265 | case 'id': |
||
| 266 | break; |
||
| 267 | case 'qualify': |
||
| 268 | case 'disablefromuser': |
||
| 269 | case 'noregister': |
||
| 270 | case 'receive_calls_without_auth': |
||
| 271 | if (array_key_exists($name, $data)) { |
||
| 272 | $providerByType->$name = ($data[$name] === 'on') ? 1 : 0; |
||
| 273 | } else { |
||
| 274 | $providerByType->$name = 0; |
||
| 275 | } |
||
| 276 | break; |
||
| 277 | case 'manualattributes': |
||
| 278 | if (array_key_exists($name, $data)) { |
||
| 279 | $providerByType->setManualAttributes($data[$name]); |
||
| 280 | } |
||
| 281 | break; |
||
| 282 | default: |
||
| 283 | if (array_key_exists($name, $data)) { |
||
| 284 | $providerByType->$name = $data[$name]; |
||
| 285 | } |
||
| 286 | } |
||
| 287 | } |
||
| 288 | |||
| 289 | if ($providerByType->save() === false) { |
||
| 290 | $errors = $providerByType->getMessages(); |
||
| 291 | $this->flash->warning(implode('<br>', $errors)); |
||
| 292 | |||
| 293 | return false; |
||
| 294 | } |
||
| 295 | |||
| 296 | return true; |
||
| 297 | } |
||
| 298 | |||
| 299 | /** |
||
| 300 | * Update additional hosts table |
||
| 301 | * |
||
| 302 | * @param array $data массив полей из POST запроса |
||
| 303 | * |
||
| 304 | * @return bool update result |
||
| 305 | */ |
||
| 306 | private function updateAdditionalHosts(array $data): bool |
||
| 341 | } |
||
| 342 | |||
| 343 | /** |
||
| 344 | * Deletes provider record by unique id |
||
| 345 | * |
||
| 346 | * @param string $uniqid |
||
| 347 | */ |
||
| 348 | public function deleteAction(string $uniqid = ''): void |
||
| 390 | } |
||
| 391 | |||
| 392 | } |