mikopbx /
Core
| Conditions | 15 |
| Paths | 94 |
| Total Lines | 82 |
| Code Lines | 66 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 104 | private function playback(): void |
||
| 105 | { |
||
| 106 | $filename = $this->request->get('view'); |
||
| 107 | $extension = Util::getExtensionOfFile($filename); |
||
| 108 | if (in_array($extension, ['mp3', 'wav']) && Util::recFileExists($filename)) { |
||
| 109 | $ctype = ''; |
||
| 110 | switch ($extension) { |
||
| 111 | case 'mp3': |
||
| 112 | $ctype = 'audio/mpeg'; |
||
| 113 | break; |
||
| 114 | case 'wav': |
||
| 115 | $ctype = 'audio/x-wav'; |
||
| 116 | break; |
||
| 117 | } |
||
| 118 | $filesize = filesize($filename); |
||
| 119 | if (isset($_SERVER['HTTP_RANGE'])) { |
||
| 120 | $range = $_SERVER['HTTP_RANGE']; |
||
| 121 | [$param, $range] = explode('=', $range); |
||
| 122 | if (strtolower(trim($param)) !== 'bytes') { |
||
| 123 | $this->sendError(400); |
||
| 124 | |||
| 125 | return; |
||
| 126 | } |
||
| 127 | $range = explode(',', $range); |
||
| 128 | $range = explode('-', $range[0]); |
||
| 129 | if ($range[0] === '') { |
||
| 130 | $end = $filesize - 1; |
||
| 131 | $start = $end - (int)$range[0]; |
||
| 132 | } elseif ($range[1] === '') { |
||
| 133 | $start = (int)$range[0]; |
||
| 134 | $end = $filesize - 1; |
||
| 135 | } else { |
||
| 136 | $start = (int)$range[0]; |
||
| 137 | $end = (int)$range[1]; |
||
| 138 | } |
||
| 139 | $length = $end - $start + 1; |
||
| 140 | |||
| 141 | $this->response->resetHeaders(); |
||
| 142 | if ( ! $fp = fopen($filename, 'rb')) { |
||
| 143 | $this->sendError(Response::INTERNAL_SERVER_ERROR); |
||
| 144 | } else { |
||
| 145 | $this->response->setRawHeader('HTTP/1.1 206 Partial Content'); |
||
| 146 | $this->response->setHeader('Content-type', $ctype); |
||
| 147 | $this->response->setHeader('Content-Range', "bytes $start-$end/$filesize"); |
||
| 148 | $this->response->setContentLength($length); |
||
| 149 | if ($start) { |
||
| 150 | fseek($fp, $start); |
||
| 151 | } |
||
| 152 | $content = ''; |
||
| 153 | while ($length) { |
||
| 154 | set_time_limit(0); |
||
| 155 | $read = ($length > 8192) ? 8192 : $length; |
||
| 156 | $length -= $read; |
||
| 157 | $content .= fread($fp, $read); |
||
| 158 | } |
||
| 159 | fclose($fp); |
||
| 160 | $this->response->setContent($content); |
||
| 161 | } |
||
| 162 | } else { |
||
| 163 | $this->response->setHeader('Content-type', $ctype); |
||
| 164 | $this->response->setContentLength($filesize); |
||
| 165 | $this->response->setHeader('Accept-Ranges', 'bytes'); |
||
| 166 | $this->response->setStatusCode(Response::OK, 'OK'); |
||
| 167 | $this->response->setFileToSend($filename); |
||
| 168 | } |
||
| 169 | $this->response->setHeader('Server', 'nginx'); |
||
| 170 | |||
| 171 | $is_download = ! empty($this->request->get('download')); |
||
| 172 | if ($is_download) { |
||
| 173 | $new_filename = $this->request->get('filename'); |
||
| 174 | if (empty($new_filename)) { |
||
| 175 | $new_filename = basename($filename); |
||
| 176 | } |
||
| 177 | |||
| 178 | $this->response->setHeader( |
||
| 179 | 'Content-Disposition', |
||
| 180 | "attachment; filename*=UTF-8''" . basename($new_filename) |
||
| 181 | ); |
||
| 182 | } |
||
| 183 | $this->response->sendRaw(); |
||
| 184 | } else { |
||
| 185 | $this->sendError(Response::NOT_FOUND); |
||
| 186 | } |
||
| 189 | } |
