GetRecord::main() - Code Metrics - Inspection of "Merge branch 'develop' of github.com:mikopbx/Core..." - mikopbx/Core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 578d35...1edb03 )

by Nikolay

created 2023-08-28 05:06 UTC

GetRecord::main() B

↳ Parent: GetRecord

Complexity

Conditions	2
Paths	2

Size

Total Lines	84
Code Lines	67

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	67
c	1
b	0
f	0
dl	0
loc	84
rs	8.72
cc	2
nc	2
nop	1

How to fix Long Method

<?php
/*
 * MikoPBX - free phone system for small business
 * Copyright © 2017-2023 Alexey Portnov and Nikolay Beketov
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along with this program.
 * If not, see <https://www.gnu.org/licenses/>.
 */

namespace MikoPBX\PBXCoreREST\Lib\Extensions;

use MikoPBX\Common\Models\ExtensionForwardingRights;
use MikoPBX\Common\Models\Extensions;
use MikoPBX\Common\Models\ExternalPhones;
use MikoPBX\Common\Models\Sip;
use MikoPBX\Common\Models\Users;
use MikoPBX\PBXCoreREST\Lib\PBXApiResult;
use Phalcon\Di;

/**
 *  Class GetRecord
 *  Delete an internal number and all its dependencies including mobile and forwarding settings.
 *
 * @package MikoPBX\PBXCoreREST\Lib\Extensions
 */
class GetRecord extends \Phalcon\Di\Injectable
{

    /**
     * Gets extension data for existing or for the new record
     *
     * @param string $id ID of the extension to be received.
     * @return PBXApiResult Result of the delete operation.
     */
    public static function main(string $id): PBXApiResult
    {
        $res = new PBXApiResult();
        $res->processor = __METHOD__;
        $res->success = true;

        $parameters = [
            'models' => [
                'Extensions' => Extensions::class,
            ],
            'conditions' => 'Extensions.id = :ext_id: AND Extensions.type="' . Extensions::TYPE_SIP.'"',
            'bind' => [
                'ext_id' => $id
            ],
            'columns' => [
                'id' => 'Extensions.id',
                'number' => 'Extensions.number',
                'user_id' => 'Users.id',
                'user_username' => 'Users.username',
                'user_email' => 'Users.email',
                'user_avatar'=>  'Users.avatar',
                'fwd_ringlength'=>'ExtensionForwardingRights.ringlength',
                'fwd_forwardingonbusy'=>'ExtensionForwardingRights.forwardingonbusy',
                'fwd_forwardingonunavailable'=>'ExtensionForwardingRights.forwardingonunavailable',
                'fwd_forwarding'=>'ExtensionForwardingRights.forwarding',
                'mobile_number'=>'ExternalPhones.extension',
                'mobile_uniqid'=>'ExternalPhones.uniqid',
                'mobile_dialstring'=>'ExternalPhones.dialstring',
                'sip_enableRecording' =>'Sip.enableRecording',
                'sip_dtmfmode' =>'Sip.dtmfmode',
                'sip_manualattributes' => 'Sip.manualattributes',
                'sip_uniqid' => 'Sip.uniqid',
                'sip_secret' => 'Sip.secret',
                'sip_networkfilterid'=>'Sip.networkfilterid',
                'sip_transport' => 'Sip.transport'
            ],
            'joins' => [
                'Users' => [
                    0 => Users::class,
                    1 => 'Users.id = Extensions.userid' ,
                    2 => 'Users',
                    3 => 'INNER',
                ],
                'Sip' => [
                    0 => Sip::class,
                    1 => 'Sip.extension = Extensions.number',
                    2 => 'Sip',
                    3 => 'LEFT',
                ],
                'ExtensionsExternal' => [
                    0 => Extensions::class,
                    1 => 'ExtensionsExternal.userid = Users.id AND ExtensionsExternal.type="' . Extensions::TYPE_EXTERNAL.'"',
                    2 => 'ExtensionsExternal',
                    3 => 'LEFT',
                ],
                'ExternalPhones' => [
                    0 => ExternalPhones::class,
                    1 => 'ExternalPhones.extension = ExtensionsExternal.number',
                    2 => 'ExternalPhones',
                    3 => 'LEFT',
                ],
                'ExtensionForwardingRights' => [
                    0 => ExtensionForwardingRights::class,
                    1 => 'ExtensionForwardingRights.extension = Extensions.number',
                    2 => 'ExtensionForwardingRights',
                    3 => 'LEFT',
                ],

            ],
        ];
        $extension = Di::getDefault()->get('modelsManager')->createBuilder($parameters)
            ->getQuery()
            ->getSingleResult();

        if (!$extension) {
            $dataFromRequest = [];
        } else {
            $dataFromRequest = $extension->toArray();
            $dataFromRequest['sip_manualattributes']=base64_decode($dataFromRequest['sip_manualattributes']);
        }

        $dataStructure = new DataStructure($dataFromRequest);
        $res->data = $dataStructure->toArray();
        return  $res;
    }
}

1			<?php
2			/*
3			* MikoPBX - free phone system for small business
4			* Copyright © 2017-2023 Alexey Portnov and Nikolay Beketov
5			*
6			* This program is free software: you can redistribute it and/or modify
7			* it under the terms of the GNU General Public License as published by
8			* the Free Software Foundation; either version 3 of the License, or
9			* (at your option) any later version.
10			*
11			* This program is distributed in the hope that it will be useful,
12			* but WITHOUT ANY WARRANTY; without even the implied warranty of
13			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14			* GNU General Public License for more details.
15			*
16			* You should have received a copy of the GNU General Public License along with this program.
17			* If not, see <https://www.gnu.org/licenses/>.
18			*/
19
20			namespace MikoPBX\PBXCoreREST\Lib\Extensions;
21
22			use MikoPBX\Common\Models\ExtensionForwardingRights;
23			use MikoPBX\Common\Models\Extensions;
24			use MikoPBX\Common\Models\ExternalPhones;
25			use MikoPBX\Common\Models\Sip;
26			use MikoPBX\Common\Models\Users;
27			use MikoPBX\PBXCoreREST\Lib\PBXApiResult;
28			use Phalcon\Di;
29
30			/**
31			* Class GetRecord
32			* Delete an internal number and all its dependencies including mobile and forwarding settings.
33			*
34			* @package MikoPBX\PBXCoreREST\Lib\Extensions
35			*/
36			class GetRecord extends \Phalcon\Di\Injectable
37			{
38
39			/**
40			* Gets extension data for existing or for the new record
41			*
42			* @param string $id ID of the extension to be received.
43			* @return PBXApiResult Result of the delete operation.
44			*/
45			public static function main(string $id): PBXApiResult
46			{
47			$res = new PBXApiResult();
48			$res->processor = __METHOD__;
49			$res->success = true;
50
51			$parameters = [
52			'models' => [
53			'Extensions' => Extensions::class,
54			],
55			'conditions' => 'Extensions.id = :ext_id: AND Extensions.type="' . Extensions::TYPE_SIP.'"',
56			'bind' => [
57			'ext_id' => $id
58			],
59			'columns' => [
60			'id' => 'Extensions.id',
61			'number' => 'Extensions.number',
62			'user_id' => 'Users.id',
63			'user_username' => 'Users.username',
64			'user_email' => 'Users.email',
65			'user_avatar'=> 'Users.avatar',
66			'fwd_ringlength'=>'ExtensionForwardingRights.ringlength',
67			'fwd_forwardingonbusy'=>'ExtensionForwardingRights.forwardingonbusy',
68			'fwd_forwardingonunavailable'=>'ExtensionForwardingRights.forwardingonunavailable',
69			'fwd_forwarding'=>'ExtensionForwardingRights.forwarding',
70			'mobile_number'=>'ExternalPhones.extension',
71			'mobile_uniqid'=>'ExternalPhones.uniqid',
72			'mobile_dialstring'=>'ExternalPhones.dialstring',
73			'sip_enableRecording' =>'Sip.enableRecording',
74			'sip_dtmfmode' =>'Sip.dtmfmode',
75			'sip_manualattributes' => 'Sip.manualattributes',
76			'sip_uniqid' => 'Sip.uniqid',
77			'sip_secret' => 'Sip.secret',
78			'sip_networkfilterid'=>'Sip.networkfilterid',
79			'sip_transport' => 'Sip.transport'
80			],
81			'joins' => [
82			'Users' => [
83			0 => Users::class,
84			1 => 'Users.id = Extensions.userid' ,
85			2 => 'Users',
86			3 => 'INNER',
87			],
88			'Sip' => [
89			0 => Sip::class,
90			1 => 'Sip.extension = Extensions.number',
91			2 => 'Sip',
92			3 => 'LEFT',
93			],
94			'ExtensionsExternal' => [
95			0 => Extensions::class,
96			1 => 'ExtensionsExternal.userid = Users.id AND ExtensionsExternal.type="' . Extensions::TYPE_EXTERNAL.'"',
97			2 => 'ExtensionsExternal',
98			3 => 'LEFT',
99			],
100			'ExternalPhones' => [
101			0 => ExternalPhones::class,
102			1 => 'ExternalPhones.extension = ExtensionsExternal.number',
103			2 => 'ExternalPhones',
104			3 => 'LEFT',
105			],
106			'ExtensionForwardingRights' => [
107			0 => ExtensionForwardingRights::class,
108			1 => 'ExtensionForwardingRights.extension = Extensions.number',
109			2 => 'ExtensionForwardingRights',
110			3 => 'LEFT',
111			],
112
113			],
114			];
115			$extension = Di::getDefault()->get('modelsManager')->createBuilder($parameters)
116			->getQuery()
117			->getSingleResult();
118
119			if (!$extension) {
120			$dataFromRequest = [];
121			} else {
122			$dataFromRequest = $extension->toArray();
123			$dataFromRequest['sip_manualattributes']=base64_decode($dataFromRequest['sip_manualattributes']);
124			}
125
126			$dataStructure = new DataStructure($dataFromRequest);
127			$res->data = $dataStructure->toArray();
128			return $res;
129			}
130			}

mikopbx / Core

Push — develop ( 578d35...1edb03 )

GetRecord::main() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like