mikopbx /
Core
| Conditions | 15 |
| Paths | 180 |
| Total Lines | 78 |
| Code Lines | 59 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 58 | public function generateConf($not_ssl = false, $level = 0): void |
||
| 59 | { |
||
| 60 | $configPath = '/etc/nginx/mikopbx/conf.d'; |
||
| 61 | $httpConfigFile = "{$configPath}/http-server.conf"; |
||
| 62 | $httpsConfigFile = "{$configPath}/https-server.conf"; |
||
| 63 | $dns_server = '127.0.0.1'; |
||
| 64 | |||
| 65 | $net = new Network(); |
||
| 66 | $dns = $net->getHostDNS(); |
||
| 67 | foreach ($dns as $ns) { |
||
| 68 | if (Verify::isIpAddress($ns)) { |
||
| 69 | $dns_server = trim($ns); |
||
| 70 | break; |
||
| 71 | } |
||
| 72 | } |
||
| 73 | |||
| 74 | // HTTP |
||
| 75 | $WEBPort = $this->mikoPBXConfig->getGeneralSettings('WEBPort'); |
||
| 76 | $WEBHTTPSPort = $this->mikoPBXConfig->getGeneralSettings('WEBHTTPSPort'); |
||
| 77 | |||
| 78 | $config = file_get_contents("{$httpConfigFile}.original"); |
||
| 79 | $config = str_replace(['<DNS>', '<WEBPort>'], [$dns_server, $WEBPort], $config); |
||
| 80 | |||
| 81 | $RedirectToHttps = $this->mikoPBXConfig->getGeneralSettings('RedirectToHttps'); |
||
| 82 | if ($RedirectToHttps === '1' && $not_ssl === false) { |
||
| 83 | $conf_data = 'if ( $remote_addr != "127.0.0.1" ) {' . PHP_EOL |
||
| 84 | . ' ' . 'return 301 https://$host:' . $WEBHTTPSPort . '$request_uri;' . PHP_EOL |
||
| 85 | . ' }' . PHP_EOL; |
||
| 86 | $config = str_replace('include mikopbx/locations/*.conf;', $conf_data, $config); |
||
| 87 | } |
||
| 88 | file_put_contents($httpConfigFile, $config); |
||
| 89 | |||
| 90 | // SSL |
||
| 91 | $WEBHTTPSPublicKey = $this->mikoPBXConfig->getGeneralSettings('WEBHTTPSPublicKey'); |
||
| 92 | $WEBHTTPSPrivateKey = $this->mikoPBXConfig->getGeneralSettings('WEBHTTPSPrivateKey'); |
||
| 93 | if ( |
||
| 94 | $not_ssl === false |
||
| 95 | && ! empty($WEBHTTPSPublicKey) |
||
| 96 | && ! empty($WEBHTTPSPrivateKey) |
||
| 97 | ) { |
||
| 98 | $public_filename = '/etc/ssl/certs/nginx.crt'; |
||
| 99 | $private_filename = '/etc/ssl/private/nginx.key'; |
||
| 100 | file_put_contents($public_filename, $WEBHTTPSPublicKey); |
||
| 101 | file_put_contents($private_filename, $WEBHTTPSPrivateKey); |
||
| 102 | $config = file_get_contents("{$httpsConfigFile}.original"); |
||
| 103 | $config = str_replace(['<DNS>', '<WEBHTTPSPort>'], [$dns_server, $WEBHTTPSPort], $config); |
||
| 104 | file_put_contents($httpsConfigFile, $config); |
||
| 105 | } elseif (file_exists($httpsConfigFile)) { |
||
| 106 | unlink($httpsConfigFile); |
||
| 107 | } |
||
| 108 | |||
| 109 | // Test work |
||
| 110 | $nginxPath = Util::which('nginx'); |
||
| 111 | $out = []; |
||
| 112 | Util::mwExec("{$nginxPath} -t", $out); |
||
| 113 | $res = implode($out); |
||
| 114 | if ($level < 1 && false !== strpos($res, 'test failed')) { |
||
| 115 | ++$level; |
||
| 116 | Util::sysLogMsg('nginx', 'Failed test config file. SSL will be disable...'); |
||
| 117 | $this->generateConf(true, $level); |
||
| 118 | } |
||
| 119 | |||
| 120 | // Add additional rules from modules |
||
| 121 | $locationsPath = self::LOCATIONS_PATH; |
||
| 122 | $additionalModules = $this->di->getShared('pbxConfModules'); |
||
| 123 | $rmPath = Util::which('rm'); |
||
| 124 | foreach ($additionalModules as $appClass) { |
||
| 125 | if (method_exists($appClass, 'createNginxLocations')) { |
||
| 126 | $locationContent = $appClass->createNginxLocations(); |
||
| 127 | if ( ! empty($locationContent)) { |
||
| 128 | $confFileName = "{$locationsPath}/{$appClass->moduleUniqueId}.conf"; |
||
| 129 | file_put_contents($confFileName, $locationContent); |
||
| 130 | $out = []; |
||
| 131 | Util::mwExec("{$nginxPath} -t", $out); |
||
| 132 | $res = implode($out); |
||
| 133 | if (false !== strpos($res, 'test failed')) { |
||
| 134 | Util::mwExec("{$rmPath} {$confFileName}"); |
||
| 135 | Util::sysLogMsg('nginx', 'Failed test config file for module' . $appClass->moduleUniqueId); |
||
| 136 | } |
||
| 141 | } |
