Conditions | 1 |
Paths | 1 |
Total Lines | 94 |
Code Lines | 92 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
84 | public static function getDefaultArrayValues(): array |
||
85 | { |
||
86 | return [ |
||
87 | PbxSettings::PBX_NAME => 'PBX system', |
||
88 | PbxSettings::VIRTUAL_HARDWARE_TYPE => 'BARE METAL', |
||
89 | PbxSettings::PBX_DESCRIPTION => '', |
||
90 | PbxSettings::RESTART_EVERY_NIGHT => '0', |
||
91 | PbxSettings::SIP_PORT => '5060', |
||
92 | PbxSettings::EXTERNAL_SIP_PORT => '5060', |
||
93 | PbxSettings::TLS_PORT => '5061', |
||
94 | PbxSettings::EXTERNAL_TLS_PORT => '5061', |
||
95 | PbxSettings::SIP_DEFAULT_EXPIRY => '120', |
||
96 | PbxSettings::SIP_MIN_EXPIRY => '60', |
||
97 | PbxSettings::SIP_MAX_EXPIRY => '3600', |
||
98 | PbxSettings::RTP_PORT_FROM => '10000', |
||
99 | PbxSettings::RTP_PORT_TO => '10200', |
||
100 | PbxSettings::RTP_STUN_SERVER => '', |
||
101 | PbxSettings::USE_WEB_RTC => '0', |
||
102 | PbxSettings::IAX_PORT => '4569', |
||
103 | PbxSettings::AMI_ENABLED => '1', |
||
104 | PbxSettings::AMI_PORT => '5038', |
||
105 | PbxSettings::AJAM_ENABLED => '1', |
||
106 | PbxSettings::AJAM_PORT => '8088', |
||
107 | PbxSettings::AJAM_PORT_TLS => '8089', |
||
108 | PbxSettings::SSH_PORT => '22', |
||
109 | PbxSettings::SSH_LOGIN => 'root', |
||
110 | PbxSettings::SSH_PASSWORD => 'admin', |
||
111 | PbxSettings::SSH_RSA_KEY => '', |
||
112 | PbxSettings::SSH_DSS_KEY => '', |
||
113 | PbxSettings::SSH_AUTHORIZED_KEYS => '', |
||
114 | PbxSettings::SSH_ECDSA_KEY => '', |
||
115 | PbxSettings::SSH_DISABLE_SSH_PASSWORD => '0', |
||
116 | PbxSettings::SSH_LANGUAGE => 'en', |
||
117 | PbxSettings::WEB_PORT => '80', |
||
118 | PbxSettings::WEB_HTTPS_PORT => '443', |
||
119 | PbxSettings::WEB_HTTPS_PUBLIC_KEY => '', |
||
120 | PbxSettings::WEB_HTTPS_PRIVATE_KEY => '', |
||
121 | PbxSettings::REDIRECT_TO_HTTPS => '0', |
||
122 | PbxSettings::MAIL_SMTP_USE_TLS => '0', |
||
123 | PbxSettings::MAIL_SMTP_CERT_CHECK => '0', |
||
124 | PbxSettings::MAIL_SMTP_HOST => '', |
||
125 | PbxSettings::MAIL_SMTP_PORT => '25', |
||
126 | PbxSettings::MAIL_SMTP_USERNAME => '', |
||
127 | PbxSettings::MAIL_SMTP_PASSWORD => '', |
||
128 | PbxSettings::MAIL_SMTP_FROM_USERNAME => 'PBX', |
||
129 | PbxSettings::MAIL_SMTP_SENDER_ADDRESS => '', |
||
130 | PbxSettings::MAIL_ENABLE_NOTIFICATIONS => '0', |
||
131 | PbxSettings::MAIL_TPL_MISSED_CALL_SUBJECT => 'You have missing call from <MailSMTPSenderAddress>', |
||
132 | PbxSettings::MAIL_TPL_MISSED_CALL_BODY => 'You have missed calls (NOTIFICATION_MISSEDCAUSE) from <NOTIFICATION_CALLERID> at <NOTIFICATION_DATE>', |
||
133 | PbxSettings::MAIL_TPL_MISSED_CALL_FOOTER => '', |
||
134 | PbxSettings::MAIL_TPL_VOICEMAIL_SUBJECT => 'VoiceMail from PBX', |
||
135 | PbxSettings::MAIL_TPL_VOICEMAIL_BODY => 'See attach', |
||
136 | PbxSettings::MAIL_TPL_VOICEMAIL_FOOTER => '', |
||
137 | PbxSettings::NTP_SERVER => '0.pool.ntp.org' . PHP_EOL . '1.pool.ntp.org' . PHP_EOL, |
||
138 | PbxSettings::VOICEMAIL_NOTIFICATIONS_EMAIL => '[email protected]', |
||
139 | PbxSettings::VOICEMAIL_EXTENSION => '*001', |
||
140 | PbxSettings::PBX_LANGUAGE => 'en-en', |
||
141 | PbxSettings::PBX_INTERNAL_EXTENSION_LENGTH => '3', |
||
142 | PbxSettings::PBX_RECORD_CALLS => '1', |
||
143 | PbxSettings::PBX_RECORD_CALLS_INNER => '1', |
||
144 | PbxSettings::PBX_SPLIT_AUDIO_THREAD => '0', |
||
145 | PbxSettings::PBX_RECORD_ANNOUNCEMENT_IN => '', |
||
146 | PbxSettings::PBX_RECORD_ANNOUNCEMENT_OUT => '', |
||
147 | PbxSettings::PBX_RECORD_SAVE_PERIOD => '', |
||
148 | PbxSettings::PBX_CALL_PARKING_EXT => '800', |
||
149 | PbxSettings::PBX_CALL_PARKING_FEATURE => '*2', |
||
150 | PbxSettings::PBX_CALL_PARKING_DURATION => '50', |
||
151 | PbxSettings::PBX_CALL_PARKING_START_SLOT => '801', |
||
152 | PbxSettings::PBX_CALL_PARKING_END_SLOT => '820', |
||
153 | PbxSettings::PBX_FEATURE_ATTENDED_TRANSFER => '##', |
||
154 | PbxSettings::PBX_FEATURE_BLIND_TRANSFER => '**', |
||
155 | PbxSettings::PBX_FEATURE_PICKUP_EXTEN => '*8', |
||
156 | PbxSettings::PBX_FEATURE_DIGIT_TIMEOUT => '2500', |
||
157 | PbxSettings::PBX_FEATURE_ATXFER_NO_ANSWER_TIMEOUT => '45', |
||
158 | PbxSettings::PBX_FEATURE_TRANSFER_DIGIT_TIMEOUT => '3', |
||
159 | PbxSettings::PBX_FIREWALL_ENABLED => '0', |
||
160 | PbxSettings::PBX_FAIL2BAN_ENABLED => '0', |
||
161 | PbxSettings::PBX_TIMEZONE => 'Europe/Moscow', |
||
162 | PbxSettings::PBX_MANUAL_TIME_SETTINGS => '0', |
||
163 | PbxSettings::PBX_VERSION => '2020.1.1', |
||
164 | PbxSettings::PBX_ALLOW_GUEST_CALLS => '0', |
||
165 | PbxSettings::WEB_ADMIN_LOGIN => 'admin', |
||
166 | PbxSettings::WEB_ADMIN_PASSWORD => 'admin', |
||
167 | PbxSettings::WEB_ADMIN_LANGUAGE => 'en', |
||
168 | PbxSettings::SYSTEM_NOTIFICATIONS_EMAIL => '', |
||
169 | PbxSettings::SYSTEM_EMAIL_FOR_MISSED => '', |
||
170 | PbxSettings::SEND_METRICS => '1', |
||
171 | PbxSettings::CLOUD_INSTANCE_ID => '', |
||
172 | PbxSettings::DISABLE_ALL_MODULES => '0', |
||
173 | PbxSettings::PBX_LICENSE => '', |
||
174 | PbxSettings::ENABLE_USE_NAT => '0', |
||
175 | PbxSettings::AUTO_UPDATE_EXTERNAL_IP => '0', |
||
176 | PbxSettings::EXTERNAL_SIP_HOST_NAME => '', |
||
177 | PbxSettings::EXTERNAL_SIP_IP_ADDR => '', |
||
178 | ]; |
||
284 |