| Conditions | 33 |
| Paths | 31 |
| Total Lines | 149 |
| Code Lines | 138 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 47 | public static function callBack(array $request): PBXApiResult |
||
| 48 | { |
||
| 49 | $action = $request['action']; |
||
| 50 | $data = $request['data']; |
||
| 51 | $res = new PBXApiResult(); |
||
| 52 | $res->processor = __METHOD__; |
||
| 53 | switch ($action) { |
||
| 54 | case 'reboot': |
||
| 55 | System::rebootSync(); |
||
| 56 | $res->success = true; |
||
| 57 | break; |
||
| 58 | case 'shutdown': |
||
| 59 | System::shutdown(); |
||
| 60 | $res->success = true; |
||
| 61 | break; |
||
| 62 | case 'mergeUploadedFile': |
||
| 63 | $phpPath = Util::which('php'); |
||
| 64 | $workerDownloaderPath = Util::getFilePathByClassName(WorkerMergeUploadedFile::class); |
||
| 65 | Util::mwExecBg("{$phpPath} -f {$workerDownloaderPath} '{$data['settings_file']}'"); |
||
| 66 | $res->success = true; |
||
| 67 | break; |
||
| 68 | case 'getDate': |
||
| 69 | $res->success = true; |
||
| 70 | $res->data['timestamp'] = time(); |
||
| 71 | break; |
||
| 72 | case 'setDate': |
||
| 73 | $res->success = System::setDate($data['timestamp'], $data['userTimeZone']); |
||
| 74 | break; |
||
| 75 | case 'updateCoreLanguage': |
||
| 76 | $di = Di::getDefault(); |
||
| 77 | $di->remove('messages'); |
||
| 78 | $di->remove('translation'); |
||
| 79 | $di->register(new MessagesProvider()); |
||
| 80 | $di->register(new TranslationProvider()); |
||
| 81 | break; |
||
| 82 | case 'updateMailSettings': |
||
| 83 | // TODO: |
||
| 84 | $res->success = true; |
||
| 85 | break; |
||
| 86 | case 'sendMail': |
||
| 87 | if (isset($data['email']) && isset($data['subject']) && isset($data['body'])) { |
||
| 88 | if (isset($data['encode']) && $data['encode'] === 'base64') { |
||
| 89 | $data['subject'] = base64_decode($data['subject']); |
||
| 90 | $data['body'] = base64_decode($data['body']); |
||
| 91 | } |
||
| 92 | $result = Notifications::sendMail($data['email'], $data['subject'], $data['body']); |
||
| 93 | if ($result === true) { |
||
| 94 | $res->success = true; |
||
| 95 | } else { |
||
| 96 | $res->success = false; |
||
| 97 | $res->messages[] = $result; |
||
| 98 | } |
||
| 99 | } else { |
||
| 100 | $res->success = false; |
||
| 101 | $res->messages[] = 'Not all query parameters are set'; |
||
| 102 | } |
||
| 103 | break; |
||
| 104 | case 'fileReadContent': |
||
| 105 | $res = FilesManagementProcessor::fileReadContent($data['filename'], $data['needOriginal']); |
||
| 106 | break; |
||
| 107 | case 'reloadMsmtp': |
||
| 108 | $notifications = new Notifications(); |
||
| 109 | $notifications->configure(); |
||
| 110 | $voiceMailConfig = new VoiceMailConf(); |
||
| 111 | $voiceMailConfig->generateConfig(); |
||
| 112 | $asteriskPath = Util::which('asterisk'); |
||
| 113 | Util::mwExec("{$asteriskPath} -rx 'voicemail reload'"); |
||
| 114 | $res->success = true; |
||
| 115 | break; |
||
| 116 | case 'unBanIp': |
||
| 117 | $res = FirewallManagementProcessor::fail2banUnbanAll($data['ip']); |
||
| 118 | break; |
||
| 119 | case 'getBanIp': |
||
| 120 | $res = FirewallManagementProcessor::getBanIp(); |
||
| 121 | break; |
||
| 122 | case 'downloadNewFirmware': |
||
| 123 | $res = FilesManagementProcessor::downloadNewFirmware($request['data']); |
||
| 124 | break; |
||
| 125 | case 'firmwareDownloadStatus': |
||
| 126 | $res = FilesManagementProcessor::firmwareDownloadStatus(); |
||
| 127 | break; |
||
| 128 | case 'upgrade': |
||
| 129 | $res = SystemManagementProcessor::upgradeFromImg($data['temp_filename']); |
||
| 130 | break; |
||
| 131 | case 'removeAudioFile': |
||
| 132 | $res = FilesManagementProcessor::removeAudioFile($data['filename']); |
||
| 133 | break; |
||
| 134 | case 'convertAudioFile': |
||
| 135 | $mvPath = Util::which('mv'); |
||
| 136 | Util::mwExec("{$mvPath} {$data['temp_filename']} {$data['filename']}"); |
||
| 137 | $res = FilesManagementProcessor::convertAudioFile($data['filename']); |
||
| 138 | break; |
||
| 139 | case 'downloadNewModule': |
||
| 140 | $module = $request['data']['uniqid']; |
||
| 141 | $url = $request['data']['url']; |
||
| 142 | $md5 = $request['data']['md5']; |
||
| 143 | $res = FilesManagementProcessor::moduleStartDownload($module, $url, $md5); |
||
| 144 | break; |
||
| 145 | case 'moduleDownloadStatus': |
||
| 146 | $module = $request['data']['uniqid']; |
||
| 147 | $res = FilesManagementProcessor::moduleDownloadStatus($module); |
||
| 148 | break; |
||
| 149 | case 'installNewModule': |
||
| 150 | $filePath = $request['data']['filePath']; |
||
| 151 | $res = FilesManagementProcessor::installModuleFromFile($filePath); |
||
| 152 | break; |
||
| 153 | case 'enableModule': |
||
| 154 | $moduleUniqueID = $request['data']['uniqid']; |
||
| 155 | $moduleStateProcessor = new PbxExtensionState($moduleUniqueID); |
||
| 156 | if ($moduleStateProcessor->enableModule() === false) { |
||
| 157 | $res->success = false; |
||
| 158 | $res->messages = $moduleStateProcessor->getMessages(); |
||
| 159 | } else { |
||
| 160 | PBXConfModulesProvider::recreateModulesProvider(); |
||
| 161 | $res->data = $moduleStateProcessor->getMessages(); |
||
| 162 | $res->data['needRestartWorkers'] = true; //TODO:: Проверить надо ли это |
||
| 163 | $res->success = true; |
||
| 164 | } |
||
| 165 | break; |
||
| 166 | case 'disableModule': |
||
| 167 | $moduleUniqueID = $request['data']['uniqid']; |
||
| 168 | $moduleStateProcessor = new PbxExtensionState($moduleUniqueID); |
||
| 169 | if ($moduleStateProcessor->disableModule() === false) { |
||
| 170 | $res->success = false; |
||
| 171 | $res->messages = $moduleStateProcessor->getMessages(); |
||
| 172 | } else { |
||
| 173 | PBXConfModulesProvider::recreateModulesProvider(); |
||
| 174 | $res->data = $moduleStateProcessor->getMessages(); |
||
| 175 | $res->data['needRestartWorkers'] = true; //TODO:: Проверить надо ли это |
||
| 176 | $res->success = true; |
||
| 177 | } |
||
| 178 | break; |
||
| 179 | case 'uninstallModule': |
||
| 180 | $moduleUniqueID = $request['data']['uniqid']; |
||
| 181 | $keepSettings = $request['data']['keepSettings'] === 'true'; |
||
| 182 | $res = FilesManagementProcessor::uninstallModule($moduleUniqueID, $keepSettings); |
||
| 183 | break; |
||
| 184 | case 'restoreDefault': |
||
| 185 | $res = self::restoreDefaultSettings(); |
||
| 186 | break; |
||
| 187 | default: |
||
| 188 | $res = new PBXApiResult(); |
||
| 189 | $res->processor = __METHOD__; |
||
| 190 | $res->messages[] = "Unknown action - {$action} in systemCallBack"; |
||
| 191 | } |
||
| 192 | |||
| 193 | $res->function = $action; |
||
| 194 | |||
| 195 | return $res; |
||
| 196 | } |
||
| 357 | } |