mikopbx /
Core
| Conditions | 14 |
| Paths | 272 |
| Total Lines | 66 |
| Code Lines | 49 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 42 | public static function execute(WorkerCallEvents $worker, array $data): void |
||
| 43 | { |
||
| 44 | $extra = json_decode($data['Extra'], true); |
||
| 45 | $am = Util::getAstManager('off'); |
||
| 46 | if(stripos($extra['transferee_channel_name'],'local') === 0){ |
||
| 47 | $chanTarget = $am->GetVar($extra['transferee_channel_name'],'ATTENDEDTRANSFER', '' ,false); |
||
| 48 | }else{ |
||
| 49 | $chanTarget = $extra['transferee_channel_name']; |
||
| 50 | } |
||
| 51 | $chanId1 = $worker->getActiveChanId($extra['channel2_name']); |
||
| 52 | $chanId2 = $worker->getActiveChanId($chanTarget); |
||
| 53 | |||
| 54 | if($chanId1 !== $chanId2){ |
||
| 55 | $filter = [ |
||
| 56 | 'linkedid=:linkedid1: OR linkedid=:linkedid2:', |
||
| 57 | 'bind' => [ |
||
| 58 | 'linkedid1' => $chanId1, |
||
| 59 | 'linkedid2' => $chanId2, |
||
| 60 | ], |
||
| 61 | ]; |
||
| 62 | $n_data['action'] = 'sip_transfer'; |
||
|
Comprehensibility
Best Practice
introduced
by
|
|||
| 63 | /** @var CallDetailRecordsTmp $row */ |
||
| 64 | $m_data = CallDetailRecordsTmp::find($filter); |
||
| 65 | foreach ($m_data as $row){ |
||
| 66 | if(empty($row->endtime)){ |
||
| 67 | if(in_array($row->src_chan, [$extra['channel2_name'], $data['Channel']], true)) { |
||
| 68 | $n_data['dst_chan'] = $row->dst_chan; |
||
| 69 | $n_data['dst_num'] = $row->dst_num; |
||
| 70 | $n_data['did'] = $row->did; |
||
| 71 | $worker->StopMixMonitor($n_data['dst_chan']); |
||
| 72 | }elseif(in_array($row->dst_chan, [$extra['channel2_name'], $data['Channel']], true)){ |
||
| 73 | $n_data['src_chan'] = $row->src_chan; |
||
| 74 | $n_data['src_num'] = $row->src_num; |
||
| 75 | $n_data['did'] = $row->did; |
||
| 76 | $worker->StopMixMonitor($n_data['src_chan']); |
||
| 77 | } |
||
| 78 | } |
||
| 79 | } |
||
| 80 | $m_data = CallDetailRecordsTmp::find($filter); |
||
| 81 | foreach ($m_data as $row) { |
||
| 82 | // Set new linked ID. |
||
| 83 | if($row->linkedid !== $chanId2){ |
||
| 84 | $row->writeAttribute('linkedid', $chanId2); |
||
| 85 | } |
||
| 86 | if(empty($row->endtime)){ |
||
| 87 | if(in_array($row->src_chan, [$extra['channel2_name'], $data['Channel']], true)) { |
||
| 88 | $row->writeAttribute('endtime', date('Y-m-d H:i:s')); |
||
| 89 | }elseif(in_array($row->dst_chan, [$extra['channel2_name'], $data['Channel']], true)){ |
||
| 90 | $row->writeAttribute('endtime', date('Y-m-d H:i:s')); |
||
| 91 | } |
||
| 92 | } |
||
| 93 | $row->save(); |
||
| 94 | } |
||
| 95 | $n_data['start'] = date('Y-m-d H:i:s'); |
||
| 96 | $n_data['answer'] = date('Y-m-d H:i:s'); |
||
| 97 | $n_data['linkedid'] = $chanId2; |
||
| 98 | $n_data['UNIQUEID'] = $chanId2 . Util::generateRandomString(); |
||
| 99 | $n_data['transfer'] = '0'; |
||
| 100 | if(isset($n_data['dst_chan'], $n_data['src_chan'])){ |
||
| 101 | if ($worker->enableMonitor($n_data['src_num'] ?? '', $n_data['dst_num'] ?? '')) { |
||
| 102 | $n_data['recordingfile'] = $worker->MixMonitor($n_data['dst_chan'], $n_data['UNIQUEID'], '', '', 'hangupChanCheckSipAttTrtansfer'); |
||
| 103 | } |
||
| 104 | InsertDataToDB::execute($n_data); |
||
| 105 | // Sending UserEvent |
||
| 106 | $AgiData = base64_encode(json_encode($n_data)); |
||
| 107 | $am->UserEvent('CdrConnector', ['AgiData' => $AgiData]); |
||
| 108 | } |
||
| 111 | } |
Loading history...