MikoPBX\Core\System\Upgrade\Releases\UpdateConfigsUpToVer2022020103

Complexity

Total Complexity

19

Size/Duplication

Total Lines	122
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	addNewCodecs()	0	19	5
B	updateFirewallRules()	0	49	9
A	processUpdate()	0	7	2
A	__construct()	0	3	1
A	updateCodecs()	0	11	2

<?php
/*
 * MikoPBX - free phone system for small business
 * Copyright (C) 2017-2020 Alexey Portnov and Nikolay Beketov
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License along with this program.
 * If not, see <https://www.gnu.org/licenses/>.
 */

namespace MikoPBX\Core\System\Upgrade\Releases;

use MikoPBX\Common\Models\Codecs;
use MikoPBX\Common\Models\FirewallRules;
use MikoPBX\Common\Models\NetworkFilters;
use MikoPBX\Common\Models\PbxSettings;
use MikoPBX\Common\Models\Sip;
use MikoPBX\Core\System\Upgrade\UpgradeSystemConfigInterface;
use MikoPBX\Core\System\Util;
use Phalcon\Di\Injectable;

class UpdateConfigsUpToVer2022020103 extends Injectable implements UpgradeSystemConfigInterface
{
  	public const PBX_VERSION = '2022.2.103';
    private bool $isLiveCD;

	/**
     * Class constructor.
     */
    public function __construct()
    {
        $this->isLiveCD      = file_exists('/offload/livecd');
    }

    /**
     * https://github.com/mikopbx/Core/issues/269
     */
    public function processUpdate():void
    {
        if ($this->isLiveCD) {
            return;
        }
        $this->updateFirewallRules();
        $this->updateCodecs();
    }

    /**
     * Обновление TLS порта для сетевого экрана.
     * @return void
     */
    private function updateFirewallRules():void{
        $colName = 'TLS_PORT';
        $portTls = PbxSettings::getValueByKey('TLS_PORT');

        /** @var NetworkFilters $net */
        $nets = NetworkFilters::find(['columns' => 'id']);
        foreach ($nets as $net){
            $ruleTls = FirewallRules::findFirst([
                                                    "portFromKey='$colName' AND networkfilterid='$net->id'",
                                                    'columns' => 'id']
            );
            if($ruleTls){
                continue;
            }
            $rules   = FirewallRules::findFirst([
                                                    "portFromKey='SIPPort' AND networkfilterid='$net->id'",
                                                    'columns' => 'action,networkfilterid,category,description']
            );
            if(!$rules){
                continue;
            }

            $ruleTls = FirewallRules::findFirst(["portFromKey='$colName' AND networkfilterid='$net->id'"]);
            if($ruleTls){
                continue;
            }
            $ruleTls = new FirewallRules();
            foreach ($rules->toArray() as $key => $value){
                $ruleTls->$key = $value;
            }
            $ruleTls->portfrom    = $portTls;

It seems like $portTls of type string is incompatible with the declared type integer|null of property $portfrom.

            $ruleTls->portto      = $portTls;

It seems like $portTls of type string is incompatible with the declared type integer|null of property $portto.

            $ruleTls->protocol    = 'tcp';
            $ruleTls->portFromKey = $colName;
            $ruleTls->portToKey   = $colName;
            $ruleTls->save();
        }

        $db_data = Sip::find("type = 'friend' AND ( disabled <> '1')");
        foreach ($db_data as $sip_peer) {
            if(!empty($sip_peer->registration_type)){
                continue;
            }
            if($sip_peer->noregister === '0'){
                $sip_peer->registration_type = Sip::REG_TYPE_OUTBOUND;
            }else{
                $sip_peer->registration_type = Sip::REG_TYPE_NONE;
            }
            $sip_peer->save();
        }
    }

    /**
     * Update codecs.
     */
    private function updateCodecs():void
    {
        $availCodecs = [
            'g729'  => 'G.729',
        ];
        $this->addNewCodecs($availCodecs);

        /** @var Codecs $codecForRemove */
        $codecForRemove = Codecs::findFirst("name='g719'");
        if($codecForRemove){

$codecForRemove is of type MikoPBX\Common\Models\Codecs, thus it always evaluated to true.

            $codecForRemove->delete();
        }
    }

    /**
     * Adds new codecs from $availCodecs array if it doesn't exist
     *
     * @param array $availCodecs
     */
    private function addNewCodecs(array $availCodecs): void
    {
        foreach ($availCodecs as $availCodec => $desc) {
            $codecData = Codecs::findFirst('name="' . $availCodec . '"');
            if ($codecData === null) {
                $codecData = new Codecs();
            } elseif ($codecData->description === $desc) {
                unset($codecData);
                continue;
            }
            $codecData->name = $availCodec;
            $codecData->type        = 'audio';
            $codecData->disabled    = '1';
            $codecData->description = $desc;
            if ( ! $codecData->save()) {
                Util::sysLogMsg(
                    __CLASS__,
                    'Can not update codec info ' . $codecData->name . ' from \MikoPBX\Common\Models\Codecs',
                    LOG_ERR
                );
            }
        }
    }
}