Conditions | 33 |
Paths | 12984 |
Total Lines | 118 |
Code Lines | 79 |
Lines | 0 |
Ratio | 0 % |
Changes | 2 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
87 | private function updateCdr(): void |
||
88 | { |
||
89 | $this->initSettings(); |
||
90 | $result_data = $this->client_queue->getBody(); |
||
91 | // Получаем результат. |
||
92 | $result = json_decode($result_data, true); |
||
93 | if (file_exists($result)) { |
||
94 | $file_data = json_decode(file_get_contents($result), true); |
||
95 | if(!is_dir($result)){ |
||
96 | Util::mwExec("rm -rf {$result}"); |
||
97 | } |
||
98 | $result = $file_data; |
||
99 | } |
||
100 | if ( ! is_array($result) && ! is_object($result)) { |
||
101 | return; |
||
102 | } |
||
103 | if (count($result) < 1) { |
||
104 | return; |
||
105 | } |
||
106 | $arr_update_cdr = []; |
||
107 | // Получаем идентификаторы активных каналов. |
||
108 | $channels_id = $this->getActiveIdChannels(); |
||
109 | foreach ($result as $row) { |
||
110 | if (array_key_exists($row['linkedid'], $channels_id)) { |
||
111 | // Цепочка вызовов еще не завершена. |
||
112 | continue; |
||
113 | } |
||
114 | if (trim($row['recordingfile']) !== '') { |
||
115 | // Если каналов не существует с ID, то можно удалить временные файлы. |
||
116 | $p_info = pathinfo($row['recordingfile']); |
||
117 | $fname = $p_info['dirname'] . '/' . $p_info['filename'] . '.wav'; |
||
118 | if (file_exists($fname) && !is_dir($fname)) { |
||
119 | Util::mwExec("rm -rf {$fname}"); |
||
120 | } |
||
121 | } |
||
122 | $start = strtotime($row['start']); |
||
123 | $answer = strtotime($row['answer']); |
||
124 | $end = strtotime($row['endtime']); |
||
125 | $dialstatus = trim($row['dialstatus']); |
||
126 | |||
127 | $duration = max(($end - $start), 0); |
||
128 | $billsec = ($end != 0 && $answer != 0) ? ($end - $answer) : 0; |
||
129 | |||
130 | $disposition = 'NOANSWER'; |
||
131 | if ($billsec > 0) { |
||
132 | $disposition = 'ANSWERED'; |
||
133 | } elseif ('' !== $dialstatus) { |
||
134 | $disposition = ($dialstatus === 'ANSWERED') ? $disposition : $dialstatus; |
||
135 | } |
||
136 | |||
137 | if ($billsec <= 0) { |
||
138 | $row['answer'] = ''; |
||
139 | $billsec = 0; |
||
140 | |||
141 | if ( ! empty($row['recordingfile'])) { |
||
142 | $p_info = pathinfo($row['recordingfile']); |
||
143 | $file_list = [ |
||
144 | $p_info['dirname'] . '/' . $p_info['filename'] . '.mp3', |
||
145 | $p_info['dirname'] . '/' . $p_info['filename'] . '.wav', |
||
146 | $p_info['dirname'] . '/' . $p_info['filename'] . '_in.wav', |
||
147 | $p_info['dirname'] . '/' . $p_info['filename'] . '_out.wav', |
||
148 | ]; |
||
149 | foreach ($file_list as $file) { |
||
150 | if ( ! file_exists($file)) { |
||
151 | continue; |
||
152 | } |
||
153 | if(!is_dir($file)){ |
||
154 | Util::mwExec("rm -rf {$file}"); |
||
155 | } |
||
156 | } |
||
157 | } |
||
158 | } |
||
159 | |||
160 | if ($disposition !== 'ANSWERED') { |
||
161 | if (file_exists($row['recordingfile']) && !is_dir($row['recordingfile'])) { |
||
162 | Util::mwExec("rm -rf {$row['recordingfile']}"); |
||
163 | } |
||
164 | } elseif ( ! empty($row['recordingfile']) && |
||
165 | ! file_exists(Util::trimExtensionForFile($row['recordingfile']) . 'wav') && |
||
166 | ! file_exists( $row['recordingfile']) ) { |
||
167 | /** @var CallDetailRecordsTmp $rec_data */ |
||
168 | $rec_data = CallDetailRecordsTmp::findFirst( |
||
169 | "linkedid='{$row['linkedid']}' AND dst_chan='{$row['dst_chan']}'" |
||
170 | ); |
||
171 | if ($rec_data !== null) { |
||
172 | $row['recordingfile'] = $rec_data->recordingfile; |
||
173 | } |
||
174 | } |
||
175 | |||
176 | $data = [ |
||
177 | 'work_completed' => 1, |
||
178 | 'duration' => $duration, |
||
179 | 'billsec' => $billsec, |
||
180 | 'disposition' => $disposition, |
||
181 | 'UNIQUEID' => $row['UNIQUEID'], |
||
182 | 'recordingfile' => ($disposition === 'ANSWERED') ? $row['recordingfile'] : '', |
||
183 | 'tmp_linked_id' => $row['linkedid'], |
||
184 | ]; |
||
185 | |||
186 | $arr_update_cdr[] = $data; |
||
187 | $this->checkNoAnswerCall(array_merge($row, $data)); |
||
188 | } |
||
189 | |||
190 | foreach ($arr_update_cdr as $data) { |
||
191 | $linkedid = $data['tmp_linked_id']; |
||
192 | $data['GLOBAL_STATUS'] = $data['disposition']; |
||
193 | if (isset($this->no_answered_calls[$linkedid]) && |
||
194 | isset($this->no_answered_calls[$linkedid]['NOANSWER']) && |
||
195 | $this->no_answered_calls[$linkedid]['NOANSWER'] == false) { |
||
196 | $data['GLOBAL_STATUS'] = 'ANSWERED'; |
||
197 | // Это отвеченный вызов (на очередь). Удаляем из списка. |
||
198 | unset($this->no_answered_calls[$linkedid]); |
||
199 | } |
||
200 | unset($data['tmp_linked_id']); |
||
201 | $this->client_queue->publish(json_encode($data), null, self::UPDATE_CDR_TUBE); |
||
202 | } |
||
203 | |||
204 | $this->notifyByEmail(); |
||
205 | } |
||
280 | } |