Issues in class-metabox-values.php (master) - Issues in master - mikeselander/dummybot - Measure and Improve Code Quality continuously with Scrutinizer

Issues (87)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/class-metabox-values.php (39 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace DummyPress;

/**
 * Class for handling CMB data
 *
 * @package    WordPress
 * @subpackage Evans
 * @author     Mike Selander
 */
class MetaboxValues {

	/**
	 * Assigns the proper testing data to a custom metabox.
	 *
	 * Swaps through the possible types of CMB2 supported fields and
	 * insert the appropriate data based on type & id.
	 * Some types are not yet supported due to low frequency of use.
	 *
	 * @see TestContent, add_post_meta
	 *
	 * @param int $post_id Single post ID.
	 * @param array $cmb custom metabox array from CMB2.
	 */
	public function get_values( $post_id, $cmb, $connected ) {

		$value = '';

		// First check that our post ID & cmb array aren't empty
		if ( empty( $cmb ) || empty( $post_id ) || ! is_user_logged_in() ) {
			return;
		}

		// Fetch the appropriate type of data and return
		switch( $cmb['type'] ) {

			case 'text':
			case 'text_small':
			case 'text_medium':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->text( $cmb );

				break;

			case 'text_url':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->url( $cmb );

				break;

			case 'text_email' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
			case 'email':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->email( $cmb );

				break;

			case 'number' :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
			case 'text_money':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->number( $cmb );

				break;

			case 'text_time':
			case 'time':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->time( $cmb );

				break;

			case 'select_timezone':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->timezone( $cmb );

				break;

			case 'text_date':
			case 'date':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->date( $cmb );

				break;

			case 'text_date_timestamp':
			case 'text_datetime_timestamp':
			case 'date_unix':
			case 'datetime_unix':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->timestamp( $cmb );

				break;

			// case 'text_datetime_timestamp_timezone': break;


			case 'test_colorpicker':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->color( $cmb );

				break;

			case 'textarea':
			case 'textarea_small':
			case 'textarea_code':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->textarea( $cmb );

				break;

			case 'select':
			case 'radio_inline':
			case 'radio':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->radio( $cmb );

				break;

			// case 'taxonomy_radio': break;

			// case 'taxonomy_select': break;

			// case 'taxonomy_multicheck': break;


			case 'checkbox':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				if ( isset( $cmb['source'] ) && 'acf' === $cmb['source'] ) {
					$value = $this->multicheck( $cmb );
				} else {
					$value = $this->checkbox( $cmb );
				}

				break;

			case 'multicheck':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->multicheck( $cmb );

				break;

			case 'wysiwyg':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->wysiwyg( $cmb );

				break;

			case 'file':
			case 'image':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->file( $cmb, $post_id, $connected );

				break;

			// case 'file_list': break;


			case 'oembed':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

				$value = $this->oembed( $cmb );

				break;

		}

		// Value must exist to attempt to insert
		if ( ! empty( $value ) && ! is_wp_error( $value ) ) {

			$this->update_meta( $post_id, $value, $cmb );

		// If we're dealing with a WP Error object, just return the message for debugging
		} elseif ( is_wp_error( $value ) ) {

			return $value->get_error_message();

		}

	} // end get_values


	/**
	 * Pulls a text string for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function text( $cmb ) {

		// If phone is in the id, fetch a phone #
		if ( stripos( $cmb['id'], 'phone' ) ) {
			$value = TestContent::phone();

		// If email is in the id, fetch an email address
		} elseif ( stripos( $cmb['id'], 'email' ) ) {
			$value = TestContent::email();

		// If time is in the id, fetch a time string
		} elseif ( stripos( $cmb['id'], 'time' ) ) {
			$value = TestContent::time();

		// If company|organization is in the ID, fetch a company name
		} elseif ( stripos( $cmb['id'], 'company' ) || stripos( $cmb['id'], 'organization' ) ) {
			$value = TestContent::organization();

		// Otherwise, just a random text string
		} else {
			$value = TestContent::title( rand( 10, 50 ) );
		}

		if ( 'acf' === $cmb['source'] && ! empty( $cmb['extras']->chars ) ) {

			$value = substr( $value, 0, $cmb['extras']->chars );
		}

		return $value;

	}


	/**
	 * Pulls a URL value CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function url( $cmb ) {


		return TestContent::link();

	}


	/**
	 * Pulls an email address for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function email( $cmb ) {


		return TestContent::email();

	}


	/**
	 * Pulls a random valnumberue for CMB field.
	 *
	 * @param array $cmb Metabox data
	 * @return int cmb value
	 */
	private function number( $cmb ) {

		$min = 1;
		$max = 10000000;

		if ( 'acf' == $cmb['source'] && ! empty( $cmb['extras']->min ) ) {

			$min = $cmb['extras']->min;
		}

		if ( 'acf' == $cmb['source'] && ! empty( $cmb['extras']->max ) ) {

			$max = $cmb['extras']->max;
		}

		return rand( $min, $max );

	}


	/**
	 * Pulls a time of day for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function time( $cmb ) {


		return TestContent::time();

	}


	/**
	 * Pulls a timezone for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function timezone( $cmb ) {


		return TestContent::timezone();

	}


	/**
	 * Pulls a date for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function date( $cmb ) {


		return TestContent::date( 'm/d/Y' );

	}


	/**
	 * Pulls a timestamp for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function timestamp( $cmb ) {


		return TestContent::date( 'U' );

	}


	/**
	 * Pulls a random hexadecimal color code for CMB field.
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function color( $cmb ) {


		return '#' . str_pad( dechex( mt_rand( 0, 0xFFFFFF ) ), 6, '0', STR_PAD_LEFT );

	}


	/**
	 * Pulls a long text string for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function textarea( $cmb ) {

		$value = TestContent::plain_text();

		if ( 'acf' == $cmb['source'] && ! empty( $cmb['extras']->chars ) ) {

			$value = substr( $value, 0,  $cmb['extras']->chars );
		}

		return $value;

	}


	/**
	 * Pulls a random radio field value for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function radio( $cmb ) {

		// Grab a random item out of the array and return the key
		$new_val = array_slice( $cmb['options'], rand( 0, count( $cmb['options'] ) ), 1 );
		$value = key( $new_val );

		return $value;

	}


	/**
	 * Pulls a random checkbox field value for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function checkbox( $cmb ) {

		$value = '';

		// 50/50 odds of being turned on
		if ( rand( 0, 1 ) == 1 ) {
			$value = 'on';
		}

		return $value;

	}


	/**
	 * Pulls a random multicheck field value for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return array cmb value
	 */
	private function multicheck( $cmb ) {

		$new_option = array();

		// Loop through each of our options
		foreach ( $cmb['options'] as $key => $value ) {

			// 50/50 chance of being included
			if ( rand( 0, 1 ) ) {
				$new_option[] = $key;
			}

		}

		return $new_option;

	}


	/**
	 * Pulls an HTML paragraph string for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function wysiwyg( $cmb ) {


		return TestContent::paragraphs();

	}


	/**
	 * Pulls an image URL for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @param int $post_id Post ID
	 * @param bool $connected Whether we're connected to the Internets or not
	 * @return mixed string|object cmb value or WP_Error object
	 */
	private function file( $cmb, $post_id, $connected ) {

		$value = '';

		if ( true === $connected ) {
			$value = TestContent::image( $post_id );
		}

		return $value;

	}


	/**
	 * Pulls an Oembed URL for CMB field.
	 *
	 * @see TestContent
	 *
	 * @param array $cmb Metabox data
	 * @return string cmb value
	 */
	private function oembed( $cmb ) {


		return TestContent::oembed();

	}


	/**
	 * Update the metabox with new data.
	 *
	 * @access private
	 *
	 * @see add_post_meta
	 *
	 * @param int $post_id Post ID.
	 * @param string $value Value to add into the database.
	 * @param array $cmb SMB data.
	 */
	private function update_meta( $post_id, $value, $cmb ) {

		$type 	= $cmb['type'];
		$id		= $cmb['id'];
		$value = apply_filters( "tc_{$type}_metabox", $value );	// Filter by metabox type
		$value = apply_filters( "tc_{$id}_metabox", $value ); // Filter by metabox ID

		// Files must be treated separately - they use the attachment ID
		// & url of media for separate cmb values. (only in cmb1 & cmb2 though)
		if ( 'file'!== $cmb['type'] || ( 'file' === $cmb['type'] && 'cmb_hm' === $cmb['source'] ) ) {
			add_post_meta( $post_id, $cmb['id'], $value, true );
		} else {
			add_post_meta( $post_id, $cmb['id'].'_id', $value, true );
			add_post_meta( $post_id, $cmb['id'], wp_get_attachment_url( $value ), true );
		}

		// Add extra, redundant meta. Because, why not have two rows for the price of one?
		if ( isset( $cmb['source'] ) && 'acf' === $cmb['source'] ) {
			add_post_meta( $post_id, '_' . $cmb['id'], $cmb['key'], true );
		}

	}

}


1			<?php
2			namespace DummyPress;
3
4			/**
5			* Class for handling CMB data
6			*
7			* @package WordPress
8			* @subpackage Evans
9			* @author Mike Selander
10			*/
11			class MetaboxValues {
12
13			/**
14			* Assigns the proper testing data to a custom metabox.
15			*
16			* Swaps through the possible types of CMB2 supported fields and
17			* insert the appropriate data based on type & id.
18			* Some types are not yet supported due to low frequency of use.
19			*
20			* @see TestContent, add_post_meta
21			*
22			* @param int $post_id Single post ID.
23			* @param array $cmb custom metabox array from CMB2.
24			*/
25			public function get_values( $post_id, $cmb, $connected ) {
			0 ignored issues – show Documentation introduced 2016-09-03 10:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
26			$value = '';
27
28			// First check that our post ID & cmb array aren't empty
29			if ( empty( $cmb ) \|\| empty( $post_id ) \|\| ! is_user_logged_in() ) {
30			return;
31			}
32
33			// Fetch the appropriate type of data and return
34			switch( $cmb['type'] ) {
35
36			case 'text':
37			case 'text_small':
38			case 'text_medium':
			0 ignored issues – show Coding Style introduced 2016-09-03 10:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...

mikeselander / dummybot

Issues (87)

Security Analysis not enabled

includes/class-metabox-values.php (39 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like