Completed
Push — master ( 69c2fc...6a5424 )
by Mike
04:04
created

DoctrineTransactionFactory   A

Complexity

Total Complexity 1

Size/Duplication

Total Lines 10
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 2

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 1
c 1
b 0
f 0
lcom 0
cbo 2
dl 0
loc 10
rs 10

1 Method

Rating   Name   Duplication   Size   Complexity  
A createService() 0 7 1
1
<?php
2
namespace TacticianModule\Factory\Plugin;
3
4
use League\Tactician\Doctrine\ORM\TransactionMiddleware;
5
use Zend\ServiceManager\FactoryInterface;
6
use Zend\ServiceManager\ServiceLocatorInterface;
7
8
class DoctrineTransactionFactory implements FactoryInterface
9
{
10
    public function createService(ServiceLocatorInterface $serviceLocator)
11
    {
12
        $config = $serviceLocator->get('config')['tactician']['plugins'];
13
        $ormKey = $config[TransactionMiddleware::class];
14
        
15
        return new TransactionMiddleware($serviceLocator->get($ormKey));
0 ignored issues
show
Documentation introduced by
$serviceLocator->get($ormKey) is of type object|array, but the function expects a object<Doctrine\ORM\EntityManagerInterface>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
16
    }
17
}