Mikemirten\Component\JsonApi\HttpClient\Adapter\GuzzleAdapter

Complexity

Total Complexity

5

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	request()	0	9	2
A	createException()	0	15	2

<?php
declare(strict_types = 1);

namespace Mikemirten\Component\JsonApi\HttpClient\Adapter;

use GuzzleHttp\ClientInterface as GuzzleClientInterface;
use GuzzleHttp\Exception\RequestException as GuzzleRequestException;
use GuzzleHttp\Exception\BadResponseException as GuzzleResponseException;
use Mikemirten\Component\JsonApi\HttpClient\Exception\RequestException;
use Mikemirten\Component\JsonApi\HttpClient\Exception\ResponseException;
use Mikemirten\Component\JsonApi\HttpClient\HttpClientInterface;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * Guzzle HTTP Client adapter
 *
 * @package Mikemirten\Component\JsonApi\HttpClient
 */
class GuzzleAdapter implements HttpClientInterface
{
    /**
     * @var GuzzleClientInterface
     */
    protected $client;

    /**
     * GuzzleAdapter constructor.
     *
     * @param GuzzleClientInterface $client
     */
    public function __construct(GuzzleClientInterface $client)
    {
        $this->client = $client;
    }

    /**
     * {@inheritdoc}
     */
    public function request(RequestInterface $request): ResponseInterface
    {
        try {
            return $this->client->send($request);
        }
        catch (GuzzleRequestException $exception) {
            throw $this->createException($exception);
        }
    }

    /**
     * Create HTTP-Client RequestException by a Guzzle exception
     *
     * @param  GuzzleRequestException $exception
     * @return RequestException
     */
    protected function createException(GuzzleRequestException $exception): RequestException
    {
        if ($exception instanceof GuzzleResponseException) {
            return new ResponseException(
                $exception->getRequest(),
                $exception->getResponse(),

It seems like $exception->getResponse() can be null; however, __construct() does not accept null, maybe add an additional type check?

                $exception
            );
        }

        throw new RequestException(
            $exception->getRequest(),
            $exception
        );
    }
}