blacklistmonitor.php ➔ monitorProcessWatch() - Code Metrics - Inspection of "Update README.md" - mikelynn2/blacklistmonitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2c70cc...15bbb1 )

by mike

created 2016-05-23 15:34 UTC

blacklistmonitor.php ➔ monitorProcessWatch() C

↳ Parent: Project

Complexity

Conditions	10
Paths	50

Size

Total Lines	64
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	10
eloc	34
nc	50
nop	1
dl	0
loc	64
rs	6.309

How to fix Long Method Complexity

#!/bin/php
<?php

//prevent non cli access
if(php_sapi_name()!=='cli') exit();

$dir = dirname(dirname(__FILE__));
class_exists('Setup', false) or include($dir.'/classes/Setup.class.php');
class_exists('Utilities', false) or include($dir.'/classes/Utilities.class.php');
class_exists('_MySQL', false) or include($dir.'/classes/_MySQL.class.php');
class_exists('_MeasurePerformance', false) or include($dir.'/classes/_MeasurePerformance.class.php');

$options = getopt("p:i:");
$processType = isset($options['p']) ? $options['p'] : 'main';
$parentProcessId = isset($options['i']) ? (int)$options['i'] : 0;


switch ($processType) {
	case 'main';
		main();
		break;
	case 'monitorProcessWatch';
		monitorProcessWatch($parentProcessId);
		break;
	default:
		_Logging::appLog("Invalid process requested in main script");
		exit();
		break;
}


function main(){
	// start process watch
	$parentProcessId = getmypid();
	if($parentProcessId == false || $parentProcessId == 0) {

		_Logging::appLog("Parent process couldnt get pid");
	}

	$userProcessId = 0;
	$monitorProcessesId = 0;

	$mysql = new _MySQL();

	// control
	while (true) {
		try{
			$mysql->connect(Setup::$connectionArray);
			if(!Utilities::is_process_running($userProcessId)){
				$userCheck = $mysql->runQueryReturnVar("select username from users where beenChecked = 0");
				if($userCheck!==false){
					$cmd = 'php '.dirname(__FILE__).'/userJob.php -i '.$parentProcessId;
					$userProcessId = Utilities::run_in_background($cmd);
				}
			}
		} catch (Exception $e) {
			_Logging::appLog($e->getMessage());
		}
		if(!Utilities::is_process_running($monitorProcessesId)){
			$cmd = 'php '.dirname(__FILE__).'/blacklistmonitor.php -p monitorProcessWatch -i '.$parentProcessId;
			$monitorProcessesId = Utilities::run_in_background($cmd);
		}
		sleep(15);//15 seconds
	}

}

function monitorProcessWatch($parentProcessId){

	$m = new _MeasurePerformance();
	$mysql = new _MySQL();
	$mysql->connect(Setup::$connectionArray);

	$parallelProcessesMonitors = Setup::$settings['max_monitor_processes'];

	$monitorProcesses = array();
	$processCountMonitors = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

	$ipDomain = false;

	while (true) {
		// are we still running?
		if(!Utilities::is_process_running($parentProcessId)){
				_Logging::appLog("Parent Stopped - monitorStartWatch exited");
				exit();
		}

		$processCountMonitors = count($monitorProcesses);

		if ($processCountMonitors < $parallelProcessesMonitors){
				$ipDomain = Utilities::getNextMonitor($mysql);
				if ($ipDomain!==false) {
						// start it
						$cmd = 'php '.dirname(__FILE__).'/monitorJob.php -h '.escapeshellarg($ipDomain);
						$pid = Utilities::run_in_background($cmd);
						$m->work(1);
						$monitorProcesses[] = $pid;
				}
		}

		// was there any work?
		if($ipDomain===false){
				sleep(10);//10 seconds
		}else{
				usleep(10000);//ideal time 10ms
		}

		// delete finished processes
		for ($x = 0; $x < $processCountMonitors; $x++) {
				if(isset($monitorProcesses[$x])){
						if(!Utilities::is_process_running($monitorProcesses[$x])){
								unset($monitorProcesses[$x]);
						}
				}
		}

		// fix array index
		$monitorProcesses = array_values($monitorProcesses);

		$processCountMonitors = count($monitorProcesses);

		//randomly reset counter every now and then
		if(mt_rand(1,2000)==1){
			$m->endWork();
			_Logging::appLog("App Avg Hosts/sec: {$m->avgPerformance}\tMonitor Threads: $processCountMonitors/$parallelProcessesMonitors");
			$m = new _MeasurePerformance();
		}

	}

}


1		#!/bin/php
2		<?php
3
4		//prevent non cli access
5		if(php_sapi_name()!=='cli') exit();
6
7		$dir = dirname(dirname(__FILE__));
8		class_exists('Setup', false) or include($dir.'/classes/Setup.class.php');
9		class_exists('Utilities', false) or include($dir.'/classes/Utilities.class.php');
10		class_exists('_MySQL', false) or include($dir.'/classes/_MySQL.class.php');
11		class_exists('_MeasurePerformance', false) or include($dir.'/classes/_MeasurePerformance.class.php');
12
13		$options = getopt("p:i:");
14		$processType = isset($options['p']) ? $options['p'] : 'main';
15		$parentProcessId = isset($options['i']) ? (int)$options['i'] : 0;
16
17
18		switch ($processType) {
19		case 'main';
20		main();
21		break;
22		case 'monitorProcessWatch';
23		monitorProcessWatch($parentProcessId);
24		break;
25		default:
26		_Logging::appLog("Invalid process requested in main script");
27		exit();
28		break;
29		}
30
31
32		function main(){
33		// start process watch
34		$parentProcessId = getmypid();
35		if($parentProcessId == false \|\| $parentProcessId == 0) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-21 21:57 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$parentProcessId` of type `integer` to the boolean `false`. If you are specifically checking for 0, consider using something more explicit like `=== 0` instead. Loading history...
36		_Logging::appLog("Parent process couldnt get pid");
37		}
38
39		$userProcessId = 0;
40		$monitorProcessesId = 0;
41
42		$mysql = new _MySQL();
43
44		// control
45		while (true) {
46		try{
47		$mysql->connect(Setup::$connectionArray);
48		if(!Utilities::is_process_running($userProcessId)){
49		$userCheck = $mysql->runQueryReturnVar("select username from users where beenChecked = 0");
50	View Code Duplication	if($userCheck!==false){
51		$cmd = 'php '.dirname(__FILE__).'/userJob.php -i '.$parentProcessId;
52		$userProcessId = Utilities::run_in_background($cmd);
53		}
54		}
55		} catch (Exception $e) {
56		_Logging::appLog($e->getMessage());
57		}
58	View Code Duplication	if(!Utilities::is_process_running($monitorProcessesId)){
59		$cmd = 'php '.dirname(__FILE__).'/blacklistmonitor.php -p monitorProcessWatch -i '.$parentProcessId;
60		$monitorProcessesId = Utilities::run_in_background($cmd);
61		}
62		sleep(15);//15 seconds
63		}
64
65		}
66
67		function monitorProcessWatch($parentProcessId){
68
69		$m = new _MeasurePerformance();
70		$mysql = new _MySQL();
71		$mysql->connect(Setup::$connectionArray);
72
73		$parallelProcessesMonitors = Setup::$settings['max_monitor_processes'];
74
75		$monitorProcesses = array();
76		$processCountMonitors = 0;
		0 ignored issues – show Unused Code introduced 2015-11-21 21:57 UTC by Report Bug Copy Issue Report `$processCountMonitors` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
77
78		$ipDomain = false;
79
80		while (true) {
81		// are we still running?
82		if(!Utilities::is_process_running($parentProcessId)){
83		_Logging::appLog("Parent Stopped - monitorStartWatch exited");
84		exit();
85		}
86
87		$processCountMonitors = count($monitorProcesses);
88
89		if ($processCountMonitors < $parallelProcessesMonitors){
90		$ipDomain = Utilities::getNextMonitor($mysql);
91		if ($ipDomain!==false) {
92		// start it
93		$cmd = 'php '.dirname(__FILE__).'/monitorJob.php -h '.escapeshellarg($ipDomain);
94		$pid = Utilities::run_in_background($cmd);
95		$m->work(1);
96		$monitorProcesses[] = $pid;
97		}
98		}
99
100		// was there any work?
101		if($ipDomain===false){
102		sleep(10);//10 seconds
103		}else{
104		usleep(10000);//ideal time 10ms
105		}
106
107		// delete finished processes
108		for ($x = 0; $x < $processCountMonitors; $x++) {
109		if(isset($monitorProcesses[$x])){
110		if(!Utilities::is_process_running($monitorProcesses[$x])){
111		unset($monitorProcesses[$x]);
112		}
113		}
114		}
115
116		// fix array index
117		$monitorProcesses = array_values($monitorProcesses);
118
119		$processCountMonitors = count($monitorProcesses);
120
121		//randomly reset counter every now and then
122		if(mt_rand(1,2000)==1){
123		$m->endWork();
124		_Logging::appLog("App Avg Hosts/sec: {$m->avgPerformance}\tMonitor Threads: $processCountMonitors/$parallelProcessesMonitors");
125		$m = new _MeasurePerformance();
126		}
127
128		}
129
130		}
131

mikelynn2 / blacklistmonitor

GitHub Access Token became invalid

Push — master ( 2c70cc...15bbb1 )

blacklistmonitor.php ➔ monitorProcessWatch() C

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like