FeatureContext::__construct() - Code Metrics - Inspection of "add behat and simple cache:clear feature as exampl..." - mikekamornikov/UpgradeSpec - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cdb213...6e1671 )

by Mike

created 2017-01-27 14:16 UTC

FeatureContext::__construct() A

↳ Parent: FeatureContext

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	0

<?php

namespace features\Sugarcrm\UpgradeSpec\Context;

use Behat\Behat\Context\Context;
use PHPUnit_Framework_Assert;
use Sugarcrm\UpgradeSpec\Application;
use Symfony\Component\Console\Tester\CommandTester;

class FeatureContext implements Context
{
    /**
     * @var Application
     */
    private $application;

    /**
     * @var
     */
    private $tester;

    /**
     * FeatureContext constructor.
     */
    public function __construct()
    {
        if (false === @copy(realpath(__DIR__ . '/../../bin/uspec.pubkey'), BEHAT_BIN_PATH . '.pubkey')) {
            throw new \RuntimeException('Application public key is not available');
        }

        $this->application = new Application('SugarCRM upgrade spec generator', '@test');
    }

    /**
     * FeatureContext destructor.
     */
    public function __destruct()
    {
        @unlink(BEHAT_BIN_PATH . '.pubkey');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    }

    /**
     * @When /^I run "([^"]*)" command$/
     */
    public function iRunCommand($name)
    {
        $command = $this->application->find($name);

        $this->tester = new CommandTester($command);
        $this->tester->execute(array('command' => $command->getName()));
    }

    /**
     * @Then /^I should see "([^"]*)"$/
     */
    public function iShouldSee($regexp)
    {
        return call_user_func_array(
            [PHPUnit_Framework_Assert::class, 'assertRegExp'],
            [$regexp, $this->tester->getDisplay()]
        );
    }
}


1			<?php
2
3			namespace features\Sugarcrm\UpgradeSpec\Context;
4
5			use Behat\Behat\Context\Context;
6			use PHPUnit_Framework_Assert;
7			use Sugarcrm\UpgradeSpec\Application;
8			use Symfony\Component\Console\Tester\CommandTester;
9
10			class FeatureContext implements Context
11			{
12			/**
13			* @var Application
14			*/
15			private $application;
16
17			/**
18			* @var
19			*/
20			private $tester;
21
22			/**
23			* FeatureContext constructor.
24			*/
25			public function __construct()
26			{
27			if (false === @copy(realpath(__DIR__ . '/../../bin/uspec.pubkey'), BEHAT_BIN_PATH . '.pubkey')) {
28			throw new \RuntimeException('Application public key is not available');
29			}
30
31			$this->application = new Application('SugarCRM upgrade spec generator', '@test');
32			}
33
34			/**
35			* FeatureContext destructor.
36			*/
37			public function __destruct()
38			{
39			@unlink(BEHAT_BIN_PATH . '.pubkey');
			0 ignored issues – show Security Best Practice introduced 2017-01-27 14:22 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
40			}
41
42			/**
43			* @When /^I run "([^"]*)" command$/
44			*/
45			public function iRunCommand($name)
46			{
47			$command = $this->application->find($name);
48
49			$this->tester = new CommandTester($command);
50			$this->tester->execute(array('command' => $command->getName()));
51			}
52
53			/**
54			* @Then /^I should see "([^"]*)"$/
55			*/
56			public function iShouldSee($regexp)
57			{
58			return call_user_func_array(
59			[PHPUnit_Framework_Assert::class, 'assertRegExp'],
60			[$regexp, $this->tester->getDisplay()]
61			);
62			}
63			}
64

mikekamornikov / UpgradeSpec

Push — master ( cdb213...6e1671 )

FeatureContext::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like