Conditions | 1 |
Paths | 1 |
Total Lines | 82 |
Code Lines | 76 |
Lines | 0 |
Ratio | 0 % |
Tests | 73 |
CRAP Score | 1 |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
30 | 1 | public function getConfigTreeBuilder() |
|
31 | { |
||
32 | 1 | $treeBuilder = new TreeBuilder(); |
|
33 | 1 | $rootNode = $treeBuilder->root('gearman'); |
|
|
|||
34 | |||
35 | $rootNode |
||
36 | 1 | ->children() |
|
37 | 1 | ->arrayNode('bundles') |
|
38 | 1 | ->prototype('array') |
|
39 | 1 | ->children() |
|
40 | 1 | ->scalarNode('name') |
|
41 | 1 | ->isRequired() |
|
42 | 1 | ->cannotBeEmpty() |
|
43 | 1 | ->end() |
|
44 | 1 | ->booleanNode('active') |
|
45 | 1 | ->defaultFalse() |
|
46 | 1 | ->end() |
|
47 | 1 | ->arrayNode('include') |
|
48 | 1 | ->prototype('scalar')->end() |
|
49 | 1 | ->end() |
|
50 | 1 | ->arrayNode('ignore') |
|
51 | 1 | ->prototype('scalar')->end() |
|
52 | 1 | ->end() |
|
53 | 1 | ->end() |
|
54 | 1 | ->end() |
|
55 | 1 | ->end() |
|
56 | 1 | ->arrayNode('servers') |
|
57 | 1 | ->performNoDeepMerging() |
|
58 | 1 | ->defaultValue(array( |
|
59 | 'localhost' => array( |
||
60 | 'host' => '127.0.0.1', |
||
61 | 'port' => '4730', |
||
62 | 1 | ), |
|
63 | )) |
||
64 | 1 | ->prototype('array') |
|
65 | 1 | ->children() |
|
66 | 1 | ->scalarNode('host') |
|
67 | 1 | ->isRequired() |
|
68 | 1 | ->cannotBeEmpty() |
|
69 | 1 | ->end() |
|
70 | 1 | ->integerNode('port') |
|
71 | 1 | ->defaultValue('4730') |
|
72 | 1 | ->end() |
|
73 | 1 | ->end() |
|
74 | 1 | ->end() |
|
75 | 1 | ->end() |
|
76 | 1 | ->arrayNode('defaults') |
|
77 | 1 | ->addDefaultsIfNotSet() |
|
78 | 1 | ->children() |
|
79 | 1 | ->integerNode('iterations') |
|
80 | 1 | ->min(0) |
|
81 | 1 | ->defaultValue(0) |
|
82 | 1 | ->end() |
|
83 | 1 | ->scalarNode('method') |
|
84 | 1 | ->defaultValue('doNormal') |
|
85 | 1 | ->end() |
|
86 | 1 | ->booleanNode('callbacks') |
|
87 | 1 | ->defaultTrue() |
|
88 | 1 | ->end() |
|
89 | 1 | ->scalarNode('job_prefix') |
|
90 | 1 | ->defaultNull() |
|
91 | 1 | ->end() |
|
92 | 1 | ->booleanNode('generate_unique_key') |
|
93 | 1 | ->defaultTrue() |
|
94 | 1 | ->end() |
|
95 | 1 | ->booleanNode('workers_name_prepend_namespace') |
|
96 | 1 | ->defaultTrue() |
|
97 | 1 | ->end() |
|
98 | 1 | ->integerNode('minimum_execution_time') |
|
99 | 1 | ->min(0) |
|
100 | 1 | ->defaultValue(0) |
|
101 | 1 | ->end() |
|
102 | 1 | ->integerNode('timeout') |
|
103 | 1 | ->min(0) |
|
104 | 1 | ->defaultValue(0) |
|
105 | 1 | ->end() |
|
106 | 1 | ->end() |
|
107 | 1 | ->end() |
|
108 | 1 | ->end(); |
|
109 | |||
110 | 1 | return $treeBuilder; |
|
111 | } |
||
112 | } |
||
113 |
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.
To visualize
will produce issues in the first and second line, while this second example
will produce no issues.