Mkk\GearmanBundle\Command\GearmanWorkerListCommand

Complexity

Total Complexity

8

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

84%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setGearmanClient()	0	6	1
A	configure()	0	8	1
B	execute()	0	30	6

<?php

/**
 * Gearman Bundle for Symfony2 / Symfony3
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * Feel free to edit as you please, and have fun.
 *
 * @author Marc Morera <yuhu@mmoreram.com>
 */

namespace Mkk\GearmanBundle\Command;

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Mkk\GearmanBundle\Command\Abstracts\AbstractGearmanCommand;
use Mkk\GearmanBundle\Service\GearmanClient;

/**
 * Gearman Job List Command class
 */
class GearmanWorkerListCommand extends AbstractGearmanCommand
{
    /**
     * @var GearmanClient
     *
     * Gearman client
     */
    protected $gearmanClient;

    /**
     * Set gearman client
     *
     * @param GearmanClient $gearmanClient Gearman client
     *
     * @return GearmanWorkerListCommand self Object
     */
    public function setGearmanClient(GearmanClient $gearmanClient)
    {
        $this->gearmanClient = $gearmanClient;

        return $this;
    }

    /**
     * Console Command configuration
     */
    protected function configure()
    {
        parent::configure();

        $this
            ->setName('gearman:worker:list')
            ->setDescription('List all Gearman Workers and their Jobs');
    }

    /**
     * Executes the current command.
     *
     * @param InputInterface  $input  An InputInterface instance
     * @param OutputInterface $output An OutputInterface instance
     *
     * @return integer 0 if everything went fine, or an error code

Should the return type not be integer|null?

     *
     * @throws \LogicException When this abstract class is not implemented
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        if ($input->getOption('quiet')) {
            return;
        }

        $workers = $this->gearmanClient->getWorkers();

        if (is_array($workers)) {

            $it = 1;

Avoid variables with short names like $it. Configured minimum length is 3.

            foreach ($workers as $worker) {

                $output->writeln('<comment>@Worker:  </comment><info>' . $worker['className'] . '</info>');
                $output->writeln('<comment>callablename:  </comment><info>' . $worker['callableName'] . '</info>');
                $output->writeln('<comment>Jobs:</comment>');
                foreach ($worker['jobs'] as $job) {
                    $output->writeln('<comment>  - #' . $it++ . '</comment>');

Increment and decrement operators must be bracketed when used in string concatenation

                    $output->writeln('<comment>      name: ' . $job['methodName'] . '</comment>');
                    $output->writeln('<comment>      callablename:</comment><info> ' . $job['realCallableNameNoPrefix'] . '</info>');

This line exceeds maximum limit of 120 characters; contains 133 characters

                    if (false === is_null($job['jobPrefix'])) {

                        $output->writeln('<comment>      jobPrefix:</comment><info> ' . $job['jobPrefix'] . '</info>');
                    }
                }
            }
        }
    }
}

As per coding style, files should not end with a newline character.