MidasSoft\DominicanBankParser\Parsers\PopularBankParser::parse()

Complexity

Conditions	2
Paths	1

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	2

Importance

Changes

0

<?php
    public function parse(AbstractFile $file)
    {
        $collection = new DepositCollection();
        $fileArray = array_slice($file->toArray(), 5);

        array_walk($fileArray, function ($line, $key) use (&$collection) {

The parameter $key is not used and could be removed.

            if (!PopularValidator::validate($line)) {
                return;
            }

            $collection->push(new Deposit($line[2], $line[0], $line[5], $line[1]));
        });

        $this->failIfParsedFileIsEmpty($collection);
        $this->cache($collection);

        return $collection;

The expression return $collection returns the type MidasSoft\DominicanBankParser\Collections\DepositCollection which is incompatible with the documented return type array.

    }