MidasSoft\DominicanBankParser\Parsers\ReservasBankParser

Complexity

Total Complexity

2

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Test Coverage

Coverage

90%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	parse()	0	17	2

<?php

namespace MidasSoft\DominicanBankParser\Parsers;

use MidasSoft\DominicanBankParser\Collections\DepositCollection;
use MidasSoft\DominicanBankParser\Deposit;
use MidasSoft\DominicanBankParser\Files\CSV;
use MidasSoft\DominicanBankParser\Files\AbstractFile;
use MidasSoft\DominicanBankParser\Traits\InteractsWithArrayTrait;
use MidasSoft\DominicanBankParser\Validators\ReservasValidator;

class ReservasBankParser extends AbstractParser
{
    use InteractsWithArrayTrait;

    /**
     * Eliminates unnecesary values into
     * a Reservas bank file and convert it
     * to array.
     *
     * @param \MidasSoft\DominicanBankParser\Files\CSV $file
     *
     * @throws \MidasSoft\DominicanBankParser\Exceptions\InvalidArgumentException
     * @throws \MidasSoft\DominicanBankParser\Exceptions\EmptyFileException
     *
     * @return array
     */
    public function parse(AbstractFile $file)
    {
        $collection = new DepositCollection();
        $fileArray = array_slice($file->toArray(), 1);

        array_walk($fileArray, function ($line, $key) use (&$collection) {

The parameter $key is not used and could be removed.

            if (!ReservasValidator::validate($line)) {
                return;
            }

            $collection->push(new Deposit(trim($line[5]), $line[1], $line[7], $line[2]));

trim($line[5]) of type string is incompatible with the type double expected by parameter $amount of MidasSoft\DominicanBankParser\Deposit::__construct().

        });

        $this->failIfParsedFileIsEmpty($collection);
        $this->cache($collection);

        return $collection;

The expression return $collection returns the type MidasSoft\DominicanBankParser\Collections\DepositCollection which is incompatible with the documented return type array.

    }
}