ConfigCollection::set() - Code Metrics - Inspection of "Added config cache interface" - micmania1/silverstripe-config - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — add-cache (2af103)

by Michael

created 2016-10-15 13:23 UTC

ConfigCollection::set() A

↳ Parent: ConfigCollection

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	14
rs	9.4285
cc	2
eloc	6
nc	2
nop	2

<?php

namespace micmania1\config;

class ConfigCollection implements ConfigCollectionInterface
{

    /**
     * Stores a list of key/value config.
     *
     * @var array
     */
    protected $config = [];

    /**
     * @var boolean
     */
    protected $trackMetadata = false;

    public function __construct($trackMetadata = false)
    {
        $this->trackMetadata = $trackMetadata;
    }

    /**
     * {@inheritdoc}
     */
    public function set($key, ConfigItemInterface $item)
    {
        if(!$this->exists($key)) {
            $this->config[$key] = $item;
        }

        // Get the existing item so we can set the new value on it
        $existing = $this->config[$key];

        // Ensure that that tracking is correct for items belonging to this collection
        $existing->trackMetadata($this->trackMetadata);

        $existing->set($item->getValue(), $item->getMetadata());
    }

    /**
     * {@inheritdoc}
     */
    public function get($key)
    {
        if(!$this->exists($key)) {
            return null;
        }

        return $this->config[$key];
    }

    /**
     * {@inheritdoc}
     */
    public function exists($key)
    {
        return array_key_exists($key, $this->config);
    }

    /**
     * {@inheritdoc}
     */
    public function delete($key)
    {
        if($this->exists($key)) {
            unset($this->config[$key]);
        }
    }
}


1			<?php
2
3			namespace micmania1\config;
4
5			class ConfigCollection implements ConfigCollectionInterface
6			{
7
8			/**
9			* Stores a list of key/value config.
10			*
11			* @var array
12			*/
13			protected $config = [];
14
15			/**
16			* @var boolean
17			*/
18			protected $trackMetadata = false;
19
20			public function __construct($trackMetadata = false)
21			{
22			$this->trackMetadata = $trackMetadata;
23			}
24
25			/**
26			* {@inheritdoc}
27			*/
28			public function set($key, ConfigItemInterface $item)
29			{
30			if(!$this->exists($key)) {
31			$this->config[$key] = $item;
32			}
33
34			// Get the existing item so we can set the new value on it
35			$existing = $this->config[$key];
36
37			// Ensure that that tracking is correct for items belonging to this collection
38			$existing->trackMetadata($this->trackMetadata);
39
40			$existing->set($item->getValue(), $item->getMetadata());
41			}
42
43			/**
44			* {@inheritdoc}
45			*/
46			public function get($key)
47			{
48			if(!$this->exists($key)) {
49			return null;
50			}
51
52			return $this->config[$key];
53			}
54
55			/**
56			* {@inheritdoc}
57			*/
58			public function exists($key)
59			{
60			return array_key_exists($key, $this->config);
61			}
62
63			/**
64			* {@inheritdoc}
65			*/
66			public function delete($key)
67			{
68			if($this->exists($key)) {
69			unset($this->config[$key]);
70			}
71			}
72			}
73

micmania1 / silverstripe-config

Branch — add-cache (2af103)

ConfigCollection::set() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like