ConfigItem::set() - Code Metrics - Inspection of "REFACTOR: Added config collection" - micmania1/silverstripe-config - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

by Michael

created 2016-10-15 02:44 UTC

ConfigItem::set() A

↳ Parent: ConfigItem

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	2
crap	2

<?php

namespace micmania1\config;

class ConfigItem implements ConfigItemInterface
{
    /**
     * @var mixed
     */
    protected $value;

    /**
     * @var array
     */
    protected $metaData = [];

    /**
     * @var array
     */
    protected $history = [];

    /**
     * @var boolean
     */
    protected $trackHistory = true;

    public function __construct($value, array $metaData = [], $trackHistory = true)
    {
        $this->value = $value;
        $this->metaData = $metaData;
        $this->trackHistory = (boolean) $trackHistory;
    }

    public function set($value, $metaData = [])
    {
        if($this->trackHistory) {
            // Clone will clear the history to prevent recursion
            $previous = clone $this;
            $this->history[] = $previous;
        }

        $this->value = $value;
        $this->metaData = $metaData;
    }

    /**
     * @return mixed
     */
    public function getValue()
    {
        return $this->value;
    }

    /**
     * @return array
     */
    public function getMetaData()
    {
        return $this->metaData;
    }

    /**
     * Fetch the item history ordered in descending order by data
     *
     * @return CollectionItemInterface[]
     */
    public function getHistory()
    {
        return $this->history;
    }

    /**
     * History is an array of historical records of itself so we clear it to prevent
     * recursion.
     */
    public function __clone()
    {
        $this->history = [];
    }
}


1		<?php
2
3		namespace micmania1\config;
4
5		class ConfigItem implements ConfigItemInterface
6		{
7		/**
8		* @var mixed
9		*/
10		protected $value;
11
12		/**
13		* @var array
14		*/
15		protected $metaData = [];
16
17		/**
18		* @var array
19		*/
20		protected $history = [];
21
22		/**
23		* @var boolean
24		*/
25		protected $trackHistory = true;
26
27	22	public function __construct($value, array $metaData = [], $trackHistory = true)
28		{
29	22	$this->value = $value;
30	22	$this->metaData = $metaData;
31	22	$this->trackHistory = (boolean) $trackHistory;
32	22	}
33
34	22	public function set($value, $metaData = [])
35		{
36	22	if($this->trackHistory) {
37		// Clone will clear the history to prevent recursion
38	22	$previous = clone $this;
39	22	$this->history[] = $previous;
40	22	}
41
42	22	$this->value = $value;
43	22	$this->metaData = $metaData;
44	22	}
45
46		/**
47		* @return mixed
48		*/
49	22	public function getValue()
50		{
51	22	return $this->value;
52		}
53
54		/**
55		* @return array
56		*/
57	22	public function getMetaData()
58		{
59	22	return $this->metaData;
60		}
61
62		/**
63		* Fetch the item history ordered in descending order by data
64		*
65		* @return CollectionItemInterface[]
66		*/
67	1	public function getHistory()
68		{
69	1	return $this->history;
70		}
71
72		/**
73		* History is an array of historical records of itself so we clear it to prevent
74		* recursion.
75		*/
76	22	public function __clone()
77		{
78	22	$this->history = [];
79	22	}
80		}
81

micmania1 / silverstripe-config

Pull Request — master (#1)

ConfigItem::set() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like